Differential D20244

Clean up a few "%Q" stragglers in SVN repository browsing code
ClosedPublic
Actions

Authored by epriestley on Mar 2 2019, 2:16 PM.

Tags

None

Referenced Files

	F18808029: D20244.diff
	Sun, Oct 19, 4:44 AM

	F18787269: D20244.id.diff
	Tue, Oct 14, 10:53 PM

	F18761604: D20244.diff
	Mon, Oct 6, 3:21 PM

	F18756699: D20244.id48311.diff
	Sun, Oct 5, 12:50 PM

	F18558750: D20244.diff
	Sep 8 2025, 8:45 PM

	F18101902: D20244.id48311.diff
	Aug 9 2025, 4:30 PM

	F17990101: D20244.id.diff
	Aug 2 2025, 12:21 AM

	F17949123: D20244.diff
	Jul 31 2025, 10:52 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP34e90d8f5139: Clean up a few "%Q" stragglers in SVN repository browsing code

Summary

See https://discourse.phabricator-community.org/t/unsafe-raw-string-warning-for-svn-in-diffusion/2469.

Test Plan

Browed a Subversion repository in Diffusion. These are all reachable from the main landing page if the repository has commits/files, I think. Before change: errors in log; after change: no issues.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 2 2019, 2:16 PM

Harbormaster completed remote builds in B22172: Diff 48311.Mar 2 2019, 2:18 PM

epriestley requested review of this revision.Mar 2 2019, 2:18 PM

amckinley accepted this revision.Mar 5 2019, 5:10 PM

This revision is now accepted and ready to land.Mar 5 2019, 5:10 PM

Closed by commit rP34e90d8f5139: Clean up a few "%Q" stragglers in SVN repository browsing code (authored by epriestley). · Explain WhyMar 5 2019, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

12 lines

DiffusionHistoryQueryConduitAPIMethod.php

12 lines

Diff 48321

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php