Page MenuHomePhabricator

When highlighting source, catch "python" for the PHP parser
ClosedPublic

Authored by epriestley on Feb 28 2019, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 19, 9:07 AM
Unknown Object (File)
Mon, Nov 14, 12:48 AM
Unknown Object (File)
Tue, Nov 8, 10:44 PM
Unknown Object (File)
Mon, Nov 7, 4:33 PM
Unknown Object (File)
Sat, Nov 5, 1:00 PM
Unknown Object (File)
Oct 11 2022, 9:16 AM
Unknown Object (File)
Oct 2 2022, 12:15 PM
Unknown Object (File)
Sep 30 2022, 8:40 AM
Subscribers
None

Details

Summary

See PHI1065. Normally, Python files are called ".py" and we end up with the lexer coded as "py" by the time we get here, but if you "Highlight As..." and select "Python" we can end up here with "python". (Probably also if you name a file "something.python", although this is very unusual.)

Catch both "py" and "python" for our highlighter.

T3626 should eventually standardize and moot this, but since this patch is only a quarter of a line long it seems reasonable until then.

Test Plan

Added a phlog(), verified we now hit the first-party highlighter with "Highlight As... > Python".

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable