Page MenuHomePhabricator
Create Task
Maniphest T13258

Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)
Closed, ResolvedPublic
Actions

Description

These flags have reasonable arguments for existence:

  • Does Not Block Draft Promotion (see: PHI896, PHI715).
  • Build Can Not Restart (see: PHI1093).
  • Does Not Prevent Landing (see: T13108, email, various other references).
  • Does Not Count At All Ever

In all cases except "can not restart", options "Always", "If Building", and "Never" probably make sense.

This is kind of far afield, but it would be nice for a build plan to be able to list Herald Rules which run the plan. (Currently, there's no efficient way to query for Herald actions which affect a particular PHID.)

Revisions and Commits

rARC Arcanist
D20236rARCf6b8480adce5 Implement "Warn When Landing" behavior for Build Plans in Arcanist
rP Phabricator
D20252rPc1bff3b8013e Add an "Restartable: If Failed" behavior to Harbormaster build plans
D20259rP950a7bbb19e3 On Harbormaster build plans, show which Herald rules trigger builds
D20239rP7e4681234467 Add a warning to revision timelines when changes land with ongoing or failed…
D20233rPf97df9ebea90 Implement Build Plan behavior "Affects Buildable"
D20232rP718cdc24471a Implement Build Plan "Hold Drafts" behavior
D20230rP578de333dfa5 Make the new Build Plan behavior "Restartable" work
D20229rPee0ad4703ebd Make the new Build Plan "Runnable" behavior work
D20228rP983cf885e7ce Expose Build Plan behaviors via "harbormaster.buildplan.search"
D20220rPd36d0efc3570 Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing…
D20219rP620047bcfe3f Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds…
D20218rP8338f940573c Provide "harbormaster.buildplan.edit" in the API
D20217rPf6ed873f1728 Move Harbormaster Build Plans to modular transactions

Related Objects
Search...

Event Timeline

epriestley triaged this task as Normal priority.Feb 26 2019, 12:41 PM
epriestley created this task.
Herald added subscribers: amckinley, faulconbridge. · View Herald TranscriptFeb 26 2019, 12:41 PM
epriestley updated the task description. (Show Details)Feb 26 2019, 12:48 PM
epriestley added a revision: D20217: Move Harbormaster Build Plans to modular transactions.Feb 26 2019, 1:17 PM
epriestley added a revision: D20218: Provide "harbormaster.buildplan.edit" in the API.Feb 26 2019, 1:24 PM
epriestley added a revision: D20219: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends.Feb 26 2019, 1:49 PM
epriestley updated the task description. (Show Details)Feb 26 2019, 3:26 PM
epriestley added a subtask: T11415: Would like people who can't edit Harbormaster plans to be able to run them.
epriestley added a revision: D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.Feb 26 2019, 5:44 PM
epriestley added a commit: rPf6ed873f1728: Move Harbormaster Build Plans to modular transactions.Feb 28 2019, 3:32 PM
epriestley added a commit: rP8338f940573c: Provide "harbormaster.buildplan.edit" in the API.Feb 28 2019, 3:36 PM
epriestley added a commit: rP620047bcfe3f: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds….Feb 28 2019, 3:38 PM
epriestley added a revision: D20228: Expose Build Plan behaviors via "harbormaster.buildplan.search".Feb 28 2019, 7:01 PM
epriestley mentioned this in T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.Feb 28 2019, 7:30 PM
epriestley added a revision: D20229: Make the new Build Plan "Runnable" behavior work.Feb 28 2019, 7:41 PM
epriestley added a revision: D20230: Make the new Build Plan behavior "Restartable" work.Feb 28 2019, 8:05 PM
epriestley added a revision: D20232: Implement Build Plan "Hold Drafts" behavior.Feb 28 2019, 9:12 PM
epriestley added a revision: D20233: Implement Build Plan behavior "Affects Buildable".Feb 28 2019, 9:24 PM
epriestley mentioned this in T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.Feb 28 2019, 9:28 PM
epriestley added a revision: D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.Mar 1 2019, 2:13 PM
epriestley added a revision: D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.Mar 1 2019, 3:54 PM
epriestley added a commit: rPd36d0efc3570: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing….Mar 6 2019, 1:40 PM
epriestley added a commit: rP983cf885e7ce: Expose Build Plan behaviors via "harbormaster.buildplan.search".Mar 6 2019, 1:47 PM
epriestley added a commit: rPee0ad4703ebd: Make the new Build Plan "Runnable" behavior work.Mar 6 2019, 2:01 PM
epriestley closed subtask T11415: Would like people who can't edit Harbormaster plans to be able to run them as Resolved.
epriestley added a commit: rP578de333dfa5: Make the new Build Plan behavior "Restartable" work.Mar 6 2019, 2:26 PM
epriestley added a commit: rP718cdc24471a: Implement Build Plan "Hold Drafts" behavior.
epriestley added a commit: rPf97df9ebea90: Implement Build Plan behavior "Affects Buildable".Mar 6 2019, 2:30 PM
epriestley added a commit: rP7e4681234467: Add a warning to revision timelines when changes land with ongoing or failed….Mar 6 2019, 2:32 PM
epriestley added a commit: rARCf6b8480adce5: Implement "Warn When Landing" behavior for Build Plans in Arcanist.Mar 6 2019, 2:48 PM
epriestley added a revision: D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.Mar 6 2019, 5:39 PM
epriestley added a revision: D20259: On Harbormaster build plans, show which Herald rules trigger builds.Mar 7 2019, 2:22 PM
epriestley added a commit: rP950a7bbb19e3: On Harbormaster build plans, show which Herald rules trigger builds.Mar 7 2019, 9:51 PM
epriestley closed this task as Resolved.Mar 7 2019, 10:53 PM
epriestley claimed this task.
epriestley added a commit: rPc1bff3b8013e: Add an "Restartable: If Failed" behavior to Harbormaster build plans.Mar 8 2019, 12:48 AM
Phabricator · Built by Phacility