Page MenuHomePhabricator
Differential D18959

Support new data export infrastructure in Maniphest
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 4:25 PM.
Tags
None
Referenced Files
F15414306: D18959.id45483.diff
Thu, Mar 20, 12:06 AM
F15377781: D18959.diff
Thu, Mar 13, 10:45 AM
F15360866: D18959.id45483.diff
Tue, Mar 11, 10:52 AM
Unknown Object (File)
Mon, Feb 24, 1:20 PM
Unknown Object (File)
Feb 17 2025, 10:04 PM
Unknown Object (File)
Feb 10 2025, 7:26 AM
Unknown Object (File)
Feb 9 2025, 5:07 AM
Unknown Object (File)
Feb 9 2025, 5:07 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.)
Commits
rP2ac4e1991b4d: Support new data export infrastructure in Maniphest
Summary

Depends on D18958. Ref T13049. Support the new stuff. There are a couple more fields this needs to strictly improve on the old export, but I'll add them as extensions shortly.

Test Plan

Exported tasks to Excel, saw reasonble-looking data in the export.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 29 2018, 4:25 PM
Harbormaster completed remote builds in B19243: Diff 45459.Jan 29 2018, 4:26 PM
epriestley requested review of this revision.Jan 29 2018, 4:26 PM
epriestley added a child revision: D18960: Implement common infrastructure fields as export extensions.Jan 29 2018, 4:52 PM
amckinley accepted this revision.Jan 29 2018, 9:37 PM

Otherwise looks good.

src/applications/maniphest/query/ManiphestTaskSearchEngine.php
467

Should this be ->setLabel(pht('subtype'))?

This revision is now accepted and ready to land.Jan 29 2018, 9:37 PM
epriestley added a comment.Jan 29 2018, 10:10 PM

Good catch! I think I eventually caught that a couple diffs down the line but didn't backport it.

epriestley mentioned this in T5391: Support custom fields in 'Export to Excel'.Jan 29 2018, 11:08 PM
Closed by commit rP2ac4e1991b4d: Support new data export infrastructure in Maniphest (authored by epriestley). · Explain WhyJan 30 2018, 12:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
maniphest/
application/
2 lines
query/
107 lines
infrastructure/
export/
field/
4 lines

Diff 45483

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/infrastructure/export/field/PhabricatorURIExportField.php

Loading...
Phabricator · Built by Phacility