Page MenuHomePhabricator

Support new data export infrastructure in Maniphest
ClosedPublic

Authored by epriestley on Jan 29 2018, 4:25 PM.

Details

Summary

Depends on D18958. Ref T13049. Support the new stuff. There are a couple more fields this needs to strictly improve on the old export, but I'll add them as extensions shortly.

Test Plan

Exported tasks to Excel, saw reasonble-looking data in the export.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 29 2018, 4:25 PM
epriestley requested review of this revision.Jan 29 2018, 4:26 PM
amckinley accepted this revision.Jan 29 2018, 9:37 PM

Otherwise looks good.

src/applications/maniphest/query/ManiphestTaskSearchEngine.php
467

Should this be ->setLabel(pht('subtype'))?

This revision is now accepted and ready to land.Jan 29 2018, 9:37 PM

Good catch! I think I eventually caught that a couple diffs down the line but didn't backport it.

This revision was automatically updated to reflect the committed changes.