Page MenuHomePhabricator

Update upstream build steps to include timeouts and limits
Open, NormalPublic


See PHI766, which is roughly "allow builds to fail when they produce too much output".

See PHI533, which is roughly "allow builds to fail when a 'wait' after an HTTP request takes too long".

I'm pretty sure there's also an "ssh exec should have a timeout" task somewhere. It clearly should.

See T12701, about improving URL validation for "Make HTTP Request" steps. This is a relatively easy thing to tighten up.

See PHI875, which is roughly T10510. cURL timeouts are not configurable, and are reported to Harbormaster in a confusing way.

Event Timeline

epriestley triaged this task as Normal priority.Mar 1 2019, 5:19 PM
epriestley created this task.

Currently, properties on upstream build steps are driven by CustomFields. T13248 briefly discusses a bit of context.

I likely want to convert these to EditFields before adding a bunch of new timeouts and stuff.

(The timeouts themselves are probably mostly trivial to add.)