Page MenuHomePhabricator

Make drag-and-drop on workboards interact with priority column headers
ClosedPublic

Authored by epriestley on Mar 5 2019, 7:13 PM.

Details

Summary

Ref T10333. Ref T8135. Depends on D20247. Allow users to drag-and-drop cards on a priority-sorted workboard under headers, even if the header has no other cards.

As of D20247, headers show up but they aren't really interactive. Now, you can drag cards directly underneath a header (instead of only between other cards). For example, if a column has only one "Wishlist" task, you may drag it under the "High", "Normal", or "Low" priority headers to select a specific priority.

(Some of this code still feels a little rough, but I think it will generalize once other types of sorting are available.)

Test Plan

Dragged cards within and between priority groups, saw appropriate priority edits applied in every case I could come up with.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 5 2019, 7:13 PM
epriestley requested review of this revision.Mar 5 2019, 7:15 PM
amckinley accepted this revision.Mar 9 2019, 7:32 AM
This revision is now accepted and ready to land.Mar 9 2019, 7:32 AM
This revision was automatically updated to reflect the committed changes.