Differential D20243

No-op old search indexing migrations which no longer run and have been obsoleted by upgrade "activities"
ClosedPublic
Actions

Authored by epriestley on Mar 2 2019, 2:08 PM.

Details

Reviewers

Commits

rPee2bc07c9025: No-op old search indexing migrations which no longer run and have been…

Summary

See T13253. After D20200 (which changed the task schema) these migrations no longer run, since the PHP code will expect a column to exist that won't exist until a 20190220. migration runs.

We don't need these migrations, since anyone upgrading through September 2017 gets a "rebuild search indexes" activity anyway (see T11932). Just no-op them.

Test Plan

Grepped for queueDocumentForIndexing() in autopatches/, removed all of it.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 2 2019, 2:08 PM

Owners added a subscriber: Restricted Owners Package.Mar 2 2019, 2:08 PM

Harbormaster completed remote builds in B22171: Diff 48310.Mar 2 2019, 2:10 PM

epriestley requested review of this revision.Mar 2 2019, 2:10 PM

amckinley accepted this revision.Mar 5 2019, 6:27 PM

This revision is now accepted and ready to land.Mar 5 2019, 6:27 PM

Closed by commit rPee2bc07c9025: No-op old search indexing migrations which no longer run and have been… (authored by epriestley). · Explain WhyMar 5 2019, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			resources/sql/autopatches/20151221.search.3.reindex.php (10 lines)
M			resources/sql/autopatches/20160221.almanac.2.devicei.php (10 lines)
M			resources/sql/autopatches/20160221.almanac.4.servicei.php (10 lines)
M			resources/sql/autopatches/20160221.almanac.6.networki.php (10 lines)
M			resources/sql/autopatches/20160227.harbormaster.2.plani.php (10 lines)
M			resources/sql/autopatches/20160303.drydock.2.bluei.php (10 lines)
M			resources/sql/autopatches/20160308.nuance.04.sourcei.php (10 lines)
M			resources/sql/autopatches/20160406.badges.ngrams.php (10 lines)
M			resources/sql/autopatches/20160927.phurl.ngrams.php (10 lines)
M			resources/sql/autopatches/20161011.conpherence.ngrams.php (10 lines)
M			resources/sql/autopatches/20161216.dashboard.ngram.02.php (20 lines)
M			resources/sql/autopatches/20170526.milestones.php (10 lines)
M			resources/sql/autopatches/20171026.ferret.05.ponder.index.php (10 lines)