Page MenuHomePhabricator

No-op old search indexing migrations which no longer run and have been obsoleted by upgrade "activities"
ClosedPublic

Authored by epriestley on Mar 2 2019, 2:08 PM.

Details

Summary

See T13253. After D20200 (which changed the task schema) these migrations no longer run, since the PHP code will expect a column to exist that won't exist until a 20190220. migration runs.

We don't need these migrations, since anyone upgrading through September 2017 gets a "rebuild search indexes" activity anyway (see T11932). Just no-op them.

Test Plan

Grepped for queueDocumentForIndexing() in autopatches/, removed all of it.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 2 2019, 2:08 PM
Owners added a subscriber: Restricted Owners Package.Mar 2 2019, 2:08 PM
epriestley requested review of this revision.Mar 2 2019, 2:10 PM
amckinley accepted this revision.Mar 5 2019, 6:27 PM
This revision is now accepted and ready to land.Mar 5 2019, 6:27 PM
This revision was automatically updated to reflect the committed changes.