Page MenuHomePhabricator

Refine the "Mangled Webserver Response" setup check
ClosedPublic

Authored by epriestley on Fri, Mar 1, 3:47 AM.

Details

Summary

Ref T13259. In some configurations, making a request to ourselves may return a VPN/Auth response from some LB/appliance layer.

If this response begins or ends with whitespace, we currently detect it as "extra whitespace" instead of "bad response".

Instead, require that the response be nearly correct (valid JSON with some extra whitespace, instead of literally anything with some extra whitespace) to hit this specialized check. If we don't hit the specialized case, use the generic "mangled" response error, which prints the actual body so you can figure out that it's just your LB/auth thing doing what it's supposed to do.

Test Plan
  • Rigged responses to add extra whitespace, got "Extra Whitespace" (same as before).
  • Rigged responses to add extra non-whitespace, got "Mangled Junk" (same as before).
  • Rigged responses to add extra whitespace and extra non-whitespace, got "Mangled Junk" with a sample of the document body instead of "Extra Whitespace" (improvement).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Mar 1, 3:47 AM
epriestley requested review of this revision.Fri, Mar 1, 3:49 AM
amckinley accepted this revision.Tue, Mar 5, 7:57 PM
This revision is now accepted and ready to land.Tue, Mar 5, 7:57 PM
This revision was automatically updated to reflect the committed changes.