Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
F18808028: D20234.diff
Sun, Oct 19, 4:44 AM
F18804000: D20234.diff
Sat, Oct 18, 5:20 AM
F18755661: D20234.id.diff
Sun, Oct 5, 6:49 AM
F18751800: D20234.diff
Sat, Oct 4, 12:42 PM
F18733920: D20234.id.diff
Tue, Sep 30, 10:44 PM
F18703616: D20234.diff
Sun, Sep 28, 4:34 AM
F18693545: D20234.id48324.diff
Sat, Sep 27, 1:30 AM
F18467367: D20234.diff
Sep 2 2025, 12:35 PM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable