Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
F15336558: D20234.diff
Sat, Mar 8, 7:35 PM
Unknown Object (File)
Fri, Feb 14, 7:04 AM
Unknown Object (File)
Feb 9 2025, 7:19 AM
Unknown Object (File)
Feb 9 2025, 7:19 AM
Unknown Object (File)
Feb 9 2025, 7:19 AM
Unknown Object (File)
Feb 9 2025, 7:19 AM
Unknown Object (File)
Jan 28 2025, 4:57 AM
Unknown Object (File)
Jan 27 2025, 12:07 PM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable