Page MenuHomePhabricator

Correct a possible fatal in the non-CSRF Duo MFA workflow
ClosedPublic

Authored by epriestley on Mar 1 2019, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 3:42 PM
Unknown Object (File)
Oct 15 2024, 9:08 AM
Unknown Object (File)
Oct 7 2024, 3:59 PM
Unknown Object (File)
Sep 19 2024, 2:33 PM
Unknown Object (File)
Sep 19 2024, 2:32 PM
Unknown Object (File)
Sep 19 2024, 2:25 PM
Unknown Object (File)
Sep 19 2024, 11:41 AM
Unknown Object (File)
Sep 10 2024, 5:55 AM
Subscribers
None

Details

Summary

Ref T13259. If we miss the separate CSRF step in Duo and proceed directly to prompting, we may fail to build a response which turns into a real control and fatal on null->setLabel().

Instead, let MFA providers customize their "bare prompt dialog" response, then make Duo use the same "you have an outstanding request" response for the CSRF and no-CSRF workflows.

Test Plan

Hit Duo auth on a non-CSRF workflow (e.g., edit an MFA provider with Duo enabled). Previously: setLabel() fatal. After patch: smooth sailing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable