Page MenuHomePhabricator

Don't require any special capabilities to apply a "closed a subtask" transaction to a parent task
ClosedPublic

Authored by epriestley on Feb 28 2019, 4:09 PM.
Tags
None
Referenced Files
F18759615: D20223.id48283.diff
Mon, Oct 6, 4:46 AM
F18739940: D20223.id.diff
Wed, Oct 1, 11:37 PM
F18733913: D20223.id.diff
Tue, Sep 30, 10:44 PM
F18728337: D20223.diff
Tue, Sep 30, 9:21 AM
F18673863: D20223.id48297.diff
Thu, Sep 25, 12:21 PM
F18599066: D20223.diff
Sat, Sep 13, 6:33 AM
F18597103: D20223.diff
Sat, Sep 13, 2:08 AM
F18597014: D20223.diff
Sat, Sep 13, 1:59 AM
Subscribers
None

Details

Summary

See PHI1059. If you close a task, we apply an "alice closed a subtask: X" transaction to its parents.

This transaction is purely informative, but currently requires CAN_EDIT permission after T13186. However, we'd prefer to post this transaction anyway, even if: the parent is locked; or the parent is not editable by the acting user.

Replace the implicit CAN_EDIT requirement with no requirement.

(This transaction is only applied internally (by closing a subtask) and can't be applied via the API or any other channel, so this doesn't let attackers spam a bunch of bogus subtask closures all over the place or anything.)

Test Plan
  • Created a parent task A with subtask B.
  • Put task A into an "Edits Locked" status.
  • As a user other than the owner of A, closed B.

Then:

  • Before: Policy exception when trying to apply the "alice closed a subtask: B" transaction to A.
  • After: B closed, A got a transaction despite being locked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable