Page MenuHomePhabricator

Don't require any special capabilities to apply a "closed a subtask" transaction to a parent task
ClosedPublic

Authored by epriestley on Feb 28 2019, 4:09 PM.
Tags
None
Referenced Files
F15416599: D20223.id48283.diff
Thu, Mar 20, 12:22 PM
F15400573: D20223.id48297.diff
Mon, Mar 17, 12:38 PM
F15396159: D20223.id48283.diff
Sun, Mar 16, 12:24 PM
F15391562: D20223.diff
Sat, Mar 15, 10:34 AM
F15385545: D20223.id48283.diff
Fri, Mar 14, 10:49 PM
F15376854: D20223.id48283.diff
Thu, Mar 13, 6:13 AM
F15338885: D20223.id48283.diff
Sun, Mar 9, 1:19 PM
F15284309: D20223.diff
Tue, Mar 4, 9:32 AM
Subscribers
None

Details

Summary

See PHI1059. If you close a task, we apply an "alice closed a subtask: X" transaction to its parents.

This transaction is purely informative, but currently requires CAN_EDIT permission after T13186. However, we'd prefer to post this transaction anyway, even if: the parent is locked; or the parent is not editable by the acting user.

Replace the implicit CAN_EDIT requirement with no requirement.

(This transaction is only applied internally (by closing a subtask) and can't be applied via the API or any other channel, so this doesn't let attackers spam a bunch of bogus subtask closures all over the place or anything.)

Test Plan
  • Created a parent task A with subtask B.
  • Put task A into an "Edits Locked" status.
  • As a user other than the owner of A, closed B.

Then:

  • Before: Policy exception when trying to apply the "alice closed a subtask: B" transaction to A.
  • After: B closed, A got a transaction despite being locked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable