Page MenuHomePhabricator

Implement Build Plan behavior "Affects Buildable"
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:24 PM.

Details

Summary

Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan
  • As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
  • Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
  • "Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
  • "While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

  • "Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 28 2019, 9:24 PM
Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:24 PM
epriestley requested review of this revision.Feb 28 2019, 9:26 PM
amckinley accepted this revision.Mar 5 2019, 7:52 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:52 PM
This revision was automatically updated to reflect the committed changes.