Differential D20233

Implement Build Plan behavior "Affects Buildable"
ClosedPublic
Actions

Authored by epriestley on Feb 28 2019, 9:24 PM.

Tags

None

Referenced Files

	F15453096: D20233.diff
	Sat, Mar 29, 9:22 AM

	F15432265: D20233.diff
	Mon, Mar 24, 5:08 PM

	F15430098: D20233.id48293.diff
	Mon, Mar 24, 5:39 AM

	F15416735: D20233.id.diff
	Thu, Mar 20, 1:14 PM

	F15412670: D20233.diff
	Wed, Mar 19, 2:17 PM

	F15404881: D20233.id48339.diff
	Tue, Mar 18, 9:30 AM

	F15392270: D20233.id48293.diff
	Sat, Mar 15, 2:13 PM

	F15349349: D20233.diff
	Mon, Mar 10, 2:55 PM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)

Commits

rPf97df9ebea90: Implement Build Plan behavior "Affects Buildable"

Summary

Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan

As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
"Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
"While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

"Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 28 2019, 9:24 PM

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:24 PM

Harbormaster completed remote builds in B22155: Diff 48293.Feb 28 2019, 9:26 PM

epriestley requested review of this revision.Feb 28 2019, 9:26 PM

amckinley accepted this revision.Mar 5 2019, 7:52 PM

This revision is now accepted and ready to land.Mar 5 2019, 7:52 PM

Closed by commit rPf97df9ebea90: Implement Build Plan behavior "Affects Buildable" (authored by epriestley). · Explain WhyMar 6 2019, 2:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

engine/

HarbormasterBuildEngine.php

24 lines

plan/

HarbormasterBuildPlanBehavior.php

13 lines

Diff 48339

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Loading...

src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php

Loading...