Page MenuHomePhabricator

Implement Build Plan behavior "Affects Buildable"
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:24 PM.
Tags
None
Referenced Files
F19228122: D20233.diff
Fri, Dec 19, 6:35 PM
F19082938: D20233.id48339.diff
Dec 2 2025, 12:27 PM
F19074942: D20233.id48339.diff
Dec 1 2025, 7:38 AM
F18994508: D20233.id.diff
Nov 19 2025, 12:01 PM
F18985058: D20233.id48293.diff
Nov 17 2025, 12:52 PM
F18789904: D20233.id.diff
Oct 15 2025, 11:40 AM
F18785838: D20233.diff
Oct 14 2025, 1:11 PM
F18733919: D20233.id.diff
Sep 30 2025, 10:44 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan
  • As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
  • Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
  • "Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
  • "While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

Screen Shot 2019-02-28 at 1.21.29 PM.png (78×316 px, 10 KB)

  • "Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

Screen Shot 2019-02-28 at 1.21.49 PM.png (72×323 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:24 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:52 PM
This revision was automatically updated to reflect the committed changes.