Page MenuHomePhabricator

Implement Build Plan behavior "Affects Buildable"
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 8 2024, 2:18 PM
Unknown Object (File)
Jan 31 2024, 5:30 PM
Unknown Object (File)
Jan 22 2024, 8:58 AM
Unknown Object (File)
Jan 22 2024, 8:35 AM
Unknown Object (File)
Jan 22 2024, 8:14 AM
Unknown Object (File)
Jan 7 2024, 5:27 PM
Unknown Object (File)
Jan 3 2024, 6:24 PM
Unknown Object (File)
Dec 30 2023, 4:50 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan
  • As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
  • Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
  • "Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
  • "While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

Screen Shot 2019-02-28 at 1.21.29 PM.png (78×316 px, 10 KB)

  • "Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

Screen Shot 2019-02-28 at 1.21.49 PM.png (72×323 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:24 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:52 PM
This revision was automatically updated to reflect the committed changes.