Page MenuHomePhabricator

Implement Build Plan behavior "Affects Buildable"
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:24 PM.
Tags
None
Referenced Files
F19946042: D20233.id48293.diff
Thu, Apr 16, 10:11 PM
F19941618: D20233.id.diff
Wed, Apr 15, 11:59 AM
F19937189: D20233.diff
Sun, Apr 12, 8:12 PM
F19937188: D20233.diff
Sun, Apr 12, 8:12 PM
F19898519: D20233.diff
Sun, Mar 29, 1:19 PM
F19827205: D20233.diff
Mar 9 2026, 6:52 AM
F19550163: D20233.diff
Jan 27 2026, 7:01 PM
F19228122: D20233.diff
Dec 19 2025, 6:35 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Make the "Affects Buildable" option actually work.

Test Plan
  • As in previous change, created a "wait for HTTP request" build plan and had it always run against every revision.
  • Created revisions, waited a bit, then sent the build a "Fail" message, with different values of "Affects Buildable":
  • "Always": Same behavior as today. Buildable waited for the build, then failed when it failed.
  • "While Building": Buildable waited for the build, but passed even though it failed (buildable has green checkmark even though build is red):

Screen Shot 2019-02-28 at 1.21.29 PM.png (78×316 px, 10 KB)

  • "Never": Buildable passed immediately (buildable has green checkmark even though build is still running):

Screen Shot 2019-02-28 at 1.21.49 PM.png (72×323 px, 10 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:24 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:52 PM
This revision was automatically updated to reflect the committed changes.