Paths

Table of Contentst

Differential D18960

Implement common infrastructure fields as export extensions
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 4:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 19, 8:34 AM

	Unknown Object (File)
	Mon, Jul 15, 2:44 PM

	Unknown Object (File)
	Sat, Jul 13, 8:32 PM

	Unknown Object (File)
	Tue, Jul 9, 10:05 AM

	Unknown Object (File)
	Thu, Jul 4, 5:27 AM

	Unknown Object (File)
	Sun, Jun 30, 9:30 AM

	Unknown Object (File)
	Thu, Jun 27, 3:33 PM

	Unknown Object (File)
	Thu, Jun 27, 8:50 AM

View All 85 Files

Subscribers

Details

Reviewers

Maniphest Tasks

T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.)

Commits

rPc00838878a2d: Implement common infrastructure fields as export extensions

Summary

Depends on D18959. Ref T13049. Provide tags, subscribers, spaces, and created/modified as automatic extensions for all objects which support them.

(Also, for JSON export, be a little more consistent about exporting null instead of empty string when there's no value in a text field.)

Test Plan

Exported users and tasks, saw relevant fields in the export.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 29 2018, 4:52 PM

Harbormaster completed remote builds in B19244: Diff 45460.Jan 29 2018, 4:53 PM

epriestley requested review of this revision.Jan 29 2018, 4:53 PM

epriestley added a child revision: D18961: Remove the old, non-modular Excel export workflow from Maniphest.Jan 29 2018, 4:59 PM

amckinley accepted this revision.Jan 29 2018, 10:32 PM

This revision is now accepted and ready to land.Jan 29 2018, 10:32 PM

epriestley mentioned this in T5391: Support custom fields in 'Export to Excel'.Jan 29 2018, 11:08 PM

Closed by commit rPc00838878a2d: Implement common infrastructure fields as export extensions (authored by epriestley). · Explain WhyJan 30 2018, 12:05 AM

This revision was automatically updated to reflect the committed changes.

ysood added a subscriber: ysood.Mar 1 2019, 1:32 AM

ysood added inline comments.

src/infrastructure/export/field/PhabricatorListExportField.php
7	This causes values in excel spreadsheet to be displayed without spaces. As an example, try exporting tasks with multiple subscribers. The list is exported with no spaces. Exports correctly for csv but when the .csv file is open using excel, it only shows the first value in the list.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

14 lines

applications/

maniphest/

query/

ManiphestTaskSearchEngine.php

2 lines

people/

query/

PhabricatorPeopleSearchEngine.php

4 lines

infrastructure/

export/

engine/

PhabricatorLiskExportEngineExtension.php

42 lines

PhabricatorProjectsExportEngineExtension.php

60 lines

PhabricatorSpacesExportEngineExtension.php

53 lines

PhabricatorSubscriptionsExportEngineExtension.php

60 lines

field/

PhabricatorExportField.php

8 lines

PhabricatorListExportField.php

10 lines

PhabricatorPHIDListExportField.php

10 lines

PhabricatorStringExportField.php

16 lines

PhabricatorStringListExportField.php

4 lines

Diff 45484

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...

src/applications/people/query/PhabricatorPeopleSearchEngine.php

Loading...

src/infrastructure/export/engine/PhabricatorLiskExportEngineExtension.php

Loading...

src/infrastructure/export/engine/PhabricatorProjectsExportEngineExtension.php

Loading...

src/infrastructure/export/engine/PhabricatorSpacesExportEngineExtension.php

Loading...

src/infrastructure/export/engine/PhabricatorSubscriptionsExportEngineExtension.php

Loading...

src/infrastructure/export/field/PhabricatorExportField.php

Loading...

src/infrastructure/export/field/PhabricatorListExportField.php

Loading...

src/infrastructure/export/field/PhabricatorPHIDListExportField.php

Loading...

src/infrastructure/export/field/PhabricatorStringExportField.php

Loading...

src/infrastructure/export/field/PhabricatorStringListExportField.php

Loading...