Page MenuHomePhabricator
Feed Advanced Search

Feb 22 2017

epriestley added a subtask for T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: T7954: Make it easier to upload XHProf profiles.
Feb 22 2017, 12:16 PM · XHProf, Ops, Phacility
epriestley added a parent task for T7954: Make it easier to upload XHProf profiles: T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.
Feb 22 2017, 12:16 PM · Infrastructure, XHProf
epriestley moved T12306: Failing svn connection brings daemon down from Backlog to vNext on the Daemons board.
Feb 22 2017, 12:15 PM · Daemons, Bug Report
epriestley added a project to T12306: Failing svn connection brings daemon down: Daemons.

It is expected that taskmasters will exit and restart after an unexpected failure, but this should not trigger setup warnings. I'll see if I can reproduce this.

Feb 22 2017, 12:14 PM · Daemons, Bug Report
epriestley claimed T12304: Herald fails to add auditors if the author is an auditor.

This might be the same as T12302, but I'll see what's going on.

Feb 22 2017, 12:05 PM · Herald, Bug Report
epriestley added projects to T12305: Persistent chat overlaps various "next" buttons: Design, Conpherence.

Persistent chat was originally a separate column (so it didn't overlap with anything on the page) but was brought into the main page recently.

Feb 22 2017, 12:04 PM · Conpherence, Design, Bug Report
20after4 awarded T10756: Make daemons work correctly no matter where they are or how many copies are running a Orange Medal token.
Feb 22 2017, 4:54 AM · Restricted Project, Daemons

Feb 21 2017

epriestley claimed T12302: Herald adding different auditors but only the last one is kept.
Feb 21 2017, 11:02 PM · Herald, Bug Report
epriestley claimed T12301: `Create Form` always leads to page creating forms for configuring forms.

Yeah I'll take it, pretty sure it's my fault.

Feb 21 2017, 11:01 PM · EditEngine, Bug Report
epriestley added a comment to T12301: `Create Form` always leads to page creating forms for configuring forms.

I think this is probbbbbbbably an actual bug unless I'm totally out of it -- possibly my fault from D17372.

Feb 21 2017, 10:54 PM · EditEngine, Bug Report
ofbeaton awarded T10279: Allow bot users to see email addresses of users a Like token.
Feb 21 2017, 9:26 PM · Feature Request
thoughtpolice awarded T2794: Implement Phage (like Hypershell) a Love token.
Feb 21 2017, 8:57 PM · Phage, Infrastructure
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Feb 21 2017, 4:50 PM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Feb 21 2017, 4:48 PM · Daemons, Ops, Phacility
epriestley added a comment to T12251: Add author information when creating a build in Buildkite.

No.

Feb 21 2017, 4:36 PM · Harbormaster, Feature Request
epriestley moved T6615: Worker task table has some remaining awkward keys from Availability to vNext on the Daemons board.
Feb 21 2017, 12:37 AM · Infrastructure, Daemons
epriestley closed T10756: Make daemons work correctly no matter where they are or how many copies are running, a subtask of T10751: Make Phabricator Highly Available, as Resolved.
Feb 21 2017, 12:35 AM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10756: Make daemons work correctly no matter where they are or how many copies are running as Resolved.

I believe this is effectively resolved now -- we're running all the daemons on multiple hosts on secure. There's remaining followup work (T6768, T6615, T10753, T10754) but I think the core is in reasonable shape.

Feb 21 2017, 12:35 AM · Restricted Project, Daemons
epriestley added a comment to T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish.

T11708 has almost nothing to do with this, but the fix for this will rewrite the code that's running into issues and probably moot them.

Feb 21 2017, 12:31 AM · Restricted Project, Daemons, Differential, Transactions
epriestley merged task T11708: Daemons erroneously saying "Diff does not exist" into T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish.
Feb 21 2017, 12:30 AM · Daemons, Differential, Bug Report
epriestley merged T11708: Daemons erroneously saying "Diff does not exist" into T12115: ApplicationTransactionPublishWorker can retry indefinitely, sending email as a side effect, if a transaction takes more than 2 hours to publish.
Feb 21 2017, 12:30 AM · Restricted Project, Daemons, Differential, Transactions
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

I'm just going to merge this into T12115, which isn't really related, but will rewrite this code and probably "fix" this, since a reproduction case seems elusive.

Feb 21 2017, 12:30 AM · Daemons, Differential, Bug Report
epriestley moved T5401: Record total time in queue for tasks from Backlog to vNext on the Daemons board.
Feb 21 2017, 12:27 AM · Daemons
epriestley closed T8809: Support more complex human-usable weekly clocks in trigger infrastructure as Wontfix.

This could probably be built with RRULEs now, but we don't currently have use cases / plans around a general-purpose cron-like tool.

Feb 21 2017, 12:27 AM · Daemons
epriestley closed T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue as Resolved.

Use cases seem to be fairly well covered now.

Feb 21 2017, 12:25 AM · Restricted Project, Daemons
epriestley closed T5334: View a graph showing worker load over time as Resolved.

This is 2+ years old and autoscaling probably covers it now. T5401 is probably a more tangible attack on this.

Feb 21 2017, 12:23 AM · Restricted Project, Daemons, Facts
epriestley closed T7484: Lock is not locked by this process as Wontfix.

This got a little more work when clustering was written but it's essentially a log of two-year-old ghost sightings at this point and not actionable.

Feb 21 2017, 12:21 AM · Restricted Project, Daemons
epriestley added a comment to T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015.

I guess this one can live for now since that's reproducible/actionable.

Feb 21 2017, 12:19 AM · Search, Daemons
epriestley renamed T8871: Indexing a task with 2,000 comments required a lot of RAM in mid-2015 from Phabricator daemons autoscale themselves to OOM to Indexing a task with 2,000 comments required a lot of RAM in mid-2015.
Feb 21 2017, 12:19 AM · Search, Daemons
epriestley closed T9603: PHD daemons regularly stopping/starting as Resolved.

Probably a dupe of T11708? I'm just going to kill this one since it's old as dirt.

Feb 21 2017, 12:16 AM · Daemons
epriestley closed T10148: diffusion.rawdiffquery can not encode/transport all diffs (e.g. to non-utf8 files) as Resolved.

I believe this was likely resolved by D16460. This (binary transport over Conduit) is still a problem in general, and T5955 is the general remedy, but diffusion.rawdiffquery specifically now returns data via Files.

Feb 21 2017, 12:15 AM · Conduit, Daemons
epriestley closed T9855: DifferentialChangesSinceLastUpdateField may fail policy checks and prevent mail from sending as Resolved.

I think it is likely that this was resolved by D17123. If it wasn't, we don't have a reproduction case anyway so we can't move forward. I'm going to call this one dead until more information turns up.

Feb 21 2017, 12:13 AM · Daemons, Differential
epriestley closed T10811: `phd-daemon` crash after automatic restart following config change as Resolved.

We were never able to reproduce this convincingly and as far as we know the reporting install no longer uses Phabricator, so I'm going to close this out.

Feb 21 2017, 12:12 AM · Daemons, Bug Report
epriestley closed T10811: `phd-daemon` crash after automatic restart following config change, a subtask of T10756: Make daemons work correctly no matter where they are or how many copies are running, as Resolved.
Feb 21 2017, 12:12 AM · Restricted Project, Daemons
epriestley moved T12298: Allow daemon pools to autoscale down to 0 processes from Backlog to vNext on the Daemons board.
Feb 21 2017, 12:10 AM · Daemons, Ops, Phacility
epriestley moved T10867: Version daemons more clearly in daemon console so it's clear when `phd reload` has taken effect from Backlog to vNext on the Daemons board.
Feb 21 2017, 12:10 AM · Daemons, Feature Request
epriestley moved T11037: `bin/phd status` is misleading about local / remote daemons from Backlog to vNext on the Daemons board.
Feb 21 2017, 12:10 AM · Daemons, Restricted Project
epriestley added a comment to T12298: Allow daemon pools to autoscale down to 0 processes.

I believe I have the first part of this (restructuring the code into a more sensible Overseer > Pool > Daemon sort of thing) working, but it could use more testing. I'm going to see if we have anything else in Daemons that I can fix while I'm here to help me kick the tires a bit.

Feb 21 2017, 12:09 AM · Daemons, Ops, Phacility

Feb 20 2017

epriestley updated the task description for T12298: Allow daemon pools to autoscale down to 0 processes.
Feb 20 2017, 9:42 PM · Daemons, Ops, Phacility
epriestley closed T12299: Linking Maniphest Tasks to external Bugtrackers as Invalid.

This request doesn't describe a root problem, just suggests we do about a thousand hours of work integrating with remote APIs. See Describing Root Problems.

Feb 20 2017, 5:16 PM · Feature Request
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Some possible approaches here:

Feb 20 2017, 4:34 PM · XHProf, Ops, Phacility
epriestley updated the task description for T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.
Feb 20 2017, 4:33 PM · XHProf, Ops, Phacility
epriestley created T12298: Allow daemon pools to autoscale down to 0 processes.
Feb 20 2017, 4:30 PM · Daemons, Ops, Phacility
epriestley created T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.
Feb 20 2017, 4:19 PM · XHProf, Ops, Phacility
epriestley added a subtask for T12101: Phabricator PHP 7 Compatibility: T9805: XHProf will not build on PHP7.
Feb 20 2017, 4:17 PM · Infrastructure, Guides
epriestley added a parent task for T9805: XHProf will not build on PHP7: T12101: Phabricator PHP 7 Compatibility.
Feb 20 2017, 4:16 PM · XHProf
epriestley moved T7954: Make it easier to upload XHProf profiles from Backlog to vNext on the XHProf board.
Feb 20 2017, 4:13 PM · Infrastructure, XHProf
epriestley added a parent task for T12217: Reduce the hardware cost of Phacility free instances: T12218: Reduce the operational cost of a larger Phacility cluster.
Feb 20 2017, 4:12 PM · Ops, Phacility
epriestley added a subtask for T12218: Reduce the operational cost of a larger Phacility cluster: T12217: Reduce the hardware cost of Phacility free instances.
Feb 20 2017, 4:12 PM · Ops, Phacility
epriestley added a comment to T12296: Improve Phacility repository import performance.

There's also a bunch of the usual free-tier shenanigans on this host -- free instances with 1 user importing multiple large repositories -- but that's to be expected.

Feb 20 2017, 4:10 PM · Customer Impact, Diffusion, Ops
epriestley created T12296: Improve Phacility repository import performance.
Feb 20 2017, 4:09 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12134: Develop a Nuance-based Phabricator reporting/support flow.

Here's an attempt to manually classify recent feature requests. I'm not sure how much value we're really getting out of this channel except from users who are already part of Community:

Feb 20 2017, 12:28 PM · Abuse
epriestley closed T12239: Search for deleted or renamed files in Diffusion as Invalid.

Unfortunately, we haven't received enough information on this to move forward. See Contributing Feature Requests and Contributing Bug Reports if you'd like to try filing a new request.

Feb 20 2017, 12:17 PM · Feature Request

Feb 19 2017

epriestley added a comment to T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.

The in-diff issue is described in T11482.

Feb 19 2017, 7:10 PM · Diffusion, Feature Request
epriestley added a comment to T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way.

I'm not sure I understand what changes you're suggesting.

Feb 19 2017, 6:43 PM · Diffusion, Feature Request
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

This is currently the scalability and stability bottleneck for deployments, but should be relatively easy to fix.

Feb 19 2017, 5:13 PM · Ops, Phacility
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

(For anyone following along, some additional discussion of clustershell in T2794.)

Feb 19 2017, 4:06 PM · Ops, Phacility
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 19 2017, 3:04 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 19 2017, 2:58 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 19 2017, 2:54 PM · Phage, Infrastructure
epriestley added a comment to T2794: Implement Phage (like Hypershell).

We'll open source everything that's general-purpose. (Currently, the only piece that's closed is the "plan" for Phacility deployments specifically. Since we don't have a generic "SSH" style plan as a starting point yet that plan is currently important, but we'll write generic plans or a general plan-executor or something eventually.)

Feb 19 2017, 12:37 PM · Phage, Infrastructure
epriestley merged T12276: Allow to configure arc commit message into T2920: Modularize the pipeline for producing final commit messages.
Feb 19 2017, 1:12 AM · Arcanist
epriestley merged task T12276: Allow to configure arc commit message into T2920: Modularize the pipeline for producing final commit messages.
Feb 19 2017, 1:12 AM · KDE, Feature Request

Feb 18 2017

epriestley added a comment to T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate.

I believe we only get it wrong in the very specific case where you're attending a "Busy" event and an "Away" event at the same time. We'll show the dot color for whichever event started first, so if the "Busy" event started before the "Away" event you get an orange dot instead of a red dot (if the "Away" event started first, we show a red dot, but that's the right color to show).

Feb 18 2017, 9:11 PM · Calendar, Bug Report
epriestley added a comment to T12278: Choose specific form on Create Subtask.

You should already be able to use custom forms to limit access to advanced fields by user, as we do on this install. If you (a user who is not a member of Community) try to create a new subtask here, I believe you will find that you can not access fields like "Assigned To" or "Priority". However, members of Community can.

Feb 18 2017, 1:51 PM · Maniphest, Feature Request
epriestley added a comment to T2794: Implement Phage (like Hypershell).

It looks like clustershell is doing something pretty similar to Hypershell/Phage in its "gateway" mode (but it looks like it can't bootstrap itself and doesn't have a web UI).

Feb 18 2017, 1:45 PM · Phage, Infrastructure
epriestley removed a watcher for Maniphest: • s935l4h.
Feb 18 2017, 2:57 AM
epriestley added a comment to T12277: Show the points of the sub and parent tasks in the Task Graph.

T12278 suggests that "sprint tasks" are being used in this workflow -- not milestones -- and "backlog tasks" are being used -- not columns. But this task also mentions columns and workboards. A more detailed description of your workflow would be helpful in understanding where the intended tools (milestones and columns) are falling short.

Feb 18 2017, 2:54 AM · Maniphest, Feature Request
epriestley added a comment to T12278: Choose specific form on Create Subtask.

Why do you create backlog tasks or sprint tasks instead of using Columns on Workboards or Milestones in Projects?

Feb 18 2017, 2:52 AM · Maniphest, Feature Request
epriestley triaged T12277: Show the points of the sub and parent tasks in the Task Graph as Wishlist priority.

I don't think this is necessarily unreasonable, but I'd like to see significantly more interest in it from other installs before we pursue it.

Feb 18 2017, 2:50 AM · Maniphest, Feature Request
epriestley closed T12222: Add custom fields to the "Task Action..." menu as Invalid.

Unfortunately, this doesn't seem to be moving toward an upstreamable feature request which completely describes a root problem. I'm not sure how we can make what we're asking for more clear. We've already spent a significant amount of time on this and need to move on to other things.

Feb 18 2017, 2:36 AM · Maniphest, Feature Request
epriestley closed T10794: Upgrading: Changes to Aphlict (Real-Time Notifications) Configuration as Resolved.

This has been live for a while now.

Feb 18 2017, 2:32 AM · Installing & Upgrading, Aphlict
epriestley closed T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext) as Resolved.

This has seemed stable for a while. We've fixed a few stemming issues and have T12137 and some other followups outstanding, but these generally are not issues that are fundamental to InnoDB Fulltext.

Feb 18 2017, 2:31 AM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley closed T12085: Upgrading: Changes to Differential Custom Fields in Commit Messages as Resolved.

I think we mostly managed to get installs through this.

Feb 18 2017, 2:30 AM · Installing & Upgrading, Differential
epriestley closed T8623: Upgrading: Differential Hunk Migration as Resolved.

This has now been live for a while without anyone hitting real issues other than the minor hiccup in T12090. T8475 is an eventual followup.

Feb 18 2017, 2:27 AM · Installing & Upgrading, Differential, Guides
epriestley closed T12202: Upgrade Guide: Home Menu Items as Resolved.

This has been live for a couple of weeks and I don't think we've seen too much confusion from users.

Feb 18 2017, 2:25 AM · Guides, Installing & Upgrading, Profile Menu Item
epriestley closed T12268: Make the grey "Unverified User" dot accurately reflect the new universal behavior as Resolved.

I think D17374 covered everything I wanted to cover.

Feb 18 2017, 2:18 AM · Mail, People
epriestley added a comment to T12280: mov and m4v videos don't play .

See also T12079 and T12219, although I'm not sure if either of those are duplicates of this.

Feb 18 2017, 2:15 AM · Bug Report
epriestley added projects to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?): Design, Internet Explorer.
Feb 18 2017, 2:14 AM · Internet Explorer, Design
epriestley added a comment to T12275: Allow to rename applications.

The point of my comment was that as someone familiar with KDE, which is broadly a project with a somewhat-similar application structure and somewhat-similar application names, you should reasonably be aware that what you are asking for is not likely to be trivial or straightforward.

Feb 18 2017, 2:03 AM · Feature Request
epriestley edited the content of Changelog.
Feb 18 2017, 1:42 AM
epriestley created 2017 Week 7 (Late February).
Feb 18 2017, 1:41 AM
epriestley added a comment to T12276: Allow to configure arc commit message.

See T10622.

Feb 18 2017, 1:15 AM · KDE, Feature Request
epriestley added a comment to T12275: Allow to rename applications.

I find it noteworthy that this request comes from KDE, a project which ships a large number of applications with nonliteral names featuring "K" wordplay ("Konversation" instead of "IRC Client", "Konqueror" instead of "Browser", "KCachegrind" instead of "Graphical Frontend for Cachegrind, a Cache Profiler that is part of Valgrind, a Profiler Suite With An Unfortunate Nonliteral Name", and so on).

Feb 18 2017, 12:54 AM · Feature Request
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

We're currently at ~82% cluster fullness which makes me slightly uncomfortable, but I'm not going to add more hardware quite yet since I think I can probably get "scale to 0" into production next week. If it's more involved than I think I'll likely put shards 017-020 into production in the next week or so.

Feb 18 2017, 12:42 AM · Ops, Phacility
epriestley added a comment to T12217: Reduce the hardware cost of Phacility free instances.

Can't the same tricks used to make a single web server handle multiple instances be used for the daemons?

Feb 18 2017, 12:35 AM · Ops, Phacility

Feb 17 2017

epriestley closed T12290: `arc diff` should copy the differential URL to clipboard as Invalid.

Yes, our expectation is that email solves the problem of notifying reviewers. If email isn't solving this problem, we'd prefer to try to fix that rather than add features to support a workflow where you manually copy-paste links into a Slack channel, since this is a fundamentally narrow, unscalable workflow and the feature isn't practical to implement in environments where arc is run on a remote host.

Feb 17 2017, 11:55 PM · Feature Request
epriestley added a revision to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?): Unknown Object (Differential Revision).
Feb 17 2017, 11:34 PM · Internet Explorer, Design
epriestley added a comment to T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?).

I'll just undo D17361 for now since the "MMMMMMMMMMMMMMMMM" thing is only a theoretical problem, and we can think about this more carefully outside of the context of a release cut.

Feb 17 2017, 11:30 PM · Internet Explorer, Design
epriestley added a revision to T12218: Reduce the operational cost of a larger Phacility cluster: Unknown Object (Differential Revision).
Feb 17 2017, 11:18 PM · Ops, Phacility
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 17 2017, 11:14 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 17 2017, 10:59 PM · Phage, Infrastructure
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 17 2017, 10:42 PM · Phage, Infrastructure
epriestley added a comment to T12290: `arc diff` should copy the differential URL to clipboard.

What are two other ways we could solve the problem you're running into?

Feb 17 2017, 10:40 PM · Feature Request
chad awarded T2794: Implement Phage (like Hypershell) a 100 token.
Feb 17 2017, 10:04 PM · Phage, Infrastructure
epriestley renamed T12289: When a user is attending multiple overlapping events, computation of availability state may not be accurate from calendar: away should be displayed first than busy to When a user is attending multiple overlapping events, computation of availability state may not be accurate.
Feb 17 2017, 9:08 PM · Calendar, Bug Report
epriestley added a comment to T2794: Implement Phage (like Hypershell).

This is still a shallow ghost of Hypershell, but I successfully deployed secure with it:

Feb 17 2017, 8:56 PM · Phage, Infrastructure
jcox awarded F905540: cat3.png a 100 token.
Feb 17 2017, 6:59 PM
jcox awarded F905540: cat3.png a Burninate token.
Feb 17 2017, 6:59 PM
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

As far as "opt-in", are you mostly concerned about performance?

Feb 17 2017, 6:14 PM · Owners, Audit, Restricted Project, Differential