Page MenuHomePhabricator

Auto add reviewers based on custom logic
Open, Needs TriagePublic

Description

We have a concept of OWNERS files. Depending on which directories are getting modified, the number of directories modified, and the config settings of the directory/repo we'd like to automatically some people as reviewers. This can't be easily expressed in Herald (and hurts usability since arc would prompt for "no reviewers"). Ideally we'd be able to write some custom Python code that returns a list of users to add to the 'reviewers' or 'subscribers' line.

In a somewhat more generic sense it would be nice if we can construct the entire template: some teams want special information in the summary section or have a special format for the title section.

Event Timeline

eadler created this task.Mar 18 2016, 4:46 PM
eadler added a project: Restricted Project.
eadler edited projects, added Restricted Project; removed Restricted Project.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

I think this is generally reasonable but would like it to happen after T10329 (roughly, "proper extension infrastructure for arc"), when we'll have the tools we need to better manage versioning and deploying client changes.

For reference, the Chromium project has a formal definition of their OWNERS files, including parsing code (in Python).

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 6 2016, 5:34 PM
eadler edited projects, added Restricted Project; removed Restricted Project.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:19 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
epriestley moved this task from Backlog to vMajor on the Arcanist board.Jul 21 2016, 11:45 AM