Page MenuHomePhabricator
Feed Advanced Search

Feb 26 2017

epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

@bcooksley, feel free to mention that you've talked with me about stuff when filing tasks in the future. Like 90% of what shows up here spontaneously is pretty questionable, so unannounced reports get fairly strict scrutiny.

Feb 26 2017, 11:00 PM · KDE, Differential, Bug Report
epriestley added a project to T12323: Revisions show in Other Revisions when acceptance status is unclear: KDE.

Here's the downstream task: https://phabricator.kde.org/T5406

Feb 26 2017, 10:58 PM · KDE, Differential, Bug Report
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Note that these steps depend on who is viewing the page (or, specifically, who "Responsible Users" are). More concise steps are likely:

Feb 26 2017, 10:58 PM · KDE, Differential, Bug Report
epriestley created T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit.
Feb 26 2017, 8:23 PM · Audit, KDE
epriestley added a comment to T10319: Generate unique? profile images for each new user.

It looks like we currently allow usernames to begin with _, ., and - (PhabricatorUser->validateUsername()), but maybe just do a ? for anything-except-numbers-and-letters?

Feb 26 2017, 6:51 PM · Feature Request, People
epriestley added a comment to T12321: Create Task form not Editable..

Have you tried using Lock/Hide Fields to hide the "Status" field?

Feb 26 2017, 6:33 PM · Bug Report
epriestley added a comment to T12321: Create Task form not Editable..

What's an example of a specific change you're trying to make which you aren't able to figure out how to make?

Feb 26 2017, 6:21 PM · Bug Report
epriestley added a comment to T10319: Generate unique? profile images for each new user.

We can draw letters in GD, but I suspect they won't look very good compared to letters from Photoshop (bad antialiasing, limited font choices, weird alignment/kerning issues), so I'd guess it's not worth bothering and we might as well just jump straight to using generated images like Projects.

Feb 26 2017, 5:58 PM · Feature Request, People
epriestley closed T12320: Create Task form not Editable. as Invalid.

You are running an out-of-date version of Phabricator, from February 17th.

Feb 26 2017, 5:16 PM · Bug Report
epriestley added a comment to T12320: Create Task form not Editable..

Please provide version information for your install. See Providing Version Information.

Feb 26 2017, 5:05 PM · Bug Report
epriestley updated subscribers of T12319: Investigate an Owners-related performance issue on revision detail pages.
Feb 26 2017, 3:29 PM · Owners, Differential, Performance
epriestley created T12319: Investigate an Owners-related performance issue on revision detail pages.
Feb 26 2017, 3:29 PM · Owners, Differential, Performance
epriestley added a comment to T12318: Loading Symbols in Phacility (Conduit).

I think this (and lint/coverage) should move to Conduit, yeah.

Feb 26 2017, 3:26 PM · Customer Impact, Symbols, Feature Request
gabe awarded T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads a Like token.
Feb 26 2017, 4:55 AM · Mercurial, Arcanist
epriestley added a comment to T12296: Improve Phacility repository import performance.

(That said, my expectation is that behaviors around unreachable commits have not changed -- D17279 added the "Unreachable" option to solve this problem.)

Feb 26 2017, 4:43 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

Likely somewhere in T9430 / T10978, which rewrote a big chunk of the audit code.

Feb 26 2017, 4:42 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

If you don't want to see unreachable commits, use a query which hides them:

Feb 26 2017, 4:32 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

It is expected that some deleted commits will import and others will not.

Feb 26 2017, 4:05 AM · Customer Impact, Diffusion, Ops
epriestley closed T12317: PhabricatorTriggerDaemon shows as "Waiting" but there are no errors as Resolved.

See T12298#213181.

Feb 26 2017, 4:01 AM · Bug Report
CodeMouse92 awarded T10350: Scripts to migrate old "points" fields and move projects beneath other projects a Mountain of Wealth token.
Feb 26 2017, 1:49 AM · Projects (v3)

Feb 25 2017

epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Total cost is about 1.6s. Of this:

Feb 25 2017, 4:09 PM · XHProf, Ops, Phacility
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

This is still a little bit of a pain but far more reasonable now, here's an actual profile:

Feb 25 2017, 4:03 PM · XHProf, Ops, Phacility
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I cycled the rest of the tier and things look better now.

Feb 25 2017, 4:00 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

After manually deploying that to repo001, I'm now seeing a consistent Taskmaster/PullLocal count. I'm redeploying the rest of the repo hosts.

Feb 25 2017, 3:05 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I think the issue is that the --reserve flag for reserving system memory now applies to even the first daemon in a pool, because all daemons are now part of pools. Previously, it only applied only to the 2nd..Nth daemon.

Feb 25 2017, 3:02 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Some taskmasters failed to start on repo001 and perhaps elsewhere.

Feb 25 2017, 2:46 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I suspended and destroyed the largest instance on the shard, a free instance with one user and no logins for >30 days (the user appears to have imported a huge repository and then never logged back in). We still have backups, but this instance was way over reasonable resource use anyway. The volume is now 78% full.

Feb 25 2017, 2:45 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I pruned some very old backups (backup pruning is currently very conservative in several cases). The volume is now 72% full. This could easily be reduced much further by allowing bin/host prune to remove backups older than 90 days for suspended/terminated instances that have been out of service for 90 days, but backup utilization is generally relatively stable so I'm not concerned about this.

Feb 25 2017, 2:26 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I synchronized services for this shard and destroyed old instances. The volume is now 68% full.

Feb 25 2017, 2:13 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I synchronized services for this shard and destroyed old instances. The volume is now 44% full.

Feb 25 2017, 1:44 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

This was a bunch of repository file data in /tmp. Each file was unique, so this doesn't look like any sort of buggy loop or anything. There's some actual bug here but since there's a long list of other issues here I just "fixed" this by clearing /tmp.

Feb 25 2017, 1:08 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Some reserved instances ended on Feb 19th; I should make sure reserved instances match production instances.

Feb 25 2017, 1:02 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Shards 017 through 020 are now in production.

Feb 25 2017, 12:57 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

The re-launched hosts seem OK, I'm waiting for DNS to update and then redeploying them.

Feb 25 2017, 12:10 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

The hosts launched into an "Auto-Assign Public IPv4" subnet but didn't get IPv4 addresses. Restarting them didn't help, and there's no apparent way to assign public addresses after the fact. I'm going to throw them away and try again.

Feb 25 2017, 12:06 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I'm going to put more hosts into production immediately before pursuing other issues.

Feb 25 2017, 11:59 AM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.
  • Some reserved instances ended on Feb 19th; I should make sure reserved instances match production instances.
Feb 25 2017, 11:29 AM · Phacility, Ops
epriestley edited the content of Phacility Cluster Devices.
Feb 25 2017, 11:21 AM
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.
  • The tier as a whole is 88% full.
Feb 25 2017, 11:12 AM · Phacility, Ops
epriestley added a parent task for T12316: Phacility Deploy Log 2017 Week 8: T12217: Reduce the hardware cost of Phacility free instances.
Feb 25 2017, 11:11 AM · Phacility, Ops
epriestley added a subtask for T12217: Reduce the hardware cost of Phacility free instances: T12316: Phacility Deploy Log 2017 Week 8.
Feb 25 2017, 11:11 AM · Ops, Phacility
epriestley created T12316: Phacility Deploy Log 2017 Week 8.
Feb 25 2017, 11:10 AM · Phacility, Ops
epriestley edited the content of Changelog.
Feb 25 2017, 2:18 AM
epriestley created 2017 Week 8 (Very Late February).
Feb 25 2017, 2:17 AM
epriestley updated subscribers of T12314: Support formal task subtypes (like "bug" vs "feature").

So here's a tentative plan for subtyping:

Feb 25 2017, 1:09 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Custom Forms are the general tool we want to use here, but they currently have some limitations for this use case. As a starting point, here's what they can do today, some of the strengths, and some of the weaknesses.

Feb 25 2017, 12:49 AM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12315: Arcanist setup documentation is circular.

Maybe the "Install Arcanist" header on Quick Start could be like:

Feb 25 2017, 12:29 AM · Bug Report
epriestley added a comment to T12315: Arcanist setup documentation is circular.

That is, this passage:

Feb 25 2017, 12:15 AM · Bug Report
epriestley added a comment to T12315: Arcanist setup documentation is circular.

There's a short version and a long version. Each version links to the other version, saying "here's a different version of these instructions, if you'd prefer that one". How could we make this more clear?

Feb 25 2017, 12:13 AM · Bug Report

Feb 24 2017

epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

This is a followup to a private discussion elsewhere, I'll flesh it out a bit when I have a chance.

Feb 24 2017, 10:20 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12298: Allow daemon pools to autoscale down to 0 processes.

Hibernating daemons currently show as "Waiting" in the Daemon console, but I'm not going to worry about that for now.

Feb 24 2017, 6:49 PM · Daemons, Ops, Phacility
epriestley added a comment to T12296: Improve Phacility repository import performance.

Ah, okay. This is the relevant part:

Feb 24 2017, 6:46 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to E1394: Dentist.

good luck w/ teeth 😁

Feb 24 2017, 6:07 PM
epriestley added a revision to T12296: Improve Phacility repository import performance: Unknown Object (Differential Revision).
Feb 24 2017, 6:05 PM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

Starting with repository update:

Feb 24 2017, 5:56 PM · Customer Impact, Diffusion, Ops
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Feb 24 2017, 5:14 PM · Daemons, Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Feb 24 2017, 5:06 PM · Daemons, Ops, Phacility
epriestley added a comment to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").

Broadly, there is nothing Phabricator could have done differently to anticipate or prevent this issue.

Feb 24 2017, 2:31 PM · Guides, Security
epriestley added a comment to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").

We could also provide some kind of bin/auth burn-everything-to-the-ground to automate these steps, but I worry that it would almost never be tested (I think it's very difficult to test comprehensively in an automated way) or run, and there's a good chance it might be forgotten about when authentication changes occur.

Feb 24 2017, 2:24 PM · Guides, Security
epriestley updated the task description for T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").
Feb 24 2017, 2:12 PM · Guides, Security
epriestley added a comment to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").

Ah, you're right. It looks like request data may also have leaked. I'll edit my earlier posts to reflect that. Briefly, the change is: passwords and VCS passwords are potentially at risk.

Feb 24 2017, 2:12 PM · Guides, Security
epriestley added a comment to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").
NOTE: If Aphlict is served from the same domain as Phabricator (e.g., just on a different port) with Cloudflare as an intermediary, none of the rest of this comment applies: browsers could have sent credentials with the request and Cloudflare could have cached them.
Feb 24 2017, 12:50 PM · Guides, Security
epriestley added a comment to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").

To cycle passwords, you can do this:

Feb 24 2017, 12:43 PM · Guides, Security
epriestley added a comment to T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").

Although this problem is severe, the absolute size of the leak appears to be small (my task title is hyperbolic). From the Cloudflare disclosure:

Feb 24 2017, 12:21 AM · Guides, Security
epriestley updated the task description for T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").
Feb 24 2017, 12:15 AM · Guides, Security
epriestley updated the task description for T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").
Feb 24 2017, 12:15 AM · Guides, Security
epriestley created T12313: Cloudflare leaked all HTTPS traffic on the internet into public caches ("Cloudbleed").
Feb 24 2017, 12:11 AM · Guides, Security

Feb 23 2017

epriestley awarded Bug Meister to recipient: nicolast.
Feb 23 2017, 11:38 PM
epriestley awarded Bug Meister to recipient: willplatts.
Feb 23 2017, 11:37 PM
epriestley added a comment to T12304: Herald fails to add auditors if the author is an auditor.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.

Feb 23 2017, 11:37 PM · Herald, Bug Report
epriestley added a comment to T12302: Herald adding different auditors but only the last one is kept.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable tomorrow, a little more than 24 hours from now. Let us know if you run into any issues.

Feb 23 2017, 11:36 PM · Herald, Bug Report
epriestley closed T12304: Herald fails to add auditors if the author is an auditor as Resolved by committing Restricted Diffusion Commit.
Feb 23 2017, 11:19 PM · Herald, Bug Report
epriestley closed T12302: Herald adding different auditors but only the last one is kept as Resolved by committing Restricted Diffusion Commit.
Feb 23 2017, 11:15 PM · Herald, Bug Report
epriestley added a revision to T12304: Herald fails to add auditors if the author is an auditor: Unknown Object (Differential Revision).
Feb 23 2017, 10:47 PM · Herald, Bug Report
epriestley added a revision to T12302: Herald adding different auditors but only the last one is kept: Unknown Object (Differential Revision).
Feb 23 2017, 10:44 PM · Herald, Bug Report
epriestley added a comment to T7954: Make it easier to upload XHProf profiles.

I didn't "ref" it here, but D17401 sort of technically did this. I'd like to clean it up a bit more before calling this resolved, though -- particularly, this is basically a secret that only I know about.

Feb 23 2017, 7:34 PM · Infrastructure, XHProf
epriestley added a comment to T12172: Better color scheme for diffs.

Also, above, I used the term "deuteranomaly" when I meant "deuteranopia". I mistakenly believed they were describing the same type of colorblindness, but they are two different types.

Feb 23 2017, 7:13 PM · Accessibility, Feature Request
epriestley added a comment to T12311: Allow users to choose both "Larger Fonts" and "High Contrast" at the same time.

Possibly this should really be three dimensions (Size, Contrast, Color Correction).

Feb 23 2017, 7:11 PM · Celerity, Accessibility
epriestley added a comment to T12172: Better color scheme for diffs.

See T12060#213081 some end notes and followups.

Feb 23 2017, 7:11 PM · Accessibility, Feature Request
epriestley added a comment to T12060: Colorblind accessibility for red/green highlighting in e-mails.

See some additional discussion in T12172. Briefly:

Feb 23 2017, 7:10 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley added a project to T12311: Allow users to choose both "Larger Fonts" and "High Contrast" at the same time: Celerity.
Feb 23 2017, 7:03 PM · Celerity, Accessibility
epriestley created T12311: Allow users to choose both "Larger Fonts" and "High Contrast" at the same time.
Feb 23 2017, 7:03 PM · Celerity, Accessibility
epriestley closed T12060: Colorblind accessibility for red/green highlighting in e-mails as Resolved by committing Restricted Diffusion Commit.
Feb 23 2017, 6:57 PM · Accessibility, Design, Feature Request, Restricted Project
epriestley closed T12172: Better color scheme for diffs as Resolved by committing Restricted Diffusion Commit.
Feb 23 2017, 6:57 PM · Accessibility, Feature Request
epriestley added a comment to T12157: Make it visibly clearer that a Phabricator user account has been disabled.

@chad did another pass on user hovercards and they should be even more clear now (this screenshot doesn't demonstrate it clearly, but we also greyscale the profile photo);

Feb 23 2017, 6:46 PM · Profile, Feature Request
epriestley added a comment to T12288: Phabricator OAuth 2.0 initiating SSO login from a Third Party website.

Why do you have multiple authentication providers?

Feb 23 2017, 6:43 PM · Auth, Feature Request
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: Unknown Object (Differential Revision).
Feb 23 2017, 6:41 PM · XHProf, Ops, Phacility
epriestley added a comment to T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts.

Yeah, I'm basically just keeping this open as a dumping ground for the moment and purely selfishly because my segfaults aren't resolved yet -- brew didn't have PHP 7.1.2 last I checked, although it seems like it now does. I've upgraded and I'll see if that improves things.

Feb 23 2017, 6:04 PM · Bug Report
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: Unknown Object (Differential Revision).
Feb 23 2017, 5:59 PM · XHProf, Ops, Phacility
epriestley added a revision to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile: Unknown Object (Differential Revision).
Feb 23 2017, 5:31 PM · XHProf, Ops, Phacility
epriestley edited projects for T12310: Phd out of memory error, added: Bug Report (Needs Information); removed Bug Report.

We need reproduction instructions which allow us to reproduce this issue in a clean environment. See Contributing Bug Reports and Providing Reproduction Steps.

Feb 23 2017, 3:56 PM · Bug Report (Needs Information)
epriestley closed T12307: Users unable to add new credit cards to Autopay? as Invalid.

This has been "resolved" by switching to bartering various sundry goods and foodstuffs instead of billing via credit card.

Feb 23 2017, 12:02 AM · Phortune, Phacility

Feb 22 2017

epriestley closed T12301: `Create Form` always leads to page creating forms for configuring forms as Resolved by committing Restricted Diffusion Commit.
Feb 22 2017, 11:00 PM · EditEngine, Bug Report
epriestley added a revision to T12301: `Create Form` always leads to page creating forms for configuring forms: Unknown Object (Differential Revision).
Feb 22 2017, 10:34 PM · EditEngine, Bug Report
epriestley closed T12306: Failing svn connection brings daemon down as Resolved by committing Restricted Diffusion Commit.
Feb 22 2017, 10:11 PM · Daemons, Bug Report
epriestley added a revision to T12306: Failing svn connection brings daemon down: Unknown Object (Differential Revision).
Feb 22 2017, 10:09 PM · Daemons, Bug Report
epriestley added a revision to T2794: Implement Phage (like Hypershell): Unknown Object (Differential Revision).
Feb 22 2017, 9:49 PM · Phage, Infrastructure
epriestley added a revision to T12218: Reduce the operational cost of a larger Phacility cluster: Unknown Object (Differential Revision).
Feb 22 2017, 9:49 PM · Ops, Phacility
epriestley added a comment to T12298: Allow daemon pools to autoscale down to 0 processes.

No time like the present.

Feb 22 2017, 9:14 PM · Daemons, Ops, Phacility
epriestley created T12307: Users unable to add new credit cards to Autopay?.
Feb 22 2017, 12:41 PM · Phortune, Phacility