Page MenuHomePhabricator

`arc diff` should copy the differential URL to clipboard
Closed, InvalidPublic


After using running arc diff, I need to take my mouse and right-click the differential URL to copy it, and then paste it in my chat window to send it to team members for review. Everyone in my team ends up doing this multiple times a day as we work on diffs.

Instead, it would be great if the differential URL was copied to the clipboard - that way I could paste + send the URL directly without have to reach for my mouse. It'd be a very nifty to have this feature!

I'd be happy to contribute code for this, if I had some pointers.

Event Timeline

What are two other ways we could solve the problem you're running into?

if only differential sent people reviews automatically.

Then you wouldn't have to paste it into a window!

Fair enough - my team is odd in that we get a deluge of emails for diffs we're CC'd on since we own a platform for other developers, so we end up communicating diffs about the platform itself via chat instead of email. We should probably fix our email filters instead.

Yes, our expectation is that email solves the problem of notifying reviewers. If email isn't solving this problem, we'd prefer to try to fix that rather than add features to support a workflow where you manually copy-paste links into a Slack channel, since this is a fundamentally narrow, unscalable workflow and the feature isn't practical to implement in environments where arc is run on a remote host.

See T920 (we could SMS reviewers instead), T11069 (we could post to the Slack channel directly), T5726 (you could write a more sophisticated channel filter with hooks), T10448 (we could improve mail filtering rules), etc. Beyond this future work, substantial tools already exist to manage notifications (Herald, Owners, Projects, API, tools within Differential, etc).

This request doesn't provide enough context for us to find the best solution we can to your problem, or to suggest alternative approaches or workarounds, or anything else. (See also Describing Root Problems.) We will essentially never implement a feature without fully understanding the problem it's solving and the context the feature exists in.

Feel free to file a new task if new problems crop up after looking at how email is currently failing, but please provide us with as much context about the problem you're facing as possible. Generally, you should be able to suggest at least three different ways we could implement to solve your problem, as I have above. If you can't, your problem description is likely too narrow to provide us with enough context.

Very narrowly, note that --browse will open the revision in your browser, and +L will generally select the address bar, so you could arc diff --browse, +L, +C, +V to avoid using your mouse.