Page MenuHomePhabricator
Feed Advanced Search

Mar 27 2016

epriestley updated subscribers of T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
Mar 27 2016, 5:01 PM · Audit, Diffusion, Wikimedia
epriestley merged task T10680: If Audit app is uninstalled, you can still add comments to a commit and "raise concern" but it fails with 404 into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
Mar 27 2016, 5:01 PM · Bug Report
epriestley created T10679: When phurl.short-uri is configured, use it in the UI.
Mar 27 2016, 4:55 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley closed T9745: Configure phurl.io against secure.phabricator.com, a subtask of T6049: Implement Phurl, a URL shortener/bookmarking application, as Resolved.
Mar 27 2016, 4:52 PM · Phurl
epriestley closed T9745: Configure phurl.io against secure.phabricator.com as Resolved.

This is now fully configured.

Mar 27 2016, 4:52 PM · Ops, Phurl
epriestley created T10678: Consider roadblocking redirects from Phurl in some cases.
Mar 27 2016, 4:24 PM · Phurl
epriestley closed T9744: Harden Phurl against anchor reattachment as Wontfix.

I ultimately don't think there's any really reasonable way we can fix this that doesn't have a cost and complexity far greater than the benefit.

Mar 27 2016, 4:16 PM · Security, Phurl
epriestley closed T9744: Harden Phurl against anchor reattachment, a subtask of T6049: Implement Phurl, a URL shortener/bookmarking application, as Wontfix.
Mar 27 2016, 4:16 PM · Phurl

Mar 26 2016

epriestley closed T10114: Upgrading: Amazon S3 Configuration Changes as Resolved.

This has been live for some time without any apparent issues.

Mar 26 2016, 9:02 PM · Installing & Upgrading, Files
epriestley closed T10199: NSS on Red Hat derivative OSes does not support ECC cipher-suites and can not connect to CloudFlare HTTPS as Wontfix.

We haven't seen further reports of this in more than two months, so I don't plan to mitigate it at the application level.

Mar 26 2016, 7:44 PM · Infrastructure
epriestley closed T10239: Ability to pass more info to custom linters as Resolved.

Presuming resolved by getPathChangedLines($path) + -lines.

Mar 26 2016, 7:36 PM · Feature Request
epriestley closed T10240: Copy Comment as Invalid.

This request doesn't describe a root problem, so we can't develop a solution to it. We haven't received any new information in more than a month. See Describing Root Problems and Contributing Feature Requests for help describing root problems and filing feature requests that the usptream can accept.

Mar 26 2016, 7:32 PM · Feature Request (Needs Information)
epriestley closed T10302: Workflow.js is picking up 7px from somewhere as Resolved by committing Restricted Diffusion Commit.
Mar 26 2016, 7:29 PM · PHUI, Bug Report
epriestley closed T10296: SSLRead() return error -9806 on git clone as Invalid.

We can't reproduce this and we haven't learned any new information in more than a month, so I'm going to close it.

Mar 26 2016, 7:29 PM · Bug Report (Needs Information), Diffusion
epriestley added a revision to T10302: Workflow.js is picking up 7px from somewhere: Unknown Object (Differential Revision).
Mar 26 2016, 7:26 PM · PHUI, Bug Report
epriestley closed T10356: Unhandled Exception ("FilesystemException") after adding Github repo as Invalid.

This report does not include reproduction steps. Bug reports must include complete, self-contained reproduction steps to be accepted by the upstream. See Providing Reproduction Steps for help.

Mar 26 2016, 7:15 PM · Diffusion, Bug Report
epriestley updated subscribers of T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.
Mar 26 2016, 7:12 PM · Inline Comments, Differential, Restricted Project
epriestley merged task T8610: No threaded comments --hard to follow in line comments when two bugs exist on one line into T10563: Inline comments displayed on the same line are shown in creation order without regard for threading.
Mar 26 2016, 7:12 PM · Restricted Project
epriestley closed T8610: No threaded comments --hard to follow in line comments when two bugs exist on one line as Wontfix.

I'm going to merge this into T10563 which is narrower but more actionable.

Mar 26 2016, 7:12 PM · Restricted Project
epriestley closed T10365: Support passing generated annotation to ArcanistGeneratedLinter as Invalid.

We don't have enough information about this problem to design a solution, and haven't received more information in more than a month. See Describing Root Problems and Contributing Feature Requests for details on how to submit an actionable feature request.

Mar 26 2016, 7:08 PM · Feature Request (Needs Information), Lint
epriestley closed T10385: Diffusion code view doesn't hide blame pane as Resolved by committing Restricted Diffusion Commit.
Mar 26 2016, 7:06 PM · Diffusion (v3), Mobile
epriestley claimed T10385: Diffusion code view doesn't hide blame pane.
Mar 26 2016, 6:58 PM · Diffusion (v3), Mobile
epriestley added a revision to T10385: Diffusion code view doesn't hide blame pane: Unknown Object (Differential Revision).
Mar 26 2016, 6:58 PM · Diffusion (v3), Mobile
epriestley edited the content of Changelog.
Mar 26 2016, 1:49 PM
epriestley created 2016 Week 13 (Very Late March).
Mar 26 2016, 1:48 PM

Mar 25 2016

epriestley closed T10674: Latest HEAD broke viewing unit test results in Harbormaster as Resolved by committing Restricted Diffusion Commit.
Mar 25 2016, 10:49 PM · Harbormaster, Bug Report
epriestley added a revision to T10674: Latest HEAD broke viewing unit test results in Harbormaster: Unknown Object (Differential Revision).
Mar 25 2016, 10:46 PM · Harbormaster, Bug Report
cwre awarded T10584: Allow users to amend revisions they don't own, without commandeering them a Like token.
Mar 25 2016, 8:11 PM · Differential
epriestley renamed T9819: Allow Phurl URLs to reference objects from Allow multiple aliases to a Phurl URL to Allow Phurl URLs to reference objects.
Mar 25 2016, 8:06 PM · Restricted Project, Phurl
epriestley created T10673: Convert Phurl to use EditEngine.
Mar 25 2016, 7:36 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley claimed T9744: Harden Phurl against anchor reattachment.
Mar 25 2016, 7:33 PM · Security, Phurl
epriestley moved T9745: Configure phurl.io against secure.phabricator.com from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Ops, Phurl
epriestley moved T6049: Implement Phurl, a URL shortener/bookmarking application from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Phurl
epriestley moved T9744: Harden Phurl against anchor reattachment from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Security, Phurl
epriestley moved T9819: Allow Phurl URLs to reference objects from Backlog to Unprotoytpe on the Phurl board.
Mar 25 2016, 7:33 PM · Restricted Project, Phurl
chad awarded T10672: Complete EditEngine implementation in Badges a Orange Medal token.
Mar 25 2016, 7:21 PM · Badges (v0)
epriestley created T10672: Complete EditEngine implementation in Badges.
Mar 25 2016, 7:18 PM · Badges (v0)
epriestley created T10671: Implement `badges.search` and `badges.edit` Conduit API methods.
Mar 25 2016, 7:15 PM · Restricted Project, Conduit, Badges (v0)
epriestley moved T9007: Allow Badges to be ordered by quality from Backlog to v0 on the Badges board.
Mar 25 2016, 7:10 PM · Badges (v0)
epriestley moved T10670: When a user has been awarded badges but all their badges are archived, their profile shows an empty panel from Backlog to v0 on the Badges board.
Mar 25 2016, 7:10 PM · Badges (v0)
epriestley reassigned T8941: Badges don't show in certain Timeline conditions from chad to lpriestley.

Take a look at this and see how far you can get? It might be really easy but it might also be very involved.

Mar 25 2016, 7:09 PM · Badges (v0)
epriestley assigned T9007: Allow Badges to be ordered by quality to lpriestley.

It's currently impossible to sort badges by rarity because they rarities are internally 'grey', 'white', 'green', etc., and there is no natural order to these. For example, MySQL has no idea what order 'indigo', 'orange' and 'yellow' should go in, except alphabetical, which is not actually the correct order.

Mar 25 2016, 7:03 PM · Badges (v0)
epriestley created T10670: When a user has been awarded badges but all their badges are archived, their profile shows an empty panel.
Mar 25 2016, 5:37 PM · Badges (v0)
• bitglue awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Mar 25 2016, 5:34 PM · Restricted Project, Harbormaster
epriestley renamed T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) from Unable to edit/delete inline comments in Pholio to Inline comments do not support editing (Pholio, Differential, Diffusion).
Mar 25 2016, 5:30 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley updated subscribers of T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).
Mar 25 2016, 5:29 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley merged task T10669: Can't edit inline comments on diff into T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).
Mar 25 2016, 5:29 PM · Feature Request
epriestley created T10668: When replying to a ghost inline comment, it is possible for the reticle to cover the reply UI.
Mar 25 2016, 5:12 PM · Inline Comments, Restricted Project, Differential
epriestley moved T10667: Improve ambiguity when resolving commits that appear in multiple repositories from Backlog to v3 on the Diffusion board.
Mar 25 2016, 2:45 PM · Diffusion (v3)
epriestley added a project to T10667: Improve ambiguity when resolving commits that appear in multiple repositories: Remarkup.
Mar 25 2016, 2:44 PM · Diffusion (v3)
epriestley closed T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException as Resolved.

Sounds good, let us know if you run into anything else.

Mar 25 2016, 2:43 PM · Passphrase, Bug Report
epriestley created T10667: Improve ambiguity when resolving commits that appear in multiple repositories.
Mar 25 2016, 2:42 PM · Diffusion (v3)
epriestley added a comment to T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.

For completeness, T10651 is the earlier report.

Mar 25 2016, 2:36 PM · Passphrase, Bug Report
epriestley added a comment to T10665: Incorrect divergent heads message on mercurial push.

I think this should now be resolved in HEAD of master. It will likely promote to stable in about 24 hours.

Mar 25 2016, 2:35 PM · Bug Report
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Mar 25 2016, 2:34 PM
epriestley closed T10665: Incorrect divergent heads message on mercurial push as Resolved by committing Restricted Diffusion Commit.
Mar 25 2016, 2:34 PM · Bug Report
epriestley added a comment to T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.

I think that stuff isn't linking because someone is pushing their own branches to the upstream staging repository, making the commits ambiguous. That is, e3f89279f912 is ambiguous as either rPe3f89279f912 or rSTAGINGe3f89279f912.

Mar 25 2016, 2:32 PM · Passphrase, Bug Report
epriestley added a revision to T10665: Incorrect divergent heads message on mercurial push: Unknown Object (Differential Revision).
Mar 25 2016, 2:26 PM · Bug Report
epriestley added a comment to T10665: Incorrect divergent heads message on mercurial push.

Ah, thanks! To hit this, I think we need to push a mixture of changes:

Mar 25 2016, 2:22 PM · Bug Report
epriestley closed Q350: Is it possible to disable the automatic hiding of older changes ? as resolved.
Mar 25 2016, 1:53 PM
epriestley added Q350: Is it possible to disable the automatic hiding of older changes ? (Answer 350).
Mar 25 2016, 1:53 PM
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 25 2016, 1:51 PM · Nuance (v1)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 25 2016, 12:30 PM · Nuance (v1)
epriestley added a comment to T10665: Incorrect divergent heads message on mercurial push.

The only way I can see to get to an error state is if both branches had the same head before the push? I'm not sure how to build that state, although maybe I'm just missing some subtlety of hg branch or some sequence of merge/close operations which can force it.

Mar 25 2016, 12:03 PM · Bug Report
epriestley added a comment to T10665: Incorrect divergent heads message on mercurial push.

Using mercurial push a set of commits that updates multiple branches at the same time

Mar 25 2016, 11:56 AM · Bug Report

Mar 24 2016

epriestley updated subscribers of T9492: Make WorkingCopy resources more powerful and flexible.
Mar 24 2016, 10:08 PM · Restricted Project, Drydock
epriestley merged task T10664: Can an alternate drydock (something other than /var/drydock) area be configuable for drydock working copies/builds? into T9492: Make WorkingCopy resources more powerful and flexible.
Mar 24 2016, 10:08 PM · Drydock, Feature Request
epriestley closed T10662: Cycle redirect at first connection as Invalid.

This report does not include valid reproduction instructions. These instructions are required; see Providing Reproduction Steps for help.

Mar 24 2016, 4:17 PM · Bug Report
epriestley changed the name of U21 Providing Version Information from to Providing Version Information.
Mar 24 2016, 4:04 PM
epriestley changed the name of U20 Providing Reproduction Steps from to Providing Reproduction Steps.
Mar 24 2016, 4:04 PM
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 24 2016, 1:28 PM · Nuance, GitHub
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 24 2016, 1:03 PM · Nuance, GitHub
epriestley added a comment to T10661: Can't create milestone.

I can't reproduce this. Here's what I did:

Mar 24 2016, 11:45 AM · Projects (v3), Bug Report
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

c( ⁰ 〰 ⁰ )੭

Mar 24 2016, 4:31 AM · Phacility, Ops
epriestley added a comment to T10655: Phacility cluster mail deliverability issue .

I requested SES limits of about 2X what we currently need and AWS gave us about 10X, so things look good so far on that front.

Mar 24 2016, 3:13 AM · Ops, Phacility
epriestley added a comment to T9745: Configure phurl.io against secure.phabricator.com.

I did a chunk of this work as part of T10629 and we're in better shape on accepting SSL-terminated traffic now.

Mar 24 2016, 3:11 AM · Ops, Phurl
epriestley closed T10629: Rotate the `secure.phabricator.com` SSL certificate as Resolved.

I've probably updated the notification server certificate, too?

Mar 24 2016, 3:11 AM · Phacility, Ops
epriestley renamed T10620: Support complex mappings from branch names to JIRA/Maniphest tasks from Detect Jira tasks from branch name to Support complex mappings from branch names to JIRA/Maniphest tasks.
Mar 24 2016, 3:02 AM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.

T10659 discusses another complex custom rule for mapping branch names to tasks in an unusual way.

Mar 24 2016, 2:59 AM · Restricted Project, Arcanist, Feature Request
epriestley merged task T10659: Allow tasks to be auto-attached to diff review where task reference is after a prefix with format "feature/T2-featureName" into T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.
Mar 24 2016, 2:59 AM · Feature Request
epriestley updated subscribers of T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.
Mar 24 2016, 2:59 AM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

CDN stuff is maybe-sorted.

Mar 24 2016, 2:58 AM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

Something on the CDN side has grown deeply unhappy, looking into it.

Mar 24 2016, 2:44 AM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

Seems OK. Swapping DNS shortly.

Mar 24 2016, 2:36 AM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

This appears to have deployed cleanly. I'm going to test notifications and SSH, and then I'll rebind DNS if they look good.

Mar 24 2016, 2:34 AM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

I'm going to deploy this host with rSERVICES + cluster awareness so it can accept SSL-terminated traffic. If I got something wrong, we may be down for a few minutes.

Mar 24 2016, 2:19 AM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

This is a little bit tricky because notifications use the same hostname, we don't have a wildcard certificate, and we can't (apparently) terminate SSL on the load balancer and pass it through with websockets.

Mar 24 2016, 2:16 AM · Phacility, Ops

Mar 23 2016

epriestley updated the task description for T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Mar 23 2016, 10:29 PM · Remarkup
epriestley added a comment to T10655: Phacility cluster mail deliverability issue .

The upstream provider gave me a not-quite-English canned response:

Mar 23 2016, 10:23 PM · Ops, Phacility
epriestley lowered the priority of T10655: Phacility cluster mail deliverability issue from Unbreak Now! to Normal.
Mar 23 2016, 10:20 PM · Ops, Phacility
epriestley created T10656: Modernize global search SearchEngine implementation.
Mar 23 2016, 8:14 PM · Search
epriestley added a comment to T10655: Phacility cluster mail deliverability issue .

I've issued all instances a 24-hour credit for the service disruption. This will be reflected on the next invoice you receive.

Mar 23 2016, 7:54 PM · Ops, Phacility
epriestley updated subscribers of T10655: Phacility cluster mail deliverability issue .
Mar 23 2016, 7:53 PM · Ops, Phacility
epriestley added a comment to T10655: Phacility cluster mail deliverability issue .

Our original upstream provider enabled the account again, also without explanation. Outbound queues are flushing now, but will take some time to completely de-queue because of backoff behavior in the queue.

Mar 23 2016, 7:47 PM · Ops, Phacility
epriestley added projects to T10655: Phacility cluster mail deliverability issue : Phacility, Ops.
Mar 23 2016, 7:41 PM · Ops, Phacility
epriestley added a revision to T10655: Phacility cluster mail deliverability issue : Unknown Object (Differential Revision).
Mar 23 2016, 7:41 PM · Ops, Phacility
epriestley created T10655: Phacility cluster mail deliverability issue .
Mar 23 2016, 7:40 PM · Ops, Phacility
epriestley closed T5116: Amazon SES mailer does not allow specifying endpoint as Resolved by committing Restricted Diffusion Commit.
Mar 23 2016, 7:29 PM · Mail
epriestley added a revision to T5116: Amazon SES mailer does not allow specifying endpoint: Restricted Differential Revision.
Mar 23 2016, 7:22 PM · Mail
epriestley added a comment to T10635: Loading differential revision slow when lots of unit test messages exist.

T9704 also discusses slowness on inserting the tests. That may be unnecessarily slow right now, but I don't expect clients to submit unlimited numbers of tests in one API call. Instead, submit tests in chunks (say, of 1K tests per page or whatever) by calling harbormaster.sendmessage repeatedly with a work status.

Mar 23 2016, 5:58 PM · Restricted Project, Haskell.org, Harbormaster, Performance