Maniphest T10385

Diffusion code view doesn't hide blame pane
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	avivey
	Feb 19 2016, 4:06 AM

Tags

Referenced Files

	F1119325: tumblr_nnhhzusKSV1uu9z7xo1_400.gif
	Feb 19 2016, 5:42 AM

	F1119272: Screenshot_20160218-195635.png
	Feb 19 2016, 4:06 AM

Subscribers

Description

When reading source file in diffusion, and disabling blame, the blame pane remains on screen.

Screenshot_20160218-195635.png (1×1 px, 211 KB)

Revisions and Commits

rP Phabricator
	D15528	rP060f96079def Fix Diffusion blame columns when disabling blame

Event Timeline

avivey created this task.Feb 19 2016, 4:06 AM

It also doesn't go away on desktop, I just never tried before (Latest Chrome, android and windows).

tumblr_nnhhzusKSV1uu9z7xo1_400.gif (225×400 px, 485 KB)

epriestley added a project: Diffusion (v3).Feb 19 2016, 1:09 PM

I spent like 20 minutes on this in the redesign and couldn't figure it out.

epriestley added a revision: D15528: Fix Diffusion blame columns when disabling blame.Mar 26 2016, 6:58 PM

epriestley claimed this task.Mar 26 2016, 6:58 PM

epriestley triaged this task as Normal priority.

epriestley closed this task as Resolved by committing rP060f96079def: Fix Diffusion blame columns when disabling blame.Mar 26 2016, 7:06 PM

epriestley added a commit: rP060f96079def: Fix Diffusion blame columns when disabling blame.