Latest HEAD broke viewing unit test results in Harbormaster
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	thoughtpolice
	Mar 25 2016, 10:27 PM

Description

Problem: When I go to a Harbormaster build and view the unit test results that were submitted for that build, and click on an entry so I can view the full output for the particular test, I get a stack trace.

Expected result: Seeing the output from my glorious test case.

Trace:

2016/03/25 17:20:01 [error] 18567#18567: *2915 FastCGI sent in stderr: "PHP message: [2016-03-25 17:20:01] EXCEPTION: (InvalidArgumentException) Argument 1 passed to PHUIObjectBoxView::addPropertyList() must be an instance of PHUIPropertyListView, instance of PHUIObjectBoxView given, called in /opt/p/phabricator/src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php on line 45 and defined at [<phutil>/src/error/PhutilErrorHandler.php:200]
PHP message: arcanist(head=master, ref.master=3d7ac867f538), phabricator(head=master, ref.master=d76652b33178), phutil(head=master, ref.master=b4f38af38480)
PHP message:   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/view/phui/PHUIObjectBoxView.php:43]
PHP message:   #1 <#2> PHUIObjectBoxView::addPropertyList(PHUIObjectBoxView) called at [<phabricator>/src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php:45]
PHP message:   #2 <#2> HarbormasterUnitMessageViewController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:237]
PHP message:   #3 phlog(InvalidArgumentException) called at [<phabricator>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:32]
PHP message:   #4 PhabricatorDefaultRequestExceptionHandler::handleRequestException(AphrontRequest, InvalidArgumentException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:632]
PHP message:   #5 AphrontApplicationConfiguration::handleException(InvalidArgumentException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:242]
PHP message:   #6 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:149]
PHP message:   #7 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabric

Note: the log seemed to truncate the trace for some reason, I'm not sure why, but this should be OK I hope.

Versions: From Config → Versions

phabricator d76652b3317874403a09ed2ec3b7f1d46ead5848 (Fri, Mar 25)
arcanist    3d7ac867f53892b8210339bbb0c5fd91e0e36d78 (Mon, Mar 14)
phutil      b4f38af384807b7dcd1e3d1a96e9e9069e4d6964 (Fri, Mar 18)

Suspected culprit: I just updated and looked at the commit log, and I suspect d76652b3317874403a09ed2ec3b7f1d46ead5848 is the culprit, as it changed the argument of addPropertyList to use the result of buildCurtainView instead of buildActionView, giving some incorrectly typed argument.