Page MenuHomePhabricator
Create Task
Maniphest T10302

Workflow.js is picking up 7px from somewhere
Closed, ResolvedPublic3.1415 Quest Points
Actions

Description

Inspecting the form width, jx-client-dialog is getting left: 7px for some reason, causing the dialogs to be slightly off center, but not very noticable except on phone layouts.

Screen Shot 2016-02-08 at 8.07.42 PM.png (1×796 px, 187 KB)

Revisions and Commits

rP Phabricator
D15529rPc286d2b441bd Don't try to center dialogs horizontally

Event Timeline

chad created this task.Feb 9 2016, 4:11 AM
chad changed the point value for this task from 12 to 12.
chad added a subscriber: epriestley.

(Also I assigned this some quest points, but I guess those don't generate transactions yet).

chad added a comment.Feb 9 2016, 4:46 AM

Actually on a real phone it's fine. I guess just something else is causing it at small breakpoints.

epriestley added a comment.Feb 9 2016, 8:54 PM

Is this REALLY worth 12 quest points!?

chad changed the point value for this task from 12 to 4.Feb 9 2016, 8:54 PM
epriestley added a comment.Feb 9 2016, 8:58 PM

I mean, far be it from me to declare myself Lord King Questmaster of the Realm, that just seems like a lot and/or not a lot of valuable and desirable Quest Points for this particular task.

chad added a comment.Feb 9 2016, 9:03 PM

Did I miss the Dungeon Master rulebook for quest value assignment?

chad changed the point value for this task from 4 to 3.1415.Feb 9 2016, 11:58 PM
• Persona added a commit: rP2eab1c1943c5: (stable) Promote 2015 Week 32.Feb 24 2016, 11:25 AM
tycho.tatitscheff removed a commit: rP2eab1c1943c5: (stable) Promote 2015 Week 32.Feb 24 2016, 12:25 PM
epriestley added a revision: D15529: Don't try to center dialogs horizontally.Mar 26 2016, 7:26 PM
epriestley closed this task as Resolved by committing rPc286d2b441bd: Don't try to center dialogs horizontally.Mar 26 2016, 7:29 PM
epriestley added a commit: rPc286d2b441bd: Don't try to center dialogs horizontally.
Phabricator · Built by Phacility