Page MenuHomePhabricator
Create Task
Maniphest T10667

Improve ambiguity when resolving commits that appear in multiple repositories
Open, LowPublic
Actions

Description

Currently, phabricator/ commit hashes on this install do not resolve correctly in Remarkup. That is, if you type 3493d9d5138e, it doesn't link.

This is because the hash is ambiguous: it exists in both rP and rSTAGING, so the hash could mean either rP3493d9d5138e or rSTAGING3493d9d5138e.

Previously, this hasn't mattered because we didn't discover commits in rSTAGING, since they were not reachable from any branch head. However:

  • @diamondman has pushed some personal branch to rSTAGING (rSTAGING42c977a2bbab, circleci_official_with_branchvar), making all prior commits discoverable.
  • The fact that commits reachable from tags aren't discovered is a bug in the first place (T6878).

This may be made obsolete by T8092, but if it isn't (or until then) it would be nice to possibly mark a repository to be ignored when disambiguating commits, so that hashes ignore it if there were un-marked repositories available during hash resolution.

Related Objects

Event Timeline

epriestley created this task.Mar 25 2016, 2:42 PM
epriestley mentioned this in T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.
epriestley added a project: Remarkup.
Herald added a subscriber: eadler. · View Herald TranscriptMar 25 2016, 2:44 PM
epriestley moved this task from Backlog to v3 on the Diffusion board.Mar 25 2016, 2:45 PM
epriestley edited projects, added Diffusion (v3); removed Diffusion.
cburroughs added a subscriber: cburroughs.Mar 25 2016, 4:31 PM
• paladox added a subscriber: • paladox.Mar 28 2016, 3:26 PM
epriestley mentioned this in T10807: CI setup blocked by commit import bug?.Apr 14 2016, 3:10 PM
epriestley mentioned this in T6878: Tagged commits which are not ancestors of any branch head don't get imported.Jun 16 2016, 5:33 PM
20after4 added a subscriber: 20after4.Dec 22 2017, 1:17 PM

Another approach that might make sense would be to highlight the hash and then show a hovercard which lists the commits with that hash. Of course this wouldn't scale too far but it should handle the case where 2 or 3 commits have the same hash.

epriestley added a comment.Dec 22 2017, 3:01 PM

With T13001, the commit page itself now gives you disambiguation options if the commits are in the same repository. This is a narrower case than ambiguous commits across multiple repositories, but related if we did pursue something like hovercards or a multi-repository disambiguation page.

kuba-orlik added a subscriber: kuba-orlik.Jan 2 2019, 10:17 AM
epriestley removed a project: Remarkup.May 23 2019, 2:48 PM
Herald added a subscriber: amckinley. · View Herald TranscriptMay 23 2019, 2:48 PM
Phabricator · Built by Phacility