Page MenuHomePhabricator

bitglue (Phil Frost)
UserEmail Not Verified

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 8 2013, 3:26 PM (364 w, 5 d)
Availability
Available

Recent Activity

Sep 28 2016

bitglue added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm a little confused about how these tags are appearing so widely in developer working copies in the first place. Is git clone fetching them by default? Do you have unusual default options configured? Do users regularly explicitly fetch all tags present in the remote?

That is, my expectation is that git pull does not "bring everything back".

Sep 28 2016, 2:59 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Apr 1 2016

bitglue added a comment to T8238: Formally support side-band change handoff in external repositories.

In this specific case (staging same as origin) we could just not push the base tag (it has no value in this case). We can probably even figure that out automatically without needing configuration. That would be a cleaner fix, I think?

Apr 1 2016, 1:13 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Mar 31 2016

bitglue added a comment to T8238: Formally support side-band change handoff in external repositories.

I've been using this functionality for some days to use the CircleCI integration. Mostly the user experience is fine. It's mostly possible to configure git log to ignore these tags, like:

Mar 31 2016, 5:23 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Mar 25 2016

bitglue awarded rPf82db7524b32: Add a "Build with CircleCI" build step a Mountain of Wealth token.
Mar 25 2016, 5:55 PM
bitglue awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Mar 25 2016, 5:34 PM · Restricted Project, Harbormaster
bitglue added a comment to T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.

Latest version seems to have fixed this. Sorry for the noise, and thanks for building such an awesome software.

Mar 25 2016, 2:41 PM · Passphrase, Bug Report
bitglue added a comment to T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.

Doh. Give me a minute, testing with 3493d9d5138e0a630624bced548090163ce9be8a now.

Mar 25 2016, 2:27 PM · Passphrase, Bug Report
bitglue created T10666: Unable to add API token credential for CircleCI: PhabricatorDataNotAttachedException.
Mar 25 2016, 2:16 PM · Passphrase, Bug Report

Feb 8 2016

bitglue added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

That's a good point, and certainly makes me feel less bad about putting IAM user credentials in a file on the host.

Feb 8 2016, 2:18 PM · Files
bitglue added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

I think you missed the point. The attacker in this instance is an employee, or a contractor, or an ex-employee. If you have static credentials sitting in files on your servers, all your ex-employees probably have them, too. And they can use them until you rotate them, which is pretty much never, in practice.

Feb 8 2016, 2:18 AM · Files

Jan 11 2016

bitglue accepted rPHUd6744fb71561: Implement `bin/aws-s3 get ...` and a basic S3 client API.

OK, fair enough. Thank you for clarifying.

Jan 11 2016, 5:04 PM
bitglue added a comment to rPHUd6744fb71561: Implement `bin/aws-s3 get ...` and a basic S3 client API.

I'm confused. If by "live" credentials you mean credentials that exist in some AWS account and grant some level of access to S3, I'm not sure what other kind of credentials I'd ever use.

Jan 11 2016, 4:44 PM
bitglue raised a concern with rPHUd6744fb71561: Implement `bin/aws-s3 get ...` and a basic S3 client API.
Jan 11 2016, 4:14 PM
bitglue added a comment to T5155: Evaluate support for AWS IAM Roles in S3 Client.

For me, the big advantage to using IAM roles is that the credentials rotate automatically, every hour.

Jan 11 2016, 4:05 PM · Files

Mar 10 2015

bitglue added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

I think the real problem is right here:

Mar 10 2015, 10:55 PM · Design, Differential

Mar 4 2015

bitglue renamed T7443: Include full link to Maniphest tasks in commit messages from Include full link to Manifest tasks in commit messages to Include full link to Maniphest tasks in commit messages.
Mar 4 2015, 8:33 PM · Diffusion, Arcanist
bitglue added a comment to T7443: Include full link to Maniphest tasks in commit messages.

I think you are misunderstanding my proposal.

Mar 4 2015, 8:32 PM · Diffusion, Arcanist

Mar 3 2015

bitglue added a comment to T7443: Include full link to Maniphest tasks in commit messages.

My take on T5378 is that links don't get the same helpful context as tokens, such as:

Mar 3 2015, 8:51 PM · Diffusion, Arcanist
bitglue created T7443: Include full link to Maniphest tasks in commit messages.
Mar 3 2015, 7:42 PM · Diffusion, Arcanist

Dec 2 2014

bitglue added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

I've got to rebump this issue. I've started a new job since I last commented, and the current review process needs some work. Currently we are using GitHub PRs for review and I don't like it. I've installed Phabricator for evaluation, and so far both of two people who have tried it have made this mistake.

Dec 2 2014, 7:49 PM · Design, Differential

Nov 26 2014

bitglue updated the task description for T6651: Wiki allows creation of document under empty root, but then won't save it.
Nov 26 2014, 2:31 PM · Phriction
bitglue created T6651: Wiki allows creation of document under empty root, but then won't save it.
Nov 26 2014, 2:30 PM · Phriction

May 9 2014

bitglue created T5006: `arc patch` leaves a useless branch around when aborted due to a missing base.
May 9 2014, 6:47 PM · Arcanist
bitglue updated the test plan for D9029: Allow .arclint to configure max line length of text linter.
May 9 2014, 6:31 PM
bitglue updated the diff for D9029: Allow .arclint to configure max line length of text linter.
  • make option name consistent with other options
May 9 2014, 6:30 PM
bitglue retitled D9029: Allow .arclint to configure max line length of text linter from to Allow .arclint to configure max line length of text linter.
May 9 2014, 6:21 PM
bitglue retitled D9028: Don't call writeLogLog. Just writeLog will do. from to Don't call writeLogLog. Just writeLog will do..
May 9 2014, 5:11 PM

May 8 2014

bitglue created T4999: Inline comments say they are "Not Visible" when they are..
May 8 2014, 9:02 PM · Differential

May 6 2014

bitglue added a comment to T4930: Differential eats inline comments that have been edited.

OK looks like you got it, but I was able to reproduce here at https://secure.phabricator.com/D8994#23. Like you say, seems you must have inline comments without a normal comment.

May 6 2014, 1:07 PM · Differential
bitglue abandoned D8994: Testing, for T4930..
May 6 2014, 1:06 PM
bitglue added a comment to T4930: Differential eats inline comments that have been edited.

OK...looks like this instance is broken in a slightly different way. Here's what I got when I tried to edit:

May 6 2014, 1:04 PM · Differential
bitglue added a comment to T4930: Differential eats inline comments that have been edited.

Actually, I forgot a key part of what I wrote in my reproduction steps: edit that comment. When I look at D8994, there's no option to edit. On my instance, it seems like I can go back to any revision, edit an inline comment, and it disappears. Why can I edit on mine but not yours?

May 6 2014, 12:59 PM · Differential
bitglue added inline comments to D8994: Testing, for T4930..
May 6 2014, 12:52 PM
bitglue reclaimed D8994: Testing, for T4930..
May 6 2014, 12:52 PM
bitglue added inline comments to D8994: Testing, for T4930..
May 6 2014, 12:51 PM
bitglue added a comment to T4930: Differential eats inline comments that have been edited.

Still need to try updating my version. Perhaps a significant difference: I updated the diffs here "via web". On my instance it was done with arc, and it says "via conduit".

May 6 2014, 12:49 PM · Differential
bitglue abandoned D8994: Testing, for T4930..
May 6 2014, 12:47 PM
bitglue updated the diff for D8994: Testing, for T4930..

Modifying README is so 2000. We should modify LICENSE instead, because that has dire legal consequences.

May 6 2014, 12:46 PM
bitglue updated the diff for D8994: Testing, for T4930..

Be polite.

May 6 2014, 12:44 PM
bitglue reclaimed D8994: Testing, for T4930..
May 6 2014, 12:44 PM
bitglue added a comment to T4930: Differential eats inline comments that have been edited.

Reloading does not fix it. I tried to reproduce at D8994, but was unable. I'll try updating my install and see if that changes anything.

May 6 2014, 12:43 PM · Differential
bitglue abandoned D8994: Testing, for T4930..

I guess this wasn't a good idea, anyway.

May 6 2014, 12:41 PM
bitglue updated the diff for D8994: Testing, for T4930..

Test emphatically, but just once.

May 6 2014, 12:40 PM
bitglue added inline comments to D8994: Testing, for T4930..
May 6 2014, 12:39 PM
bitglue updated the diff for D8994: Testing, for T4930..

Test more emphatically.

May 6 2014, 12:38 PM
bitglue retitled D8994: Testing, for T4930. from to Testing, for T4930..
May 6 2014, 12:37 PM

Apr 30 2014

bitglue created T4930: Differential eats inline comments that have been edited.
Apr 30 2014, 8:40 PM · Differential
bitglue created T4925: Renaming a project moves its wiki page, but not descendants of that wiki page.
Apr 30 2014, 12:56 AM · Phriction

Apr 24 2014

bitglue created T4899: Emails and history for Differential prefers "changed subscribers" over "accepted this revision".
Apr 24 2014, 8:04 PM · Differential

Apr 23 2014

bitglue awarded D7689: Reject dangerous changes in Git repositories by default a The World Burns token.
Apr 23 2014, 8:35 PM

Apr 18 2014

bitglue created T4835: Diffusion displays an ugly error on empty repositories.
Apr 18 2014, 8:54 PM · Diffusion

Apr 16 2014

bitglue added a comment to T2542: Provide a link from revisions that are blamees to their blamers.

Probably if there is a thing being blamed, it should be commits, not revisions. It may be that a commit was made without review that broke something, but never will it be the case that an un-committed revision broke anything. Also if you subscribe to DaggyFixes, then blaming a commit makes it clear from where the fix should be based. The workflow might look something like this:

Apr 16 2014, 6:33 PM · Audit, Diffusion, Differential
bitglue added a comment to T1751: Consider ways to improve revert handling.

Related to this are commits that aren't reverts, but are fixes to regressions. Maybe whatever problem was initially introduced wasn't so horrible that it first had to be reverted -- it was easy enough to just fix it. A fix might link back to a revision that introduced the error. Addressing concerns from audits is related: if I author a revision to address an audit concern, it might be nice to formally link the two.

Apr 16 2014, 5:58 PM · Restricted Project, Diffusion, Differential
bitglue added a comment to T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything".

Totally agree with not having separate "importance" and "urgency" fields -- that is too much process to exist in the product and force upon everyone. The biggest problem I'd like to see solved here is just the surprise I get when dragging things around in the workboard. That could be fixed either by separating ordering from priority, or making the current behavior more clear, UX-wise.

Apr 16 2014, 3:39 PM · Workboards, Maniphest
bitglue updated the task description for T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything".
Apr 16 2014, 10:34 AM · Workboards, Maniphest
bitglue renamed T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything" from Maybe "priority" and "order on workboards" should not be the same thing to Top-to-bottom ordering on workboards is suprising.
Apr 16 2014, 10:10 AM · Workboards, Maniphest
bitglue updated the task description for T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything".
Apr 16 2014, 10:09 AM · Workboards, Maniphest
bitglue updated the task description for T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything".
Apr 16 2014, 9:48 AM · Workboards, Maniphest
bitglue created T4807: Workboards should support alternate ordering rules, including "don't keep arranged by anything".
Apr 16 2014, 3:04 AM · Workboards, Maniphest

Apr 11 2014

bitglue added a comment to T4655: Upload Files action doesn't work.

More practically, we can punt on solving this, resolve ourselves to not being able to upload files (other than the drag and drop upload), and just cut the 'attach file' feature from Maniphest altogether.

Apr 11 2014, 9:35 PM · Maniphest
bitglue accepted D8757: Differential - fix bug writing affected paths.

Fixes the problem and doesn't break things for me now. Maybe you want an actual developer like @epriestley to review it also -- I really have no idea why what you changed makes a difference.

Apr 11 2014, 6:33 PM
bitglue added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

@chad, I'm not proposing auto-save. I'm saying leave everything as it is, and get rid of the button that does nothing.

Apr 11 2014, 5:44 PM · Design, Differential
bitglue updated subscribers of T4774: "Pending Differential Revisions" not displaying in when browsing repository.

@btrahan, I'm setting "Action: Upload File" in the comment box and attaching the file, but it's not showing up. Oddly, the preview says "bitglue changed files, attached: ; detached: ". Guess that's a separate problem. Anyhow, here's the arc output and apache log: https://gist.github.com/bitglue/8c6f53331186577c4bfc

Apr 11 2014, 5:20 PM · Phabricator
bitglue added a comment to T4774: "Pending Differential Revisions" not displaying in when browsing repository.

Also apache error.log attached.

Apr 11 2014, 5:16 PM · Phabricator
bitglue added a comment to T4774: "Pending Differential Revisions" not displaying in when browsing repository.

With D8757 applied, I can't arc diff new changes. A log of output with --trace is attached.

Apr 11 2014, 5:14 PM · Phabricator
bitglue requested changes to D8757: Differential - fix bug writing affected paths.

This breaks arc diff for me. I think I can attach a log to T4774...

Apr 11 2014, 5:11 PM
bitglue awarded D8757: Differential - fix bug writing affected paths a Piece of Eight token.
Apr 11 2014, 4:50 PM
bitglue added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

If there's some technical reason getting rid of inline comment buttons is hard, then I propose that the button says "preview", and that it's not blue. I think that's still confusing, but at least people will be confused immediately and directly, rather than thinking everything went fine then confused when other people can't see their comments.

Apr 11 2014, 4:38 PM · Design, Differential
bitglue added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

@chad, why do you need a button at all? Not-inline comments have just two states:

Apr 11 2014, 4:35 PM · Design, Differential
bitglue added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

If I can weigh in with my own opinion: the workflow is good as it is -- it's just not obvious what that workflow is. I posit that the blue "ready" button serves no purpose except to confuse. I don't know why you'd need to "ready" a comment. You've typed it in, and it's ready. It doesn't help that there are big blue buttons everywhere in Phabricator with whimsical titles. I like the whimsy, and in all cases but this one it's fine, because these buttons mean one thing: "do the thing". But "ready" doesn't do a thing -- all it does is animate the box to make it look like the thing was done. No one bothers to read "Not Yet Submitted", because they are already convinced, by having clicked the big blue button, and having seen the animation, that the thing they wanted to do has been done.

Apr 11 2014, 3:57 PM · Design, Differential

Apr 9 2014

bitglue added a comment to T4751: `arc patch` fails in empty repositories.

A rather poor workaround is:

Apr 9 2014, 2:07 PM · Arcanist

Apr 8 2014

bitglue created T4774: "Pending Differential Revisions" not displaying in when browsing repository.
Apr 8 2014, 9:42 PM · Phabricator

Apr 7 2014

bitglue added a comment to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

Use case for me is creating a herald rule to match revisions which were merged without ever being reviewed so they can instead be audits. Sometimes no one is available to do reviews and I need to more forward so I give up waiting and merge without review, but I still want someone to look at the commit eventually.

Apr 7 2014, 5:25 PM · Diffusion, Differential, Herald

Feb 27 2014

bitglue added a comment to T4414: Initial import of Git repositories with many branches is grossly inefficient.

I can confirm this issue. I have about 3500 commits and 170 branches, and was running out of memory on a 1GB VM.

Feb 27 2014, 10:57 PM · Diffusion

Dec 8 2013

bitglue closed T4218: Profit as Invalid.
Dec 8 2013, 3:39 PM · testies
bitglue edited this Maniphest Task.
Dec 8 2013, 3:38 PM
bitglue edited this Maniphest Task.
Dec 8 2013, 3:38 PM · testies
bitglue awarded T4218: Profit a Pterodactyl token.
Dec 8 2013, 3:37 PM · testies
bitglue added a comment to T4218: Profit.

OMG EMAIL COMMENT!

Dec 8 2013, 3:32 PM · testies
bitglue updated the task description for T4218: Profit.
Dec 8 2013, 3:31 PM · testies
bitglue added a comment to T4218: Profit.

Sounds like a good plan.

Dec 8 2013, 3:30 PM · testies
bitglue claimed T4218: Profit.
Dec 8 2013, 3:30 PM · testies