Page MenuHomePhabricator
Feed Advanced Search

Aug 25 2016

epriestley added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Contributor Onboarding.
Aug 25 2016, 3:30 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T10673: Convert Phurl to use EditEngine from Backlog to Intermediate on the Contributor Onboarding board.
Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley reassigned T10673: Convert Phurl to use EditEngine from lpriestley to jcox.
Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10673: Convert Phurl to use EditEngine.

EditEngine is a slightly different way to build forms that look the same as other forms, introduced circa January 2016. Some applications have moved to it, while others have not yet. It seems pretty reasonable and stable, though, so we're in the process of moving everything over.

Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley moved T11532: Replace paste language selection dropdown with a typeahead from Backlog to Basic on the Contributor Onboarding board.
Aug 25 2016, 3:00 PM · Paste, Contributor Onboarding
epriestley assigned T11532: Replace paste language selection dropdown with a typeahead to jcox.
Aug 25 2016, 3:00 PM · Paste, Contributor Onboarding
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

First, let's sort of limit the direct damage this misconfiguration causes by changing this line in PhabricatorUserLog->initializeNewLog():

Aug 25 2016, 2:43 PM · Contributor Onboarding, Setup
epriestley renamed T11532: Replace paste language selection dropdown with a typeahead from Replace paste dropdown with a typeahead to Replace paste language selection dropdown with a typeahead.
Aug 25 2016, 2:34 PM · Paste, Contributor Onboarding
epriestley added a project to T10681: Add Phurl Conduit API methods : Contributor Onboarding.
Aug 25 2016, 2:33 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley added a project to T10673: Convert Phurl to use EditEngine: Contributor Onboarding.
Aug 25 2016, 2:32 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T11529: Send emails/notifications containing the link to the action on the object which triggered it.

T7643#175911 has some discussion of this.

Aug 25 2016, 2:31 PM · Feature Request
epriestley added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

Is there a valid technical reason for Google to work like this?

Aug 25 2016, 2:25 PM · Feature Request
epriestley created T11532: Replace paste language selection dropdown with a typeahead.
Aug 25 2016, 2:24 PM · Paste, Contributor Onboarding
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Ah, nice! I'll write up some guidance on adding a setup check for this shortly.

Aug 25 2016, 2:22 PM · Contributor Onboarding, Setup
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

In the read/write case, it's too late once we hit a hook -- we need to be able to decide which cluster node to send the traffic to, and we need to know if it's a read or write request before we make that decision, since there may be a nearby read-only node and a distant read/write node. If we can examine the stream and make a determination that the request is read-only, we can freely pick a nearby read-only node.

Aug 25 2016, 4:42 AM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Today, we technically do not need to decode the protocol, but we will need to be able to distinguish between read and write requests to implement cluster read-only nodes (T10883) in the future and need to be able to rewrite the protocol to keep parity with fork-like/virtual-ref features that we plan to support in Git (T10691, T8092).

Aug 25 2016, 4:26 AM · Diffusion, Mercurial
epriestley closed T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close as Resolved.

The action is indistinguishable from an update from Herald's perspective. Herald runs on the state of the object, not changes to it, so "Changed file content" will just match whatever the diff changes.

Aug 25 2016, 1:06 AM · Bug Report

Aug 24 2016

epriestley closed T7492: Documentation for Paste as Wontfix.

No one actually seems confused by Paste. Obviously documentation "should" exist, but probably not worth keeping this task around since it has just been idle for more than a year. I suspect we'll write it as soon as someone runs into a problem that needs to be documented.

Aug 24 2016, 11:54 PM · Documentation, Paste
epriestley closed T7476: Add function_exists() guards to play nice together with illuminate/support (for working with eloquent, the laravel database layer) as Wontfix.

We haven't seen more interest in this in a long time, and I don't currently plan to make compatibility-focused changes to the stack.

Aug 24 2016, 11:53 PM
epriestley merged T7468: No way to disable web notifications for token awards into T10448: Modularize mail tags.
Aug 24 2016, 11:51 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged task T7468: No way to disable web notifications for token awards into T10448: Modularize mail tags.
Aug 24 2016, 11:51 PM · Tokens
epriestley added a comment to T7468: No way to disable web notifications for token awards.

I'm going to merge this into T10448, which discusses limitations and improvements to the mail tags system. This is an example of a cross-cutting tag ("No Application/System Settings") that isn't handled gracefully by the current system, but correcting this and other similar issues is a goal of future work.

Aug 24 2016, 11:51 PM · Tokens
epriestley merged T7431: Redesign Welcome Screen for Admins into T11132: New Phabricator NUX.
Aug 24 2016, 11:47 PM · Design, Phacility, NUX
epriestley merged task T7431: Redesign Welcome Screen for Admins into T11132: New Phabricator NUX.
Aug 24 2016, 11:47 PM · Setup
epriestley added a comment to T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..

T7385 is probably also approximately this.

Aug 24 2016, 11:45 PM · Restricted Project, Arcanist, Bug Report
epriestley merged T7385: arc feature D123 fails with ERR-INVALID-SESSION into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:45 PM · Restricted Project, Arcanist, Bug Report
epriestley merged task T7385: arc feature D123 fails with ERR-INVALID-SESSION into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:45 PM · Arcanist
epriestley added a comment to T11526: Differential Revision herald rule for Harbormaster build fired on commandeer + close.

Commandeer fires Herald rules so stuff like "Require Legalpad Signature" or "Add Reviewers: that intern's wrangler" work.

Aug 24 2016, 11:44 PM · Bug Report
epriestley added a comment to T7301: XHPAST application is not optimized for mobile.

The first page I found on the internet claims the iPhone 7 will be 1920x1080, so my strategy looks like it's paying off!

Aug 24 2016, 11:40 PM · XHPAST, Mobile
epriestley closed T7296: Allow config options to be bound to applications as Wontfix.

I think most of these are just moving into Application configuration over time, which tends to be a bit easier to use. I expect to just continue that trend in the future and this probably isn't worth building separately. I can't recall too much other confusion, and most of these are called <appname>.stuff anyway, which is fairly not-misleading.

Aug 24 2016, 11:39 PM · Restricted Project, Applications
epriestley closed T7286: Re-evaluate whether passing GET data in the body is a good idea as Wontfix.

This doesn't seem to be doing anything bad in practice. I think you can put the data in the URI if you want too and it works fine. Not clear that this is wrong/invalid enough to completely prevent it, and hasn't moved forward in a year and a half or so.

Aug 24 2016, 11:36 PM · libphutil
epriestley closed T7134: Make CDN resource population more robust in the Phacility cluster as Resolved.

I think this was effectively resolved by D15775, which improved behavior for multiple cluster frontends.

Aug 24 2016, 11:32 PM · Phacility
epriestley added a comment to T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..

T7074 may not be this, exactly, but they're close enough for government work.

Aug 24 2016, 11:29 PM · Restricted Project, Arcanist, Bug Report
epriestley merged T7074: `arc patch Dx` shouldn't ask for authentication if Dx is public into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:28 PM · Restricted Project, Arcanist, Bug Report
epriestley merged task T7074: `arc patch Dx` shouldn't ask for authentication if Dx is public into T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Aug 24 2016, 11:28 PM · Arcanist
epriestley added a comment to T6996: Write an `--output <file>` mode for `storage dump` which can gzip.

This seems to be working, I think the last step is replacing the original call in the backup workflow.

Aug 24 2016, 11:28 PM · Infrastructure, Phacility
epriestley closed T6853: "Open Revisions Affecting These Files" should weight severity of changes as Wontfix.

We made this a little smarter and a little less prominent (on a non-default tab) and I feel like it's generally in a more reasonable place now. I don't currently expect to make it significantly more complex, and none of the rules proposed here feel like simple, unambiguous improvements to me.

Aug 24 2016, 11:18 PM · Differential
epriestley moved T6832: File/folder properties overwritten during patching from Backlog to arc patch on the Arcanist board.
Aug 24 2016, 11:16 PM · Subversion, Arcanist
epriestley moved T8937: Unclear exception when patching non-existant revision from Backlog to arc patch on the Arcanist board.
Aug 24 2016, 11:16 PM · Arcanist
epriestley moved T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error. from Backlog to arc patch on the Arcanist board.
Aug 24 2016, 11:16 PM · Restricted Project, Arcanist, Bug Report
epriestley closed T6752: Improve functionality of rebasing commits with references in commit message as Wontfix.

We haven't seen other requests in this vein, exactly, in about two years, and we generally don't expect users to rewrite published commits as a routine workflow.

Aug 24 2016, 11:14 PM · Transactions, Diffusion
epriestley added a comment to T6524: Support "request is from IP / subnet" policy rule.

T6706 was the IP-address specific task.

Aug 24 2016, 11:11 PM · Policy
epriestley closed T6524: Support "request is from IP / subnet" policy rule as Wontfix.

We haven't seen other requests for this in nearly two years, and it can likely be implemented as an extension, except possibly for the weird cases mentioned above.

Aug 24 2016, 11:07 PM · Policy
epriestley closed T6486: Pending Differential Revisions isn't filtered by branch as Wontfix.

We haven't seen other users run into difficulty with this in the last couple of years, so I don't currently plan to change it.

Aug 24 2016, 7:52 PM · Diffusion
epriestley closed T6330: Add filter for "Unverified" users in People module as Wontfix.

This was filed a while ago, but it's not clear to me why this is useful -- no obvious reason to want to do this springs to mind.

Aug 24 2016, 7:30 PM · People
epriestley closed T5704: Print where we're reading configuration from on Phabricator script startup with --trace as Wontfix.

No clue what this was, haven't had issues recently. I think config may have become simpler in the last couple years.

Aug 24 2016, 7:14 PM · Setup
epriestley merged task T5312: Error raised when updating a revision which has non-permitted reviewers because of policy constraints into T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").
Aug 24 2016, 7:02 PM · Differential
epriestley merged T5312: Error raised when updating a revision which has non-permitted reviewers because of policy constraints into T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").
Aug 24 2016, 7:02 PM · Bug Report
epriestley closed T5327: Provide a `./bin/lookup` script as Wontfix.

Although I don't think this is necessarily a bad idea, I haven't seen too much of a need for this. Some alternatives:

Aug 24 2016, 7:01 PM
epriestley closed T11525: phutil_utf8ize() does not normalize overlong forms of 3-byte and 4-byte characters, but json_encode() refuses to encode them as Resolved by committing Restricted Diffusion Commit.
Aug 24 2016, 4:31 PM
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 4:02 PM · Diffusion
epriestley added a revision to T11525: phutil_utf8ize() does not normalize overlong forms of 3-byte and 4-byte characters, but json_encode() refuses to encode them: Unknown Object (Differential Revision).
Aug 24 2016, 3:53 PM
epriestley created T11525: phutil_utf8ize() does not normalize overlong forms of 3-byte and 4-byte characters, but json_encode() refuses to encode them.
Aug 24 2016, 2:33 PM
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 1:28 PM · Diffusion
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 12:59 PM · Diffusion
epriestley added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

Ah, thanks! I think that should be relatively easy to fix.

Aug 24 2016, 12:43 PM · Restricted Project, Bug Report
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 12:35 PM · Diffusion
epriestley added a revision to T11522: Improve support for guiding users through repository rewrites: Unknown Object (Differential Revision).
Aug 24 2016, 12:06 PM · Diffusion
epriestley added a comment to T11522: Improve support for guiding users through repository rewrites.

We have an existing repository_badcommit table which is used to mark commits as "bad", where "bad" approximately means "the repository as a whole works, but the VCS tools can not read or should not read this particular commit for whatever reason". This is rare, but can happen when, e.g., third-party tools are used to write into repositories.

Aug 24 2016, 11:33 AM · Diffusion
epriestley added a comment to T11523: Unhandled Exception ("AphrontSchemaQueryException").

Have you tried following the instructions given in the error message?

Aug 24 2016, 11:13 AM · Bug Report (Needs Information)
epriestley created T11524: Import-time diff generation fails for particular commits in cluster mode.
Aug 24 2016, 11:09 AM · Phacility, Clusters, Daemons, Diffusion
epriestley created T11522: Improve support for guiding users through repository rewrites.
Aug 24 2016, 1:09 AM · Diffusion
epriestley closed T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks as Resolved.

Re-reading D9115, I think I was never able to understand or reproduce this and it was ultimately mooted anyway.

Aug 24 2016, 12:00 AM · Restricted Project, libphutil

Aug 23 2016

epriestley closed T4909: Rate limit or restrict access to comment removal as Wontfix.

As far as I know, no users have actually gone berserk and deleted all their comments in nearly two years now, so I don't plan to specifically build comment removal rate limiting: this action does not seem particularly more dangerous or abuse-prone in practice than other actions like adding comments, merging tasks, etc. If a user did do this, recovery is likely not very difficult even without limiting.

Aug 23 2016, 10:38 PM · Abuse, Wikimedia
epriestley closed T4782: Provide short revision status summary in Differential query results? as Wontfix.

I built a similar UI as part of D15926, but we declined to actually bring it upstream. It's possible that we may revisit this in the future, or that it may become possible via T418, but I don't currently plan to pursue this.

Aug 23 2016, 7:27 PM · Custom Fields, Differential
epriestley closed T4661: Custom "date" field displays date input in different format than preferences as Resolved.

We now allow you control component order in the date control.

Aug 23 2016, 7:13 PM · User Preferences
epriestley closed T4485: Try to guess when a user copy/pastes a giant block of output from something? as Wontfix.

I haven't come up with any kind of rule for this in the last couple years which feels sufficiently un-magical, even in theory. It hasn't happened all that often recently, either, at least that I can recall.

Aug 23 2016, 7:11 PM · Remarkup
epriestley closed T4445: Diffusion tag cache not updating correctly when tags move? as Resolved.

This is like two years old now, and I'm pretty sure it works now since no one else has reported it and it would likely have come up when clustering was written a few months ago if it was still an issue. If anyone is still seeing issues, please feel free to file a new report with reproduction steps.

Aug 23 2016, 7:08 PM · Diffusion
epriestley closed T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls as Resolved.

I think this was effectively resolved by D12773, since using conduit.token should evade the session timeout.

Aug 23 2016, 7:02 PM · Conpherence, Phabot
epriestley added a comment to T3311: Detect or manage optipng versions (-clobber flag).

Sounds like we should write a "Screencastph" app!

Aug 23 2016, 7:01 PM · Celerity
epriestley added a comment to T3311: Detect or manage optipng versions (-clobber flag).

rough life :(

Aug 23 2016, 6:56 PM · Celerity
epriestley added a project to T4190: Rebuild remarkup image proxying: Contributor Onboarding.
Aug 23 2016, 6:53 PM · Contributor Onboarding, Remarkup
epriestley closed T3311: Detect or manage optipng versions (-clobber flag) as Wontfix.

This hasn't come up again in three years so I'm just going to assume that everyone is realistically installing 0.7.0 or newer nowadays. Today, optiping strongly recommends upgrading to 0.7.6 or newer to fix some security issues.

Aug 23 2016, 6:42 PM · Celerity
epriestley added a comment to T11519: Herald unable to email the owners of a package.

Let me see if I can reproduce this, but this is probably straightforward to fix -- I suspect some code just didn't get updated when Owners packages became mailable.

Aug 23 2016, 6:25 PM · Bug Report
epriestley awarded T11518: Make arc feature much more fancy and fun a Party Time token.
Aug 23 2016, 6:23 PM · Restricted Project, Feature Request
epriestley closed T2519: Phabricator as Mailing List manager, a subtask of T4267: Support alias accounts, as Wontfix.
Aug 23 2016, 6:09 PM · Restricted Project, FreeBSD
epriestley closed T2519: Phabricator as Mailing List manager as Wontfix.

This a very old task that lacks root problem / use case information that we require for modern feature requests.

Aug 23 2016, 6:09 PM · Conpherence
epriestley added a comment to T2493: Support `arc land` in stacked commits.

This general issue receives significant discussion in T3875. I don't think we've seen significant adoption of the unusual "stacked-on-the-same-branch" workflow, but similar concerns apply to branches-on-branches at the least.

Aug 23 2016, 5:44 PM · Restricted Project, Arcanist
epriestley added a parent task for T2493: Support `arc land` in stacked commits: T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`.
Aug 23 2016, 5:42 PM · Restricted Project, Arcanist
epriestley added a subtask for T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`: T2493: Support `arc land` in stacked commits.
Aug 23 2016, 5:42 PM · Prioritized, Restricted Project, Arcanist
epriestley closed T1621: In Git, clean up local tags that are no longer present in the remote as Resolved.

I believe this was resolved by T6878 or related work. In the modern codebase, we fetch with --prune and explicit refspecs, which is sufficient according to git help fetch:

Aug 23 2016, 5:40 PM · Restricted Project, Diffusion
stevex awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Aug 23 2016, 2:15 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
joshuaspence awarded T11480: Stop sending misbehaving user nonsense to the error log a Doubloon token.
Aug 23 2016, 12:26 PM
epriestley closed T11516: Test open as Invalid.
Aug 23 2016, 11:56 AM · Bug Report
epriestley closed T11507: Many Modal workflows don't work ( JS Crash ) as Invalid.

Ah, the project creation issue with gd issue is captured in T10405.

Aug 23 2016, 5:08 AM · Bug Report (Needs Information)
epriestley added a comment to T11515: `arc ade` should do something.

Also arc anist should probably be an alias for arc, so you can type arc anist diff.

Aug 23 2016, 3:59 AM · Feature Request
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).
uname -a
[ec2-user@ip-172-30-0-13 phabricator]$ uname -a
Linux ip-172-30-0-13 4.4.11-23.53.amzn1.x86_64 #1 SMP Wed Jun 1 22:22:50 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Aug 23 2016, 3:54 AM · Bug Report (Needs Information)
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

Thanks! I still can't reproduce this. Here's the install I brought up, following your instructions as closely as possible:

Aug 23 2016, 3:47 AM · Bug Report (Needs Information)
epriestley added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

This is not a bug report until it has reproduction instructions. If we don't get reproduction instructions, we will not send this to the bottom of the list -- instead, we will close the report as "Invalid" and ignore the problem: we can not move forward without reproduction instructions.

Aug 23 2016, 1:00 AM · Bug Report (Needs Information)

Aug 22 2016

epriestley added a comment to T11514: Authentication should have a way to customize the credentials name.

Strings with sentence fragments like that can be difficult to translate in the normal human language sense, see:

Aug 22 2016, 10:34 PM · Auth, LDAP, Feature Request
yelirekim awarded T8236: `arc weld` should do something a 100 token.
Aug 22 2016, 10:21 PM · Contributor Onboarding, Arcanist
epriestley added a comment to T11512: Add error handling to email commands.

It's possible there's some weirdness, but I think it just works. Let me know if that doesn't hold up in practice.

Aug 22 2016, 10:12 PM · Feature Request
epriestley edited this Badge.
Aug 22 2016, 10:10 PM
epriestley added a comment to T11514: Authentication should have a way to customize the credentials name.

This is probably something we'll need in the very long run for T6703 (if we legitimately let you connect to two different LDAP servers, it would be silly to have two "Login with LDAP" dialogs) but, yeah, using translation.override or just editing PhabricatorLDAPAuthProvider might be the shortest path today.

Aug 22 2016, 10:04 PM · Auth, LDAP, Feature Request
epriestley closed T9899: Chatbot requires access to the database as Resolved.

Per discussion T11508, I'm just going to officially call this a "feature".

Aug 22 2016, 9:46 PM · Phabot
epriestley added a comment to T8236: `arc weld` should do something.

(You are free to choose any other behavior -- even a useful one -- the requirement is only that arc weld do something.)

Aug 22 2016, 9:18 PM · Contributor Onboarding, Arcanist
epriestley moved T8236: `arc weld` should do something from Backlog to Intermediate on the Contributor Onboarding board.
Aug 22 2016, 9:18 PM · Contributor Onboarding, Arcanist
epriestley assigned T8236: `arc weld` should do something to jcox.

This will further familiarize you with arc. This may make sense to hold until some time after T5055, when arc workflows may change a bit. See also T11429.

Aug 22 2016, 9:17 PM · Contributor Onboarding, Arcanist
epriestley moved T11513: Convert the application selector in "pin applications" to a typeahead from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 9:11 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request
epriestley assigned T11513: Convert the application selector in "pin applications" to a typeahead to jcox.

You can find this UI in Config → Home Page → Pin Application. Here's the relevant control:

Aug 22 2016, 9:11 PM · Restricted Project, Contributor Onboarding, User Delight, Feature Request