Meow Meow

Use cases we've seen FWIW:

Yeah it does, and I just didn't recall ever seeing this behavior and assumed "stack trace" meant "error".

Oh also apparently query profiling doesn't always come up when you click on it, here is an example error

@jcox do you know how to reproduce arc diff dying when you try to create certain types of diffs that move or remove symlinks? I think that's adjacent, if not identical to what's being talked about here.

i used gem install so that i could remain ignorant of those types of problems

it has an -s option

There is a program far superior to cat that already exists.

Or apparently just doing this anywhere

Using Chrome

Here I was thinking I found a helpful public bug.

Hm, actually the problem here is that the notification bubble doesn't show up for any file uploads on our current version. I suppose it could actually be "on our current version + extensions". I'll get a reproduction matrix together tomorrow.

We don't have a notifications server, does that make it like that?

Ok I actually get a dialog on secure., it's probably because we're out of date with the upstream.

thank you

Yeah I just wanted to buy myself a badge.

No nothing like that but FWIW, it just worked when I tried to reproduce it again.

Yeah.

Just tried again.

I have many other excellent ideas for the Phacility online swag store, these are my favorite:

Yeah I clicked "Delete File" and can't see it anywhere now.

Edited to not give out my credit card number on the internet.

This seems like a good plan to me, we're just checking in that this isn't totally outside the realm of possibility while we plan some super secret changes to our instance.

(not building locally anymore, eg, any time I want to do anything with a built binary at all, i'm actually doing it with a binary on a remote server because I can get the build results faster)

Well one facet of this is that remote servers tend to be significantly more powerful than developer machines, and so since I've implemented this downstream, I have basically taken to not building locally anymore.

Our actual internal use case is as follows:

The bash workflow is just loaded the same way all of the other ssh workflows are loaded, I think that the problem is one of security policy / segmentation.

Maybe make it so that we can host an arbitrary number of ssh daemons on different ports with different entry scripts? I suppose we can kinda do that already by just copying the existing script, minus the part where we have different groups of ssh keys, but could probably sub in passphrase as the backing for authentication there.

Oh nice, I was expecting the "this is awful" upstream response for this :) I can put together use cases and either @jcox or I can work on upstreaming it.

I'm not sure how this wasn't reported earlier, I guess the module cache prevented everyone from encountering it?

If you only knew how lucky you are to have Evan explain this to you rather than trolling through grep -Rn "PhutilClassMapQuery" * --include \*.php errday.

Live, armed, pre-commit A/B testing is unambiguously the most exciting part of our jobs.

Should we implement this as an internal search attachment in the meantime? Or is there a possible pathway for @jcox to get something like this working in ~3 days?

I'm thinking we just create a search attachment for maniphest.search which contains diff PHIDs.

Yes that would do it.

It relies on a server side API call so you'll have to actually extend your server install in order for it to work.

In T11518#191391, @chad wrote:

which devs don't? it's the designers, isn't it.

Basically "is the diff people are reviewing identical to your local branch"

Revision.

No I just read over all of the email commands and didn't see any exceptions thrown and I assumed this didn't work.

Playing devil's advocate, it's not too much of a stretch of the imagination to assume that one could then make it impossible to land things which have unaddressed "issues" vs "comments" on a review. That would be the only concrete advantage I see to explicitly defining these things rather than relying on human parsing.