Page MenuHomePhabricator

Support `arc land` in stacked commits
Closed, ResolvedPublic


If I have more commits related to more revisions in a single branch, I would like to use arc land to land all or some of them.

Ideally, arc land should detect that there are more landable revisions in the branch and amend all of them before pushing.

I should also be able to land only some commits with something like this:

$ git rebase -i
pick a
x arc land --keep-branch
pick a

Event Timeline

epriestley triaged this task as Normal priority.Apr 11 2013, 2:36 AM

I have a mail thread somewhere that I'll paste in here eventually.

(My sort of meta-stance here is that stacking changes in a single branch is a weird, Facebook-specific workflow that's not very good, and that the only advantage it has is that you can rebase everything quickly; implementing a cascading rebase and then pushing for a multi-branch workflow might be a better approach in the general case. But there's no real reason we couldn't do better in arc land too.)

chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 4:05 AM
eadler added a project: Restricted Project.Aug 5 2016, 5:24 PM

This general issue receives significant discussion in T3875. I don't think we've seen significant adoption of the unusual "stacked-on-the-same-branch" workflow, but similar concerns apply to branches-on-branches at the least.

epriestley claimed this task.

Changes connected to T13546 address this, see T13547 for a preview of new behavior.

(These changes haven't made it into actual revisions yet, but just cleaning this up while I'm doing a bookkeeping pass. The new behavior is that arc land stack means "land each revision in the stack".)