Page MenuHomePhabricator
Feed Advanced Search

Apr 22 2019

epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: D20462: When applying transactions, acquire a read lock sooner.
Apr 22 2019, 10:26 PM · Plans, Differential, Harbormaster
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Apr 22 2019, 7:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Apr 22 2019, 7:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Apr 22 2019, 7:06 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20457: Move BlameController away from ancient "TABLE_COMMIT".
Apr 22 2019, 6:47 PM · Diffusion, Harbormaster, Herald, Audit

Apr 16 2019

epriestley updated the task description for T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.
Apr 16 2019, 5:58 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T8093: Evaluate virtualizing Git refs by proxying the protocol: D20436: Make the "git upload-pack" proxy more robust.
Apr 16 2019, 4:23 PM · Restricted Project, Harbormaster
epriestley added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

When there are no refs in a repository, the server does not appear to send a capabilities frame:

Apr 16 2019, 3:58 PM · Restricted Project, Harbormaster

Apr 15 2019

epriestley moved T8238: Formally support side-band change handoff in external repositories from Backlog to Staging Areas on the Diffusion board.
Apr 15 2019, 4:00 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to "Track Only" on the Diffusion board.
Apr 15 2019, 3:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a project to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Diffusion.
Apr 15 2019, 3:34 PM · Diffusion, Harbormaster, Herald, Audit

Apr 14 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Apr 14 2019, 5:51 PM · Diffusion, Harbormaster, Herald, Audit

Apr 11 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20395: Remove very old "vsDiff" data from commit update / diff extraction pipeline.
Apr 11 2019, 1:12 PM · Diffusion, Harbormaster, Herald, Audit

Apr 10 2019

epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

Internally, see PHI1165 for nine pages of me complaining about this.

Apr 10 2019, 11:40 PM · Diffusion, Harbormaster, Herald, Audit

Apr 8 2019

epriestley added a revision to T8093: Evaluate virtualizing Git refs by proxying the protocol: D20381: Proxy the "git upload-pack" wire protocol.
Apr 8 2019, 4:01 PM · Restricted Project, Harbormaster
epriestley added a revision to T8093: Evaluate virtualizing Git refs by proxying the protocol: D20380: Add an optional protocol log to `git` SSH workflows.
Apr 8 2019, 2:22 PM · Restricted Project, Harbormaster

Apr 6 2019

epriestley added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

exciting new wire protocol

Apr 6 2019, 6:58 PM · Restricted Project, Harbormaster

Apr 2 2019

epriestley triaged T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Normal priority.
Apr 2 2019, 1:44 PM · Diffusion, Harbormaster, Herald, Audit

Mar 7 2019

epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), a subtask of T13088: Plans: Harbormaster UI usability and interconnectedness, as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 2:22 PM · Plans, Harbormaster

Mar 6 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 6 2019, 5:39 PM · Plans, Harbormaster
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them as Resolved by committing rPee0ad4703ebd: Make the new Build Plan "Runnable" behavior work.
Mar 6 2019, 2:01 PM · Restricted Project, Harbormaster, Feature Request
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them, a subtask of T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), as Resolved.
Mar 6 2019, 2:01 PM · Plans, Harbormaster

Mar 1 2019

epriestley added a comment to T13261: Update upstream build steps to include timeouts and limits.

Currently, properties on upstream build steps are driven by CustomFields. T13248 briefly discusses a bit of context.

Mar 1 2019, 5:23 PM · Harbormaster
epriestley updated the task description for T13257: Plans: Unbeta New Harbormaster Log UI.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:19 PM · Plans, Harbormaster
epriestley triaged T13261: Update upstream build steps to include timeouts and limits as Normal priority.
Mar 1 2019, 5:19 PM · Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
Mar 1 2019, 3:54 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 1 2019, 2:13 PM · Plans, Harbormaster

Feb 28 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20233: Implement Build Plan behavior "Affects Buildable".
Feb 28 2019, 9:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20232: Implement Build Plan "Hold Drafts" behavior.
Feb 28 2019, 9:12 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20230: Make the new Build Plan behavior "Restartable" work.
Feb 28 2019, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

After D20229, the rules are:

Feb 28 2019, 7:44 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T11415: Would like people who can't edit Harbormaster plans to be able to run them: D20229: Make the new Build Plan "Runnable" behavior work.
Feb 28 2019, 7:41 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20229: Make the new Build Plan "Runnable" behavior work.
Feb 28 2019, 7:41 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20228: Expose Build Plan behaviors via "harbormaster.buildplan.search".
Feb 28 2019, 7:01 PM · Plans, Harbormaster

Feb 26 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.
Feb 26 2019, 5:45 PM · Plans, Harbormaster
epriestley added a revision to T11415: Would like people who can't edit Harbormaster plans to be able to run them: D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.
Feb 26 2019, 5:45 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a parent task for T11415: Would like people who can't edit Harbormaster plans to be able to run them: T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:27 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a subtask for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): T11415: Would like people who can't edit Harbormaster plans to be able to run them.
Feb 26 2019, 3:27 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 3:26 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20219: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends.
Feb 26 2019, 1:49 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20218: Provide "harbormaster.buildplan.edit" in the API.
Feb 26 2019, 1:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20217: Move Harbormaster Build Plans to modular transactions.
Feb 26 2019, 1:17 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley updated the task description for T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc).
Feb 26 2019, 12:48 PM · Plans, Harbormaster
epriestley triaged T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Normal priority.
Feb 26 2019, 12:41 PM · Plans, Harbormaster
epriestley triaged T13257: Plans: Unbeta New Harbormaster Log UI as Normal priority.
Feb 26 2019, 12:36 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20216: Remove unusual "Created" element from Build Plan curtain UI.
Feb 26 2019, 12:35 PM · Plans, Harbormaster

Feb 15 2019

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20180: Allow unit tests to have arbitrarily long names (>255 characters).
Feb 15 2019, 3:19 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D20179: Give HarbormasterBuildUnitMessage a real Query class.
Feb 15 2019, 2:46 PM · Plans, Harbormaster

Jan 17 2019

avivey changed the visibility for T1394: Support creating audits with inline comments through the API.
Jan 17 2019, 7:17 PM · Conduit, Harbormaster, Audit

Nov 26 2018

pasik added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

@jbrownEP Hey! Was this implemented yet? I'm interested in this feature aswell.. (being able to run hook action once per push, no matter how many commits there are in the push).

Nov 26 2018, 2:37 PM · Restricted Project, Harbormaster

Nov 21 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Nov 21 2018, 5:07 PM · Plans, Harbormaster

Nov 15 2018

epriestley added a revision to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction.
Nov 15 2018, 12:10 AM · Plans, Differential, Harbormaster

Nov 1 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Nov 1 2018, 12:58 AM · Plans, Harbormaster

Oct 31 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 31 2018, 4:05 PM · Plans, Harbormaster

Oct 25 2018

epriestley removed a project from T13088: Plans: Harbormaster UI usability and interconnectedness: Drydock.

Some of this touches Drydock but I'm just kicking it off the board since this mostly turned into a Harbormaster task.

Oct 25 2018, 12:04 PM · Plans, Harbormaster

Oct 19 2018

epriestley closed T12703: When integrated, CircleCI and Harbormaster can send redundant notifications as Wontfix.

This currently appears to be mooted by T13188.

Oct 19 2018, 9:27 AM · Feature Request, Harbormaster

Oct 16 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 16 2018, 1:36 PM · Plans, Harbormaster

Oct 12 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 12 2018, 3:19 PM · Plans, Harbormaster

Oct 10 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 10 2018, 11:42 PM · Plans, Harbormaster

Oct 9 2018

urzds added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

See-Also: https://circleci.com/ideas/?idea=CCI-I-430
See-Also: https://discuss.circleci.com/t/webhook-support-removed-from-documentation-still-supported/19984

Oct 9 2018, 10:08 AM · Guides, Harbormaster

Oct 1 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 1 2018, 3:50 PM · Plans, Harbormaster

Sep 14 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 14 2018, 4:01 PM · Plans, Harbormaster

Sep 13 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 13 2018, 2:44 PM · Plans, Harbormaster

Sep 11 2018

pouyana added a comment to T8656: Parse ANSI-style color strings in build output.

I wrote a patch for this, for both new log prototype and old log viewer here some screenshots for the view. If it is look OK, I will submit it.

Sep 11 2018, 9:32 AM · Haskell.org, Restricted Project, Harbormaster

Sep 7 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 7 2018, 3:05 PM · Plans, Harbormaster

Aug 28 2018

epriestley added a comment to T9951: Store/display more information for Unit tests.

After D19615, callers to harbormaster.sendmessage can specify "format": "remarkup" to get "details" rendered as remarkup (including {Fxxx}) instead of plain text.

Aug 28 2018, 8:30 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley closed T9951: Store/display more information for Unit tests as Resolved by committing rP614f9ba1fba6: Allow unit test results to specify that their details are formatted with….
Aug 28 2018, 8:26 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: D19615: Allow unit test results to specify that their details are formatted with remarkup when reporting to "harbormaster.sendmessage".
Aug 28 2018, 8:24 PM · Plans, Harbormaster
epriestley added a revision to T9951: Store/display more information for Unit tests: D19615: Allow unit test results to specify that their details are formatted with remarkup when reporting to "harbormaster.sendmessage".
Aug 28 2018, 8:24 PM · Restricted Project, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

The unit test results also don't currently show on individual builds, which is a little whack?

Aug 28 2018, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

See T13189#240682 for some planning on the Unit Test result table.

Aug 28 2018, 7:52 PM · Plans, Harbormaster

Aug 27 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:21 PM · Plans, Harbormaster
epriestley closed T10870: Allow Harbormaster builds to run another build plan on the same buildable as Invalid.

(Feature request with no support mana.)

Aug 27 2018, 10:16 PM · Restricted Project, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 27 2018, 10:16 PM · Plans, Harbormaster
epriestley closed T10568: Report partially failed builds better in Diffusion history as Wontfix.

I expect to add flags like "this doesn't block undrafting" and "this build doesn't matter" soon, and then possibly refine those. I'd consider revisiting this after those deploy, but am not excited about formalizing the idea of "only some of your tests failed so it's okay" or adding a check for each build (since this won't scale very far). The tooltip is reasonable but I'll just turn that into a note on T13088.

Aug 27 2018, 10:14 PM · Restricted Project, Harbormaster, Diffusion, Feature Request
epriestley closed T10516: Harbormaster Conduit API to build as Invalid.

(Feature request with no support mana and no discussion.)

Aug 27 2018, 10:10 PM · Restricted Project, Conduit, Harbormaster, Feature Request
epriestley closed T9892: I want to be sent email when a build fails for any commit in a repository as Wontfix.

Feature request with no support mana and no discussion / unique insight.

Aug 27 2018, 10:08 PM · Restricted Project, Harbormaster
epriestley closed T9586: Modernize Harbormaster build step UI elements as Wontfix.

Nothing really actionable here.

Aug 27 2018, 10:07 PM · Restricted Project, Harbormaster
epriestley closed T5877: Allow build plans to be "embedded" inside other build plans, a subtask of T1049: Implement Harbormaster, as Wontfix.
Aug 27 2018, 10:06 PM · Harbormaster
epriestley closed T5877: Allow build plans to be "embedded" inside other build plans as Wontfix.

This is reasonable to build eventually, but there's currently no support mana behind it and this task doesn't have any unique context or discussion.

Aug 27 2018, 10:06 PM · Restricted Project, Harbormaster
epriestley closed T5860: Allow build plans to be cloned in Harbormaster, a subtask of T1049: Implement Harbormaster, as Wontfix.
Aug 27 2018, 10:06 PM · Harbormaster
epriestley closed T5860: Allow build plans to be cloned in Harbormaster as Wontfix.

No support mana behind this and no unique information in the task.

Aug 27 2018, 10:06 PM · Restricted Project, Harbormaster
epriestley closed T5803: Discussion: How will iteration over build steps work?, a subtask of T1049: Implement Harbormaster, as Resolved.
Aug 27 2018, 10:05 PM · Harbormaster
epriestley closed T5803: Discussion: How will iteration over build steps work? as Resolved.

This isn't an actionable task so I'm banishing it to the shadow realm.

Aug 27 2018, 10:05 PM · Restricted Project, Harbormaster
epriestley closed T12813: Integrate Harbormaster with GoCD, a subtask of T9456: Evaluate upstream support for third-party build systems, as Wontfix.
Aug 27 2018, 10:04 PM · Restricted Project, Harbormaster
epriestley closed T12813: Integrate Harbormaster with GoCD as Wontfix.

We don't have any support mana behind this request, it's a good candidate for third-party development, and there's no unique information in this task so I'm just going to close it out.

Aug 27 2018, 10:04 PM · Harbormaster, Feature Request
epriestley closed T12251: Add author information when creating a build in Buildkite as Resolved by committing rP632cafec881b: Pass commit authorship information to Buildkite.
Aug 27 2018, 7:52 PM · Harbormaster, Feature Request
epriestley added a revision to T12251: Add author information when creating a build in Buildkite: D19614: Pass commit authorship information to Buildkite.
Aug 27 2018, 7:50 PM · Harbormaster, Feature Request

Aug 24 2018

epriestley added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

The actual evidence about webhooks is a little spotty and it's possible that they "work" and are just undocumented and not officially supported. It's possible that CircleCI just needs a nudge to actually document/support them.

Aug 24 2018, 7:35 PM · Guides, Harbormaster
epriestley updated the task description for T9456: Evaluate upstream support for third-party build systems.
Aug 24 2018, 7:31 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

See T13188 for CircleCI 2.0. Upshot: they removed webhooks so we can no longer interact with them.

Aug 24 2018, 7:30 PM · Restricted Project, Harbormaster
epriestley triaged T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator as Low priority.
Aug 24 2018, 7:30 PM · Guides, Harbormaster

Aug 3 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 3 2018, 7:23 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Aug 3 2018, 7:21 PM · Plans, Harbormaster

Jul 27 2018

avivey added a comment to T9456: Evaluate upstream support for third-party build systems.

Looks like CircleCI will stop supporting the V1 API, which we use, in about 5 weeks: https://circleci.com/sunset1-0/

Jul 27 2018, 6:53 PM · Restricted Project, Harbormaster