Modernize Harbormaster build step UI elements
Closed, WontfixPublic
Actions

Assigned To

Authored By

	tycho.tatitscheff
	Oct 16 2015, 1:03 PM

Description

Harbormaster seems to use old ui elements for build step.

Would you accept a diff from myself to use a better ui element? It seems that it is fairly easy, small patch and suited for contributions since hm is no more prototype.

Revisions and Commits

rP Phabricator
	Abandoned	D14296 Fixing HM UI element

Related Objects

Mentioned In: rP3f193cb9e06c: Give Harbormaster build steps a "View" page
D14330: Give Harbormaster build steps a "View" page

Event Timeline

tycho.tatitscheff created this task.Oct 16 2015, 1:03 PM

tycho.tatitscheff updated the task description. (Show Details)

tycho.tatitscheff added a subscriber: tycho.tatitscheff.

tycho.tatitscheff renamed this task from Modernize Harbormaster UI to Modernize Harbormaster build step UI elements.Oct 16 2015, 1:12 PM

Where specifically does Harbormaster have old UI? These look like the correct modern components:

oh, maybe you mean this:

Screen Shot 2015-10-16 at 8.38.14 AM.png (788×642 px, 99 KB)

Yes those build step. Is it ok for you if i try to diff for putting a modern grey/blue text, without those 3d-ish borders. Basically makes second screenshot match first one.

It seems to be easy enough so i can contribute and it get reviewed.

chad added a project: Harbormaster.Oct 16 2015, 8:08 PM

So @chad are you oki for letting me contribute?

tycho.tatitscheff added a revision: D14296: Fixing HM UI element.Oct 17 2015, 12:54 PM