Page MenuHomePhabricator
Create Task
Maniphest T9586

Modernize Harbormaster build step UI elements
Closed, WontfixPublic
Actions

Description

Harbormaster seems to use old ui elements for build step.

Would you accept a diff from myself to use a better ui element? It seems that it is fairly easy, small patch and suited for contributions since hm is no more prototype.

Revisions and Commits

Restricted Differential Revision

Event Timeline

tycho.tatitscheff created this task.Oct 16 2015, 1:03 PM
tycho.tatitscheff updated the task description. (Show Details)
tycho.tatitscheff added a subscriber: tycho.tatitscheff.
tycho.tatitscheff renamed this task from Modernize Harbormaster UI to Modernize Harbormaster build step UI elements.Oct 16 2015, 1:12 PM
chad added a subscriber: chad.Oct 16 2015, 2:28 PM

Where specifically does Harbormaster have old UI? These look like the correct modern components:

pasted_file (497×397 px, 38 KB)

chad added a comment.Oct 16 2015, 3:39 PM

oh, maybe you mean this:

Screen Shot 2015-10-16 at 8.38.14 AM.png (788×642 px, 99 KB)

tycho.tatitscheff added a comment.EditedOct 16 2015, 4:06 PM

Yes those build step. Is it ok for you if i try to diff for putting a modern grey/blue text, without those 3d-ish borders. Basically makes second screenshot match first one.

It seems to be easy enough so i can contribute and it get reviewed.

chad added a project: Harbormaster.Oct 16 2015, 8:08 PM
tycho.tatitscheff added a comment.Oct 17 2015, 7:10 AM

So @chad are you oki for letting me contribute?

tycho.tatitscheff added a revision: Restricted Differential Revision.Oct 17 2015, 12:54 PM
chad added a comment.Oct 17 2015, 2:45 PM

This probably needs to be actually designed, so I'll take a pass at it in a bit.

chad claimed this task.Oct 17 2015, 2:45 PM
tycho.tatitscheff added a comment.Oct 17 2015, 4:10 PM

Oki.

chad triaged this task as Wishlist priority.Dec 10 2015, 9:24 PM
eadler added a project: Restricted Project.Aug 5 2016, 4:53 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 4:53 PM
chad removed chad as the assignee of this task.Aug 8 2016, 3:14 AM
epriestley closed this task as Wontfix.Aug 27 2018, 10:07 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

Nothing really actionable here.

Phabricator · Built by Phacility