Differential D20219

Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 1:49 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)

Commits

rP620047bcfe3f: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds…

Summary

Depends on D20218. Ref T13258. It's somewhat cumbersome to get from build plans to related builds but this is a reasonable thing to want to do, so make it a little easier.

Also clean up / standardize / hint a few things a little better.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 26 2019, 1:49 PM

Owners added a subscriber: Restricted Owners Package.Feb 26 2019, 1:49 PM

Harbormaster completed remote builds in B22130: Diff 48268.Feb 26 2019, 1:51 PM

epriestley requested review of this revision.Feb 26 2019, 1:51 PM

epriestley added a child revision: D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.Feb 26 2019, 5:44 PM

amckinley accepted this revision.Feb 27 2019, 1:09 AM

This revision is now accepted and ready to land.Feb 27 2019, 1:09 AM

Closed by commit rP620047bcfe3f: Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds… (authored by epriestley). · Explain WhyFeb 28 2019, 3:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

harbormaster/

controller/

HarbormasterPlanViewController.php

92 lines

query/

HarbormasterBuildSearchEngine.php

51 lines

storage/

build/

HarbormasterBuild.php

4 lines

configuration/

HarbormasterBuildPlan.php

2 lines

view/

HarbormasterBuildView.php

67 lines

Diff 48280

View Options

src/__phutil_library_map__.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

View Options

src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

View Options

src/applications/harbormaster/view/HarbormasterBuildView.php

Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and endsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48280

src/__phutil_library_map__.php

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php

src/applications/harbormaster/storage/build/HarbormasterBuild.php

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

src/applications/harbormaster/view/HarbormasterBuildView.php

Add a "Recent Builds" element to the Build Plan UI and tighten up a few odds and ends
ClosedPublic
Actions

Revision Contents
Changeset List