Page MenuHomePhabricator
Create Task
Maniphest T10568

Report partially failed builds better in Diffusion history
Closed, WontfixPublic
Actions

Description

It would be great to have more than a binary state to report build success in Diffusion history view:

pasted_file (365×553 px, 63 KB)

While actually what we really have is:

pasted_file (585×340 px, 39 KB)

IMO there's value in distinguishing at a glance "master is completely broken" vs "master is partially broken".

Some ideas:

  • Use an orange X to indicate partial failures
  • Change the tooltip to display more information e.g. "3/5 passed"
  • Display a result icon for each build in the column e.g. in this case there would be 4 greens and a red (my favorite solution)

Related Objects

Event Timeline

swisspol created this task.Mar 11 2016, 9:49 PM
chad added projects: Diffusion, Harbormaster.Mar 12 2016, 12:47 AM
eadler added a project: Restricted Project.Aug 5 2016, 4:45 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 4:45 PM
epriestley mentioned this in T13108: Plans: 2018 Week 12 Bonus Content.Mar 20 2018, 5:03 PM
epriestley closed this task as Wontfix.Aug 27 2018, 10:14 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

I expect to add flags like "this doesn't block undrafting" and "this build doesn't matter" soon, and then possibly refine those. I'd consider revisiting this after those deploy, but am not excited about formalizing the idea of "only some of your tests failed so it's okay" or adding a check for each build (since this won't scale very far). The tooltip is reasonable but I'll just turn that into a note on T13088.

epriestley mentioned this in T13088: Plans: Harbormaster UI usability and interconnectedness.Aug 27 2018, 10:15 PM
Phabricator · Built by Phacility