Page MenuHomePhabricator

Report partially failed builds better in Diffusion history
Closed, WontfixPublic

Description

It would be great to have more than a binary state to report build success in Diffusion history view:

pasted_file (365×553 px, 63 KB)

While actually what we really have is:

pasted_file (585×340 px, 39 KB)

IMO there's value in distinguishing at a glance "master is completely broken" vs "master is partially broken".

Some ideas:

  • Use an orange X to indicate partial failures
  • Change the tooltip to display more information e.g. "3/5 passed"
  • Display a result icon for each build in the column e.g. in this case there would be 4 greens and a red (my favorite solution)

Event Timeline

eadler added a project: Restricted Project.Aug 5 2016, 4:45 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

I expect to add flags like "this doesn't block undrafting" and "this build doesn't matter" soon, and then possibly refine those. I'd consider revisiting this after those deploy, but am not excited about formalizing the idea of "only some of your tests failed so it's okay" or adding a check for each build (since this won't scale very far). The tooltip is reasonable but I'll just turn that into a note on T13088.