Page MenuHomePhabricator

Add an "Restartable: If Failed" behavior to Harbormaster build plans
ClosedPublic

Authored by epriestley on Wed, Mar 6, 5:39 PM.

Details

Summary

Ref T13249. Ref T13258. In some cases, builds are not idempotent and should not be restarted casually.

If the scary part is at the very end (deploy / provision / whatever), it could be okay to restart them if they previously failed.

Also, make the "reasons why you can't restart" and "explanations of why you can't restart" logic a little more cohesive.

Test Plan
  • Tried to restart builds in various states (failed/not failed, restartable always/if failed/never, already restarted), got appropriate errors or restarts.
  • (I'm not sure the "Autoplan" error is normally reachable, since you can't edit autoplans to configure things to let you try to restart them.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Mar 6, 5:39 PM
Owners added a subscriber: Restricted Owners Package.Wed, Mar 6, 5:39 PM
epriestley requested review of this revision.Wed, Mar 6, 5:41 PM
amckinley accepted this revision.Thu, Mar 7, 10:10 PM
This revision is now accepted and ready to land.Thu, Mar 7, 10:10 PM
This revision was automatically updated to reflect the committed changes.