Page MenuHomePhabricator

Move the "container updated" message for Buildables that build Diffs outside of the transaction
ClosedPublic

Authored by epriestley on Thu, Nov 15, 12:10 AM.

Details

Summary

Ref T13216. See PHI970. Ref T13054. See some discussion in T13216.

When a Harbormaster Buildable object is first created for a Diff, it has no containerPHID since the revision has not yet been created.

We later (after creating a revision) send the Buildable a message telling it that we've added a container and it should re-link the container object.

Currently, we send this message in applyExternalEffects(), which runs inside the Differential transaction. If Harbormaster races quickly enough, it can read the Diff object before the transaction commits, and not see the container update.

Add a didCommitTransaction() callback after the transactions commit, then move the message code there instead.

Test Plan
  • See T13216 for substantial evidence that this change is on the right track.
  • Before change: added sleep(15), reproduced the issue reliably.
  • After change: unable to reproduce issue even with sleep(15) (the containerPHID always populates correctly).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 15, 12:10 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Nov 15, 12:11 AM
Harbormaster failed remote builds in B21150: Diff 47301!
epriestley requested review of this revision.Thu, Nov 15, 12:20 AM

Stacked on qsprintf() changes.

(This also has a couple of unrelated qsprintf() changes: they reproduce by visiting the Daemon console and the changes cleared the warnings.)

amckinley accepted this revision.Fri, Nov 16, 7:20 PM
This revision is now accepted and ready to land.Fri, Nov 16, 7:20 PM
This revision was automatically updated to reflect the committed changes.