Page MenuHomePhabricator

Make the new Build Plan behavior "Restartable" work
ClosedPublic

Authored by epriestley on Feb 28 2019, 8:05 PM.
Tags
None
Referenced Files
F18820267: D20230.diff
Wed, Oct 22, 1:42 PM
F18819789: D20230.id.diff
Wed, Oct 22, 9:36 AM
F18812124: D20230.id48337.diff
Mon, Oct 20, 7:09 AM
F18808361: D20230.id.diff
Sun, Oct 19, 6:07 AM
F18798710: D20230.diff
Fri, Oct 17, 7:59 AM
F18733916: D20230.id.diff
Tue, Sep 30, 10:44 PM
F18581431: D20230.id.diff
Sep 11 2025, 6:09 AM
F18469105: D20230.diff
Sep 2 2025, 4:22 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Implements the "Restartable" behavior, to control whether a build may be restarted or not.

This is fairly straightforward because there are already other existing reasons that a build may not be able to be restarted.

Test Plan

Restarted a build. Marked it as not restartable, saw "Restart" action become disabled. Tried to restart it anyway, got a useful error message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 8:05 PM

Does anyone want an option for "only allow builds that have failed to be restarted"? For cases where builds are idempotent except for a final irrevocable step like "find servers running any version of the code != this version and kill them"?

This revision is now accepted and ready to land.Mar 5 2019, 7:47 PM

I haven't seen any of that so far, but it seems pretty reasonable to me. Maybe I'll just add it unless I can come up with some reason why it's secretly bad in the time it takes to implement.

This revision was automatically updated to reflect the committed changes.