Page MenuHomePhabricator

Make the new Build Plan behavior "Restartable" work

Authored by epriestley on Feb 28 2019, 8:05 PM.



Ref T13258. Implements the "Restartable" behavior, to control whether a build may be restarted or not.

This is fairly straightforward because there are already other existing reasons that a build may not be able to be restarted.

Test Plan

Restarted a build. Marked it as not restartable, saw "Restart" action become disabled. Tried to restart it anyway, got a useful error message.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 28 2019, 8:05 PM
Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 8:05 PM
epriestley requested review of this revision.Feb 28 2019, 8:07 PM
amckinley accepted this revision.Mar 5 2019, 7:47 PM

Does anyone want an option for "only allow builds that have failed to be restarted"? For cases where builds are idempotent except for a final irrevocable step like "find servers running any version of the code != this version and kill them"?

This revision is now accepted and ready to land.Mar 5 2019, 7:47 PM

I haven't seen any of that so far, but it seems pretty reasonable to me. Maybe I'll just add it unless I can come up with some reason why it's secretly bad in the time it takes to implement.

This revision was automatically updated to reflect the committed changes.