Ref T13258. Implements the "Restartable" behavior, to control whether a build may be restarted or not.
This is fairly straightforward because there are already other existing reasons that a build may not be able to be restarted.
Differential D20230
Make the new Build Plan behavior "Restartable" work epriestley on Feb 28 2019, 8:05 PM. Authored by Tags None Referenced Files
Subscribers
Details Ref T13258. Implements the "Restartable" behavior, to control whether a build may be restarted or not. This is fairly straightforward because there are already other existing reasons that a build may not be able to be restarted. Restarted a build. Marked it as not restartable, saw "Restart" action become disabled. Tried to restart it anyway, got a useful error message.
Diff Detail
Event TimelineComment Actions Does anyone want an option for "only allow builds that have failed to be restarted"? For cases where builds are idempotent except for a final irrevocable step like "find servers running any version of the code != this version and kill them"? Comment Actions I haven't seen any of that so far, but it seems pretty reasonable to me. Maybe I'll just add it unless I can come up with some reason why it's secretly bad in the time it takes to implement. |