Page MenuHomePhabricator

Move Harbormaster Build Plans to modular transactions
ClosedPublic

Authored by epriestley on Feb 26 2019, 1:17 PM.

Details

Summary

Depends on D20216. Ref T13258. Bland infrastructure update to prepare for bigger things.

Test Plan

Created and edited a build plan.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 26 2019, 1:17 PM
Owners added a subscriber: Restricted Owners Package.Feb 26 2019, 1:17 PM
epriestley added inline comments.Feb 26 2019, 1:18 PM
src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php
44

function getColor() { ... return parent::getIcon(); } as an interesting implementation choice.

epriestley requested review of this revision.Feb 26 2019, 1:19 PM
amckinley accepted this revision.Feb 26 2019, 3:59 PM
This revision is now accepted and ready to land.Feb 26 2019, 3:59 PM
This revision was automatically updated to reflect the committed changes.