Page MenuHomePhabricator
Differential D20217

Move Harbormaster Build Plans to modular transactions
ClosedPublic
Actions

Authored by epriestley on Feb 26 2019, 1:17 PM.
Tags
None
Referenced Files
F15437398: D20217.id48278.diff
Tue, Mar 25, 7:12 PM
F15435406: D20217.diff
Tue, Mar 25, 8:04 AM
F15396278: D20217.id.diff
Sun, Mar 16, 1:10 PM
Unknown Object (File)
Thu, Feb 27, 10:52 PM
Unknown Object (File)
Feb 14 2025, 6:44 AM
Unknown Object (File)
Feb 14 2025, 6:44 AM
Unknown Object (File)
Feb 14 2025, 6:44 AM
Unknown Object (File)
Feb 14 2025, 6:44 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
amckinley
Maniphest Tasks
T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc)
Commits
rPf6ed873f1728: Move Harbormaster Build Plans to modular transactions
Summary

Depends on D20216. Ref T13258. Bland infrastructure update to prepare for bigger things.

Test Plan

Created and edited a build plan.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 26 2019, 1:17 PM
Owners added a subscriber: Restricted Owners Package.Feb 26 2019, 1:17 PM
epriestley added inline comments.Feb 26 2019, 1:18 PM
src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php
44

function getColor() { ... return parent::getIcon(); } as an interesting implementation choice.

Harbormaster completed remote builds in B22128: Diff 48266.Feb 26 2019, 1:19 PM
epriestley requested review of this revision.Feb 26 2019, 1:19 PM
epriestley added a child revision: D20218: Provide "harbormaster.buildplan.edit" in the API.Feb 26 2019, 1:23 PM
amckinley accepted this revision.Feb 26 2019, 3:59 PM
This revision is now accepted and ready to land.Feb 26 2019, 3:59 PM
Closed by commit rPf6ed873f1728: Move Harbormaster Build Plans to modular transactions (authored by epriestley). · Explain WhyFeb 28 2019, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48278

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanDisableController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/plan/HarbormasterBuildPlanNameTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/plan/HarbormasterBuildPlanStatusTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/plan/HarbormasterBuildPlanTransactionType.php

Loading...
Phabricator · Built by Phacility