Page MenuHomePhabricator

Implement Build Plan "Hold Drafts" behavior
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:12 PM.
Tags
None
Referenced Files
F18818264: D20232.diff
Tue, Oct 21, 10:42 PM
F18808228: D20232.id.diff
Sun, Oct 19, 5:38 AM
F18764904: D20232.diff
Tue, Oct 7, 8:30 AM
F18755590: D20232.id48338.diff
Sun, Oct 5, 6:23 AM
F18737729: D20232.id48292.diff
Wed, Oct 1, 12:19 PM
F18733918: D20232.id.diff
Tue, Sep 30, 10:44 PM
F18703703: D20232.id.diff
Sun, Sep 28, 4:51 AM
F18629702: D20232.diff
Sep 16 2025, 9:39 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Makes the new "Hold Drafts" behavior actually work.

Test Plan
  • Created a build plan which does "Make HTTP Request" somewhere random and then waits for a message.
  • Created a Herald rule which "Always" runs this plan.
  • Created revisions, loaded them, then sent their build targets a "fail" message a short time later.
    • With "Always": Current behavior. Revision was held as a draft while building, and returned to me for changes when the build failed.
    • With "If Building": Revision was held as a draft while building, but promoted once the build failed.
    • With "Never": Revision promoted immediately, ignoring the build completely.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:12 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:49 PM
This revision was automatically updated to reflect the committed changes.