Page MenuHomePhabricator

Implement Build Plan "Hold Drafts" behavior
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:12 PM.
Tags
None
Referenced Files
F15455198: D20232.id48338.diff
Sat, Mar 29, 10:48 PM
F15427877: D20232.diff
Sun, Mar 23, 4:37 PM
F15420670: D20232.id48292.diff
Fri, Mar 21, 3:59 PM
F15416833: D20232.id48338.diff
Thu, Mar 20, 1:53 PM
F15405234: D20232.diff
Tue, Mar 18, 10:50 AM
F15283400: D20232.id.diff
Mar 4 2025, 7:10 AM
Unknown Object (File)
Feb 20 2025, 4:52 PM
Unknown Object (File)
Feb 14 2025, 7:04 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13258. Makes the new "Hold Drafts" behavior actually work.

Test Plan
  • Created a build plan which does "Make HTTP Request" somewhere random and then waits for a message.
  • Created a Herald rule which "Always" runs this plan.
  • Created revisions, loaded them, then sent their build targets a "fail" message a short time later.
    • With "Always": Current behavior. Revision was held as a draft while building, and returned to me for changes when the build failed.
    • With "If Building": Revision was held as a draft while building, but promoted once the build failed.
    • With "Never": Revision promoted immediately, ignoring the build completely.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:12 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:49 PM
This revision was automatically updated to reflect the committed changes.