Page MenuHomePhabricator

Implement Build Plan "Hold Drafts" behavior
ClosedPublic

Authored by epriestley on Feb 28 2019, 9:12 PM.

Details

Summary

Ref T13258. Makes the new "Hold Drafts" behavior actually work.

Test Plan
  • Created a build plan which does "Make HTTP Request" somewhere random and then waits for a message.
  • Created a Herald rule which "Always" runs this plan.
  • Created revisions, loaded them, then sent their build targets a "fail" message a short time later.
    • With "Always": Current behavior. Revision was held as a draft while building, and returned to me for changes when the build failed.
    • With "If Building": Revision was held as a draft while building, but promoted once the build failed.
    • With "Never": Revision promoted immediately, ignoring the build completely.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 28 2019, 9:12 PM
Owners added a subscriber: Restricted Owners Package.Feb 28 2019, 9:12 PM
epriestley requested review of this revision.Feb 28 2019, 9:14 PM
amckinley accepted this revision.Mar 5 2019, 7:49 PM
This revision is now accepted and ready to land.Mar 5 2019, 7:49 PM
This revision was automatically updated to reflect the committed changes.