Page MenuHomePhabricator

AuditProject
ActivePublic

Recent Activity

Sep 2 2019

epriestley created T13402: Owner audit flag got flipped in update?.
Sep 2 2019, 3:06 PM · Audit

May 17 2019

epriestley closed T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Resolved.

This stuff is largely resolved, but survived by a few remaining issues in T13290.

May 17 2019, 2:18 PM · Diffusion, Harbormaster, Herald, Audit

May 3 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20491: Hide the "added a commit/revision" stories from feed and mail.
May 3 2019, 3:00 PM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to Next on the Herald board.
May 3 2019, 5:11 AM · Diffusion, Harbormaster, Herald, Audit
epriestley closed T11118: Herald Rule to assign Owners to an Audit as Wontfix.

Owners review and auditing now have 6 and 4 options respectively, which I think cover most of the needs here. They don't handle everything (e.g. excluding merge commits) but think we're mostly in a reasonable place now and don't have any current plans to add additional shorthands.

May 3 2019, 4:39 AM · Restricted Project, Audit, Herald, Owners, Feature Request

May 1 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20490: Fix the direction of the commit/revision edge.
May 1 2019, 3:47 PM · Diffusion, Harbormaster, Herald, Audit
epriestley updated the task description for T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.
May 1 2019, 3:45 PM · Diffusion, Harbormaster, Herald, Audit

Apr 23 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20470: Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery).
Apr 23 2019, 6:35 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20469: Unify code for parsing "Reverts X" magic, and when something "reverts <hash>", also revert associated revisions.
Apr 23 2019, 6:05 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

PHI1159 would like build failures exposed to Herald to trigger audits. See also PHI953. See also PHI901.

Apr 23 2019, 1:39 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

In PHI1008, when commit X reverts commit Y, we don't write a revert edge between X and revisions associated with Y. We should.

Apr 23 2019, 1:32 PM · Diffusion, Harbormaster, Herald, Audit

Apr 22 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20463: Move "update related object after commit" to a separate worker in the task queue.
Apr 22 2019, 10:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20462: When applying transactions, acquire a read lock sooner.
Apr 22 2019, 10:26 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20461: Remove all remaining readers and writers for TABLE_COMMIT.
Apr 22 2019, 7:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table.
Apr 22 2019, 7:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()".
Apr 22 2019, 7:06 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20457: Move BlameController away from ancient "TABLE_COMMIT".
Apr 22 2019, 6:47 PM · Diffusion, Harbormaster, Herald, Audit

Apr 16 2019

epriestley updated the task description for T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.
Apr 16 2019, 5:58 PM · Diffusion, Harbormaster, Herald, Audit

Apr 15 2019

epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to "Track Only" on the Diffusion board.
Apr 15 2019, 3:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a project to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Diffusion.
Apr 15 2019, 3:34 PM · Diffusion, Harbormaster, Herald, Audit

Apr 14 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Apr 14 2019, 5:51 PM · Diffusion, Harbormaster, Herald, Audit

Apr 11 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20395: Remove very old "vsDiff" data from commit update / diff extraction pipeline.
Apr 11 2019, 1:12 PM · Diffusion, Harbormaster, Herald, Audit

Apr 10 2019

epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

Internally, see PHI1165 for nine pages of me complaining about this.

Apr 10 2019, 11:40 PM · Diffusion, Harbormaster, Herald, Audit

Apr 2 2019

epriestley triaged T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Normal priority.
Apr 2 2019, 1:44 PM · Diffusion, Harbormaster, Herald, Audit

Jan 17 2019

avivey changed the visibility for T1394: Support creating audits with inline comments through the API.
Jan 17 2019, 7:17 PM · Conduit, Harbormaster, Audit

Sep 10 2018

GoogleLegacy added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.
Sep 10 2018, 9:48 AM · Differential, Audit

Nov 10 2017

epriestley closed T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query as Resolved.

This doesn't seem to have caused any issues.

Nov 10 2017, 3:20 PM · Customer Impact, Restricted Project, Performance, Audit

Oct 23 2017

epriestley added a revision to T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query: D18727: Simplify UNION/ORDER query construction in DifferentialRevisionQuery.
Oct 23 2017, 10:01 PM · Customer Impact, Restricted Project, Performance, Audit

Oct 20 2017

epriestley added a revision to T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query: D18722: Rewrite CommitQuery to use UNION for performance.
Oct 20 2017, 10:42 PM · Customer Impact, Restricted Project, Performance, Audit

Aug 25 2017

epriestley closed T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges, a subtask of T1394: Support creating audits with inline comments through the API, as Resolved.
Aug 25 2017, 2:29 PM · Conduit, Harbormaster, Audit

Jul 9 2017

chad removed the image for Audit.
Jul 9 2017, 7:21 PM

Jun 15 2017

axelb added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

Okay thanks for your answer. So if i used audit.Query to get (for example) audit statuses etc.. I have to wait that diffusion.commit.search implements all functionnalities?

Jun 15 2017, 12:27 PM · Audit, Diffusion, Conduit, Bug Report
epriestley added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

No.

Jun 15 2017, 12:20 PM · Audit, Diffusion, Conduit, Bug Report
axelb added a comment to T12117: Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'.

Is it possible to unfreeze audit.query if diffusion.commit.search is not returning enough informations to replace audit.Query?

Jun 15 2017, 12:14 PM · Audit, Diffusion, Conduit, Bug Report

May 29 2017

epriestley closed T12770: The "need" saved query of Diffusion not upgraded as Resolved.

I think I didn't migrate this since there was no direct analog -- my memory's a little fuzzy, but I think the old query had some bugs / weird behaviors / general differences and there's no exact way to represent it after the change (and even if there was, the newer version -- with bucketing -- is probably way better for most users, so it's good to upgrade anyway). I figured it was better to just break it in an obvious way than subtly change it, which could be more confusing, I think.

May 29 2017, 2:00 PM · Dashboards, Audit, Bug Report

May 28 2017

chad added projects to T12770: The "need" saved query of Diffusion not upgraded : Audit, Dashboards.
May 28 2017, 8:22 PM · Dashboards, Audit, Bug Report
chad merged T12769: Applications page shows Diffusion on admin into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
May 28 2017, 2:58 AM · Audit, Diffusion, Wikimedia

May 21 2017

epriestley closed T5815: Make it easier to work through a queue of stuff as Resolved.

I'm going to close this; there are two possible followups -- each of which is better focused on a more specific set of problems -- but I'm not merging it into either one since I think there's a lot of general ambiguity about problems and use cases here. If you're interested in this, feel free to follow either or both.

May 21 2017, 2:00 PM · Restricted Project, Maniphest, Differential, Audit
epriestley edited subtasks for T5815: Make it easier to work through a queue of stuff, added: T12740: Nuance: As a Bulk Editor, when edits require human decisions; removed: T9132: Build an ApplicationEditor abstraction, T8783: Unprototype Nuance (v1).
May 21 2017, 12:50 PM · Restricted Project, Maniphest, Differential, Audit

May 14 2017

epriestley closed T12679: Fix trivial errors in various View controllers as Resolved by committing rP11c5638832c2: Fix some error log issues with uninitialized commit/revision lists.
May 14 2017, 8:28 PM · Differential, Audit, Restricted Project, Customer Impact

May 12 2017

epriestley added a revision to T12679: Fix trivial errors in various View controllers: D17872: Fix some error log issues with uninitialized commit/revision lists.
May 12 2017, 6:07 PM · Differential, Audit, Restricted Project, Customer Impact
epriestley claimed T12679: Fix trivial errors in various View controllers.
May 12 2017, 5:57 PM · Differential, Audit, Restricted Project, Customer Impact

May 5 2017

epriestley created T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query.
May 5 2017, 6:30 PM · Customer Impact, Restricted Project, Performance, Audit
epriestley added projects to T12679: Fix trivial errors in various View controllers: Audit, Differential.
May 5 2017, 6:21 PM · Differential, Audit, Restricted Project, Customer Impact

Apr 21 2017

epriestley merged task T6273: Inline comments do not support editing (Pholio, Differential, Diffusion) into T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.
Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a comment to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).

I'm just going to merge this into T11401, at least for the moment. That may eventually split out into application-specific tasks when it gets underway.

Apr 21 2017, 12:04 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio

Apr 7 2017

epriestley closed T12272: Allow users to accept on behalf of packages they control a containing package for as Resolved.

I may still do a bit of a UI touchup pass here but this can follow up in T10967, since there's still some other work to be done there (like purging the old double writes).

Apr 7 2017, 12:52 PM · Owners, Audit, Restricted Project, Differential
epriestley closed T12272: Allow users to accept on behalf of packages they control a containing package for, a subtask of T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for, as Resolved.
Apr 7 2017, 12:52 PM · Audit, Restricted Project, Differential

Apr 6 2017

lvital added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Just tested, works great. Thanks for the quick fix!

Apr 6 2017, 10:13 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

I think things should work now, let me know if you're still seeing issues. Thanks for the report!

Apr 6 2017, 10:03 PM · Owners, Audit, Restricted Project, Differential