Page MenuHomePhabricator
Create Task
Maniphest T12117

Conduit API method audit.query fails with 'Undefined class constant CONCERN_ACCEPTED'
Closed, ResolvedPublic
Actions

Description

It can be reproduced on this current phabricator install too: https://secure.phabricator.com/conduit/method/audit.query/ and click "Call Method":

>>> UNRECOVERABLE FATAL ERROR <<<

Undefined class constant &#039;CONCERN_ACCEPTED&#039;

/core/lib/phabricator/src/applications/audit/conduit/AuditQueryConduitAPIMethod.php:78


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

version info:

phabricator

0426ce73f0e63f1900f1cc285cfa1465ea72317e (Fri, Jan 13) (branched from 7276af6a81f49bbdc14ace064aab50afbeb79cfc on origin)

arcanist

9503b941cc02be637d967bb50cfb25f852e071e4 (Sat, Jan 7) (branched from ade25facfdf22aed1c1e20fed3e58e60c0be3c2b on origin)

phutil

10963f771f118baa338aacd3172aaede695cde62 (Fri, Jan 13) (branched from 9d85dfab0f532d50c2343719e92d574a4827341b on origin)

Revisions and Commits

rP Phabricator
D17218rP0513a242352e Fix a bad constant in "audit.query"

Related Objects

Event Timeline

jpraet created this task.Jan 18 2017, 10:49 AM
Herald added a subscriber: eadler. · View Herald TranscriptJan 18 2017, 10:49 AM
epriestley added a revision: D17218: Fix a bad constant in "audit.query".Jan 18 2017, 1:59 PM
epriestley claimed this task.Jan 18 2017, 2:07 PM
epriestley triaged this task as Normal priority.
epriestley added projects: Diffusion, Audit.
epriestley moved this task from Backlog to EditEngine on the Audit board.

Thanks, D17218 should fix this.

Note that this method is now frozen and diffusion.commit.search is the recommended method, although it may not yet return enough information to replace audit.query.

In particular, audits may gain new states soon (T2393) which audit.query may be unable to interact with.

epriestley closed this task as Resolved by committing rP0513a242352e: Fix a bad constant in "audit.query".Jan 18 2017, 3:45 PM
epriestley added a commit: rP0513a242352e: Fix a bad constant in "audit.query".
epriestley mentioned this in T12134: Develop a Nuance-based Phabricator reporting/support flow.Jan 20 2017, 5:32 PM
axelb added a subscriber: axelb.Jun 15 2017, 12:14 PM

Is it possible to unfreeze audit.query if diffusion.commit.search is not returning enough informations to replace audit.Query?

epriestley added a comment.Jun 15 2017, 12:20 PM

No.

axelb added a comment.Jun 15 2017, 12:27 PM

Okay thanks for your answer. So if i used audit.Query to get (for example) audit statuses etc.. I have to wait that diffusion.commit.search implements all functionnalities?

Thanks for your time. I'm trying to use Custom Query Constraints to get audits statuses but it's harder than with audit.query :)

Phabricator · Built by Phacility