Page MenuHomePhabricator

Rewrite CommitQuery to use UNION for performance
ClosedPublic

Authored by epriestley on Oct 20 2017, 10:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:40 PM
Unknown Object (File)
Wed, Nov 27, 11:23 AM
Unknown Object (File)
Nov 18 2024, 7:55 PM
Unknown Object (File)
Oct 27 2024, 7:12 AM
Unknown Object (File)
Oct 27 2024, 7:11 AM
Unknown Object (File)
Oct 27 2024, 7:11 AM
Unknown Object (File)
Oct 27 2024, 6:54 AM
Unknown Object (File)
Oct 20 2024, 1:22 AM
Subscribers
None

Details

Summary

Ref T12680. See PHI167. See that task for discussion.

Rewrite DiffusionCommitQuery to work more like DifferentialRevisionQuery, and use a UNION to find "all revisions you need to audit OR respond to".

I tried to get this working a little more cleanly than RevisionQuery does, and can probably simplify that now.

Test Plan

Poked at the UI locally without hitting any apparent issues, but my local data is pretty garbage at this point. I'll take a look at how the query plans work on secure.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable