Page MenuHomePhabricator
Create Task
Maniphest T12770

The "need" saved query of Diffusion not upgraded
Closed, ResolvedPublic
Actions

Description

I had https://secure.phabricator.com/w/changelog/2016.26/ version and upgraded to https://secure.phabricator.com/w/changelog/2017.20/. After upgrade I saw this error on one of the Dashboard panels:

Exception: Query "need" is unknown to application search engine "PhabricatorCommitSearchEngine"!

Turned out, that default saved query list returned by \PhabricatorCommitSearchEngine::buildSavedQueryFromBuiltin method was greatly reduced and on affected panel the need query was used, which is no longer present.

Built-in saved queries before upgrade:

  • all
  • open
  • need
  • authored
  • problem

Built-in saved queries after upgrade:

  • all
  • active
  • authored
  • audited

I guess the open, need and problem queries should be migrated to use active query or removed saved queries could be brought back.

Event Timeline

aik099 created this task.May 28 2017, 2:58 PM
aik099 updated the task description. (Show Details)
chad added a subscriber: chad.May 28 2017, 3:26 PM

Can you just pick a new query and fix the panel? My thought is if only 1 person in 12 months is affected, it's going to be faster for you to fix the panel than for us to find resources to build an old image and test migrations.

aik099 added a comment.May 28 2017, 5:45 PM

Can you just pick a new query and fix the panel?

Sure. That is how I solved it currently.

My thought is if only 1 person in 12 months is affected, it's going to be faster for you to fix the panel than for us to find resources to build an old image and test migrations.

Makes sense. Thank you.

chad added a comment.May 28 2017, 8:22 PM

Thanks! We'll keep this around and see if a migration is needed. Sounds like mostly a dashboards issue.

chad added projects: Audit, Dashboards.May 28 2017, 8:22 PM
epriestley closed this task as Resolved.May 29 2017, 2:00 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

I think I didn't migrate this since there was no direct analog -- my memory's a little fuzzy, but I think the old query had some bugs / weird behaviors / general differences and there's no exact way to represent it after the change (and even if there was, the newer version -- with bucketing -- is probably way better for most users, so it's good to upgrade anyway). I figured it was better to just break it in an obvious way than subtly change it, which could be more confusing, I think.

I'm going to presume we're in good shape here based on the low report rate. We could make it fail in an even-more-obvious way (e.g., with a message that says "this query is obsolete, upgrade it") if we do encounter further issues.

Phabricator · Built by Phacility