Page MenuHomePhabricator

Fix some error log issues with uninitialized commit/revision lists
ClosedPublic

Authored by epriestley on May 12 2017, 6:07 PM.
Tags
None
Referenced Files
F13098583: D17872.id42985.diff
Fri, Apr 26, 8:20 AM
Unknown Object (File)
Wed, Apr 24, 10:17 PM
Unknown Object (File)
Sun, Mar 31, 10:58 PM
Unknown Object (File)
Wed, Mar 27, 9:16 PM
Unknown Object (File)
Mar 15 2024, 10:07 PM
Unknown Object (File)
Feb 23 2024, 4:53 AM
Unknown Object (File)
Feb 6 2024, 12:55 AM
Unknown Object (File)
Jan 24 2024, 3:22 AM
Subscribers
None

Details

Summary

Fixes T12679. Reproduction steps appear to be:

  • As a logged-out user, view revision list or commit list.
  • Enable bucketing by action required.
  • Before patch: foreach (null as ...) causes error spew.
  • After patch: foreach (array() as ...) works great.
Test Plan
  • Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
  • After patches, no more errors in the log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 12 2017, 6:57 PM
This revision was automatically updated to reflect the committed changes.