Page MenuHomePhabricator

Fix some error log issues with uninitialized commit/revision lists
ClosedPublic

Authored by epriestley on May 12 2017, 6:07 PM.
Tags
None
Referenced Files
F15332835: D17872.id42985.diff
Fri, Mar 7, 8:53 PM
Unknown Object (File)
Sun, Mar 2, 5:53 AM
Unknown Object (File)
Jan 26 2025, 8:36 PM
Unknown Object (File)
Jan 21 2025, 12:42 PM
Unknown Object (File)
Jan 17 2025, 6:05 PM
Unknown Object (File)
Jan 11 2025, 1:08 AM
Unknown Object (File)
Jan 10 2025, 10:26 PM
Unknown Object (File)
Dec 30 2024, 12:02 AM
Subscribers
None

Details

Summary

Fixes T12679. Reproduction steps appear to be:

  • As a logged-out user, view revision list or commit list.
  • Enable bucketing by action required.
  • Before patch: foreach (null as ...) causes error spew.
  • After patch: foreach (array() as ...) works great.
Test Plan
  • Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
  • After patches, no more errors in the log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 12 2017, 6:57 PM
This revision was automatically updated to reflect the committed changes.