HomePhabricator

Fix some error log issues with uninitialized commit/revision lists

Description

Fix some error log issues with uninitialized commit/revision lists

Summary:
Fixes T12679. Reproduction steps appear to be:

  • As a logged-out user, view revision list or commit list.
  • Enable bucketing by action required.
  • Before patch: foreach (null as ...) causes error spew.
  • After patch: foreach (array() as ...) works great.

Test Plan:

  • Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
  • After patches, no more errors in the log.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12679

Differential Revision: https://secure.phabricator.com/D17872

Details

Provenance
epriestleyAuthored on May 12 2017, 6:05 PM
epriestleyPushed on May 14 2017, 8:28 PM
Reviewer
chad
Differential Revision
D17872: Fix some error log issues with uninitialized commit/revision lists
Parents
rPdb631b423f41: Add basic Watching filter to /projects/
Branches
Unknown
Tags
Unknown
Tasks
T12679: Fix trivial errors in various View controllers
Build Status
Buildable 16917
Build 22604: Run Core Tests