Page MenuHomePhabricator
Feed All Stories

Jan 2 2016

epriestley updated subscribers of T8996: Move Badge awards to be an actual object, not an edge.

We want to be able to store metadata about badge awards (like who awarded a badge, when, why, a little commemorative note, etc) but currently can not because they use a very simple storage mechanism (edges). For example, see T8940.

Jan 2 2016, 12:30 AM · Badges (v0)
epriestley updated subscribers of T8941: Badges don't show in certain Timeline conditions.

Here's the remaining bug: when a transaction group mixes a comment and another action, badges are not shown, even though we render the profile image in large size and have space to show them. Here's a screenshot of the bug from this task:

Jan 2 2016, 12:26 AM · Badges (v0)
epriestley moved T8940: Annotate badges with awarder, date from v1 to v0 on the Badges board.
Jan 2 2016, 12:23 AM · Badges (v0)
epriestley moved T8996: Move Badge awards to be an actual object, not an edge from v1 to v0 on the Badges board.
Jan 2 2016, 12:23 AM · Badges (v0)
epriestley renamed T8996: Move Badge awards to be an actual object, not an edge from Move Badges to be an actual object, not an edge to Move Badge awards to be an actual object, not an edge.
Jan 2 2016, 12:23 AM · Badges (v0)
epriestley moved T6526: Implement "Badges" or "Medals", for annotating special users from Backlog to v0 on the Badges board.
Jan 2 2016, 12:21 AM · Restricted Project, Badges (v0), People
epriestley triaged T9010: Allow badges to have any Font Awesome icon as Wishlist priority.
Jan 2 2016, 12:21 AM · Badges
epriestley moved T9010: Allow badges to have any Font Awesome icon from Backlog to Far Future on the Badges board.
Jan 2 2016, 12:21 AM · Badges
epriestley edited projects for T9926: SVN Commit fails, hard to debug, added: Bug Report (Needs Information); removed Bug Report.
Jan 2 2016, 12:18 AM · Bug Report (Needs Information), Subversion, Diffusion
epriestley triaged T10050: Differential-to-Asana integration, like with JIRA as Wishlist priority.

To set expectations, this is a very low priority for the upstream. Most prior Asana/JIRA work in this vein has been for paying customers (see Prioritization).

Jan 2 2016, 12:12 AM · Doorkeeper, Differential, Asana, Feature Request
epriestley added a comment to T10061: Split the view policy into "space" and "visible to" line in forms.

after two users abused this to hide important tasks from developers

Jan 2 2016, 12:03 AM · Maniphest, Spaces, Feature Request

Jan 1 2016

epriestley closed T5434: Option --pull-rebase to `arc feature` as Wontfix.

You can use arc alias to define some arc pull-then-feature.

Jan 1 2016, 11:52 PM · Arcanist
epriestley created T10078: Implement global readthrough cache pools.
Jan 1 2016, 1:26 PM · Restricted Project, Infrastructure, Performance
epriestley added a revision to T10077: Reduce the cost of building the "Quick Create" menu: Unknown Object (Differential Revision).
Jan 1 2016, 1:16 PM · Infrastructure, Performance
epriestley added a revision to T8918: Header shows number of notifications and various other controls on the 2FA auth screen: Unknown Object (Differential Revision).
Jan 1 2016, 1:16 PM · Security, Auth
epriestley created T10077: Reduce the cost of building the "Quick Create" menu.
Jan 1 2016, 1:11 PM · Infrastructure, Performance
chad updated subscribers of T9348: No way to kick users out of a Conpherence.
Jan 1 2016, 7:53 AM · Conpherence (v4)
chad merged task T10076: Ability to add/remove rooms and participants in Conpherence Rooms. into T9348: No way to kick users out of a Conpherence.
Jan 1 2016, 7:53 AM · Feature Request
• sameep.agarwal created T10076: Ability to add/remove rooms and participants in Conpherence Rooms..
Jan 1 2016, 5:34 AM · Feature Request

Dec 31 2015

BYK added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

This is another reason for me to dislike PHP but I really appreciate the time you've taken to explain the issue in addition to a promising fix for this task. Couldn't have asked for a better new year's gift :)

Dec 31 2015, 10:46 PM · Git
epriestley added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

I think the fread() thing from PHP.net is just the user being clueless. He's opening a connection to an HTTP server, writing this "HTTP request":

Dec 31 2015, 10:20 PM · Git
epriestley added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

When you have a chance, can anyone else who was hitting this update libphutil/ to rPHU5afd76 and see if it still reproduces?

Dec 31 2015, 10:05 PM · Git
avi updated Q258: Documentation for Drydock working copy git/ssh clone? from to Documentation for Drydock working copy git/ssh clone?.
Dec 31 2015, 10:01 PM · Drydock
epriestley added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

I'm fairly confident that D14920 will fix this. I was able to reproduce it with the "run in a loop" method, and narrow it down from there.

Dec 31 2015, 10:01 PM · Git
epriestley added a revision to T9724: "ssh-exec" sometimes hangs when git cloning larger repos : Unknown Object (Differential Revision).
Dec 31 2015, 9:59 PM · Git
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

But maybe my memory is poor and Workboard cards are more custom than I remember.

Dec 31 2015, 4:18 PM · Projects, Wikimedia, Workboards
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

It shouldn't require any design, they should just work like they do in Maniphest normally, but without the board's main project. ie, if you're in Differential, and you had Differential and Mobile tagged, just show the mobile tag.

Dec 31 2015, 4:16 PM · Projects, Wikimedia, Workboards
dukeh3 added a comment to T4548: Support "Mylyn" Eclipse plugin.

I have started to make a plugin, so far its pre aplha and its a shameless copy of the the Track plugin, so far not very useful.

Dec 31 2015, 4:03 PM · Feature Request, Maniphest
epriestley added a revision to T5819: Allow project colors to be relabeled: Unknown Object (Differential Revision).
Dec 31 2015, 3:11 PM · Projects
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 31 2015, 3:11 PM · Projects (v3)
joshuaspence added a comment to T10004: ApplicationEditor Errata.

Yeah, I can't reproduce it anymore either. I definitely saw it earlier today on a different install (which is up-to-date within a couple of hours) but I don't know what was special then.

Dec 31 2015, 2:21 PM · ApplicationEditor
joshuaspence reopened T10004: ApplicationEditor Errata as "Open".
Dec 31 2015, 2:20 PM · ApplicationEditor
joshuaspence closed T10004: ApplicationEditor Errata as Resolved.

This is a test.

Dec 31 2015, 2:20 PM · ApplicationEditor
joshuaspence changed the status of T10075: Test from Resolved to Spite.
Dec 31 2015, 2:14 PM
joshuaspence closed T10075: Test as Resolved.

Jwjsjs

Dec 31 2015, 2:14 PM
joshuaspence reopened T10075: Test as "Open".

Wjsjsjs

Dec 31 2015, 2:13 PM
joshuaspence closed T10075: Test as Resolved.

Sjsjdjr

Dec 31 2015, 2:13 PM
joshuaspence created T10075: Test.
Dec 31 2015, 2:13 PM
epriestley added a comment to T10004: ApplicationEditor Errata.

I can't reproduce that. Here's what I did:

Dec 31 2015, 2:04 PM · ApplicationEditor
epriestley added a comment to T9430: "Needs Audit" no longer excludes author commits.

Please see Planning. Thanks!

Dec 31 2015, 2:00 PM · Restricted Project, Restricted Project, Audit
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Dec 31 2015, 1:59 PM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Dec 31 2015, 1:59 PM
epriestley closed T10074: wrong href for green "create project" button as Resolved by committing Restricted Diffusion Commit.
Dec 31 2015, 1:59 PM · Projects, Bug Report
bastianschwarz added a comment to T9430: "Needs Audit" no longer excludes author commits.

Is there any chance this is gonna be fixed soon or is there a workaround?

Dec 31 2015, 10:49 AM · Restricted Project, Restricted Project, Audit
joshuaspence added a project to T10074: wrong href for green "create project" button: Projects.
Dec 31 2015, 10:39 AM · Projects, Bug Report
stevex awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
Dec 31 2015, 10:27 AM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
johnny-bit added a comment to T4863: Allow Workboard Cards to be customized for display.

If possible: display both. if not possible - many ways:

Dec 31 2015, 8:35 AM · Projects, Workboards, Wikimedia
zhuangya added a comment to T10074: wrong href for green "create project" button.

hey guys, this is my first time commit to phabricator.

Dec 31 2015, 7:41 AM · Projects, Bug Report
joshuaspence added a comment to T7506: Resigning from a revision generates two similar transactions.

:(

Dec 31 2015, 7:41 AM · Transactions, Differential
zhuangya added a revision to T10074: wrong href for green "create project" button: Unknown Object (Differential Revision).
Dec 31 2015, 7:40 AM · Projects, Bug Report
joshuaspence added a comment to T10004: ApplicationEditor Errata.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

Dec 31 2015, 7:31 AM · ApplicationEditor
joshuaspence added a comment to T4863: Allow Workboard Cards to be customized for display.

I'm happy to send a diff over, but my design skills are quite lacking. How would.you think that the project tagd should be displayed? For example, suppose that a task is tagged with project X, Y and Z and is being viewed as a worknoard card for the board of project X. I'd say that we should show either Y or Z (as X is implied), but I'm not sure which should be preferred.

Dec 31 2015, 7:28 AM · Projects, Workboards, Wikimedia
zhuangya created T10074: wrong href for green "create project" button.
Dec 31 2015, 7:21 AM · Projects, Bug Report
chad added a project to T10071: New account e-mail invites do not allow registration on auth providers that do not allow registration: Auth.
Dec 31 2015, 7:18 AM · Auth, Bug Report
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

It should just be the default moving forward, I don't plan to introduce any special settings. Feel free to send a diff over if you like.

Dec 31 2015, 7:04 AM · Projects, Workboards, Wikimedia
joshuaspence added a comment to T4863: Allow Workboard Cards to be customized for display.

Projects displayed on workboard cards. We usually end up doing "[PROJECT] Title" as a workaround.

Dec 31 2015, 6:42 AM · Projects, Workboards, Wikimedia
chad added a comment to T4863: Allow Workboard Cards to be customized for display.

Probably not. What part do you need specifically, we're already building v3 projects.

Dec 31 2015, 6:30 AM · Projects, Workboards, Wikimedia
joshuaspence added a comment to T4863: Allow Workboard Cards to be customized for display.

Is this available for prioritization?

Dec 31 2015, 5:35 AM · Projects, Workboards, Wikimedia
Krenair added a comment to T8434: Accommodate the "Security" workflow.

I think one of the issues was people making a public task, and then deciding they should change it to security, but not having the permissions to do so?

Dec 31 2015, 1:25 AM · Wikimedia, Policy, Prioritized
epriestley added a comment to T8434: Accommodate the "Security" workflow.

Awesome, glad to hear things sound promising. Thanks for the update!

Dec 31 2015, 1:22 AM · Wikimedia, Policy, Prioritized
20after4 awarded T8092: Evaluate the viability of virtualizing Git refs in hosted repositories a Love token.
Dec 31 2015, 1:18 AM · Restricted Project, Harbormaster
20after4 added a comment to T8434: Accommodate the "Security" workflow.

@epriestley: We haven't pushed this to production but my initial impression from configuring forms on https://phab-01.wmflabs.org is that this should work pretty well. The only thing I haven't figured out is a way to easily transition a task between private & security sensitive and public. It seems that will require someone with adequate permissions to manually edit the task policies, which isn't the end of the world. We could possibly continue to use herald rules to make the transition easier, though I am more keen on the idea of totally killing off both the herald rules and the custom event listeners.

Dec 31 2015, 1:15 AM · Wikimedia, Policy, Prioritized
20after4 added a comment to T6683: provide a keyboard shortcut for expanding hidden changes.

On this specific issue, we could also make the whole yellow bar a click target for "show older".

More broadly, given that this use case is extremely narrow, I wonder if we shouldn't consider a "presentation mode" -- which could maybe do things like disable notifications (particularly if we do more chat stuff later), make UI adjustments like this, possibly engage fullscreen mode, and let other users follow along (e.g., the presenter's open pages become shared, and you "follow screen" on the presenter and get the pages they open pushed to you so you can follow along locally, and maybe the pages could be saved for meeting notes or whatever, so you can go back and find stuff).

Although we don't do meetings with projections in the upstream, it's somewhat hard for me to imagine that fumbling with this link is the worst part of presenting stuff from Phabricator.

This class of use case feels wishlisty to me, but I've seen a few similar use cases (broadly, the "presentation" use case) -- for example, T4900 describes something similar. It seems like something we could eventually improve significantly on with relatively little effort.

I'm not sure how useful things like a reviewable list of "all the things we looked at in the meeting" are (and I haven't seen other software trying to build lists like this, so maybe it's not very useful) but it's the kind of thing that seems hard in the common case but easier for us given how broadly integrated we are. I could imagine this being something that doesn't exist because it's usually hard to build, but actually works really well.

Dec 31 2015, 1:01 AM · Transactions
• DocTaxon added a comment to T6027: Way to edit which column a task is in from the task itself.
In T6027#135704, @isfs wrote:

Would it perhaps be simpler if instead of developing a "Change columns" UI, actions can be added to move columns, something more along the lines of what I mocked up for T9280, i.e. a simple action with two parameters, rather than a monster action with parameters for all existing boards?:

mock.png (400×800 px, 27 KB)

If you want to move the task on multiple boards (which I imagine is relatively, if not absolutely rare) you would just add multiple actions. The order of the actions is clear, even if not mutable.

Dec 31 2015, 12:57 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley updated subscribers of T6051: workboard drag+drop doesn't work on android (both chrome+firefox broken).
Dec 31 2015, 12:47 AM · Android, Wikimedia
epriestley merged task T10073: Cannot move tasks in workboards on mobile devices without drag and drop functionality into T6051: workboard drag+drop doesn't work on android (both chrome+firefox broken).
Dec 31 2015, 12:47 AM · Feature Request, Workboards, Android
epriestley added a comment to T10073: Cannot move tasks in workboards on mobile devices without drag and drop functionality.

Ah, thanks! I thought we had one of these floating around.

Dec 31 2015, 12:47 AM · Feature Request, Workboards, Android
aklapper added a comment to T10073: Cannot move tasks in workboards on mobile devices without drag and drop functionality.

Dup of https://secure.phabricator.com/T6051#75103 ?

Dec 31 2015, 12:45 AM · Feature Request, Workboards, Android
epriestley edited projects for T10073: Cannot move tasks in workboards on mobile devices without drag and drop functionality, added: Feature Request; removed Bug Report.
Dec 31 2015, 12:41 AM · Feature Request, Workboards, Android

Dec 30 2015

• DocTaxon created T10073: Cannot move tasks in workboards on mobile devices without drag and drop functionality.
Dec 30 2015, 11:53 PM · Feature Request, Workboards, Android
epriestley closed T10072: Arcanist Ignoring .gitignore as Invalid.
Dec 30 2015, 10:40 PM · Bug Report (Needs Information)
CodeMouse92 added a comment to T10072: Arcanist Ignoring .gitignore.

Hm, I attempted another reproduction of the issue on a clean repo, and I can't get it to happen now either. Perhaps something didn't get the memo when I untracked some old binaries in the other repos. GA and mark this as invalid, I suppose, and I'll update here if I pinpoint a problem. Thanks anyway. :\

Dec 30 2015, 10:38 PM · Bug Report (Needs Information)
epriestley added a comment to T10072: Arcanist Ignoring .gitignore.

I can't reproduce this. Here's what I did:

Dec 30 2015, 10:33 PM · Bug Report (Needs Information)
CodeMouse92 updated the task description for T10072: Arcanist Ignoring .gitignore.
Dec 30 2015, 10:32 PM · Bug Report (Needs Information)
CodeMouse92 updated the task description for T10072: Arcanist Ignoring .gitignore.
Dec 30 2015, 10:32 PM · Bug Report (Needs Information)
CodeMouse92 added a comment to T10072: Arcanist Ignoring .gitignore.

Aih, I'm having one of those days.

Dec 30 2015, 10:27 PM · Bug Report (Needs Information)
CodeMouse92 updated the task description for T10072: Arcanist Ignoring .gitignore.
Dec 30 2015, 10:27 PM · Bug Report (Needs Information)
epriestley added a comment to T10072: Arcanist Ignoring .gitignore.

Those reproduction instructions do not describe a bug. When you change a file and add it, it is expected that it will be part of any diffs or commits.

Dec 30 2015, 10:26 PM · Bug Report (Needs Information)
CodeMouse92 added a comment to T10072: Arcanist Ignoring .gitignore.

Hmm, okay, I wrote those out in list form to make it a bit more obvious. I don't have any way to try and duplicate that here.

Dec 30 2015, 10:25 PM · Bug Report (Needs Information)
CodeMouse92 updated the task description for T10072: Arcanist Ignoring .gitignore.
Dec 30 2015, 10:24 PM · Bug Report (Needs Information)
epriestley added a comment to T10072: Arcanist Ignoring .gitignore.

Please include reproduction instructions when filing a bug report. See Contributing Bug Reports.

Dec 30 2015, 10:21 PM · Bug Report (Needs Information)
CodeMouse92 created T10072: Arcanist Ignoring .gitignore.
Dec 30 2015, 9:37 PM · Bug Report (Needs Information)
CodeMouse92 added a comment to T7005: Find somewhat simple way to have Phriction be a part of new Projects layout.

I agree that we should have a single wiki page set as "Project Wiki Home" or the like, set from Projects (with appropriate edit permissions), not from Phriction. Then, if someone wants a page to be "associated" with a project, but not the homepage, they simply add it beneath that main page (or link to it on the main page). That should resolve any confusion about what it means to 'associate a page'.

Dec 30 2015, 9:29 PM · FreeBSD, Phriction, Projects
kaya added a comment to T4190: Rebuild remarkup image proxying.

I have a more restricted use case, which is to proxy images from Phabricator-hosted Git repositories. For example, I'd like README.md in a repo to be able to reference images in the repo. without having to upload them as files.

Dec 30 2015, 9:19 PM · Contributor Onboarding, Remarkup
chad added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Dec 30 2015, 8:31 PM · Phame
chad added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Dec 30 2015, 8:31 PM · Phame
melissa-playfab added a comment to T5724: ANSI color escape sequences seem broken for arc in git bash on windows.

This also happens on a normal arc install running on Powershell, except that I can't do any of the git_bash workarounds. I have git harnessed through Github's git shell. I'm synced with the most recent php/arcanist as of 12/30/15.

Dec 30 2015, 8:23 PM · Windows, Arcanist
syserr0r added a revision to T10071: New account e-mail invites do not allow registration on auth providers that do not allow registration: Unknown Object (Differential Revision).
Dec 30 2015, 4:10 PM · Auth, Bug Report
• VitaminCpp added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

Today I`ve had some more time and investigated this issue a bit further.
I tried to debug this issue by using gdb and figured out that after a while the method DiffusionGitSSHWorkflow->waitForGitClient() in DiffusionGitUploadPackSSHWorkflow.php:35 loops forever:

[0x7f595b9d4208] stream_select(array(1)[0x3efe808], array(0)[0x3efe718], array(1)[0x40fb4c8], 1, 0) /home/build/phabricator/libphutil/src/channel/PhutilChannel.php:197
[0x7f595b9d3848] PhutilChannel::waitForActivity(array(1)[0x40fb588], array(1)[0x40fb588], array(0)[0x40fb5e8]) /home/build/phabricator/libphutil/src/channel/PhutilChannel.php:100
[0x7f595b9d3748] PhutilChannel::waitForAny(array(1)[0x40fb588]) /home/build/phabricator/phabricator/src/applications/diffusion/ssh/DiffusionGitSSHWorkflow.php:25
[0x7f595b9d34a0] DiffusionGitSSHWorkflow->waitForGitClient() /home/build/phabricator/phabricator/src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php:35
[0x7f595b9d2ec8] DiffusionGitUploadPackSSHWorkflow->executeRepositoryOperations() /home/build/phabricator/phabricator/src/applications/diffusion/ssh/DiffusionSSHWorkflow.php:142
[0x7f595b9d28a0] DiffusionSSHWorkflow->execute(object[0x373c5c8]) /home/build/phabricator/phabricator/scripts/ssh/ssh-exec.php:267
Dec 30 2015, 4:08 PM · Git
syserr0r created T10071: New account e-mail invites do not allow registration on auth providers that do not allow registration.
Dec 30 2015, 3:41 PM · Auth, Bug Report
syserr0r created P1913 PhabricatorAuthRegisterController.php.
Dec 30 2015, 3:19 PM
epriestley closed T10070: 1212 as Spite.
Dec 30 2015, 2:48 PM · Bug Report
epriestley closed T10068: Phabricator Tasks are not loading after Upgrade. as Resolved.
Dec 30 2015, 2:47 PM · Bug Report
• Basheer awarded T10068: Phabricator Tasks are not loading after Upgrade. a Orange Medal token.
Dec 30 2015, 2:34 PM · Bug Report
• Basheer added a comment to T10068: Phabricator Tasks are not loading after Upgrade..

Thanks for sharing details. I have fixed the issues.

Dec 30 2015, 2:34 PM · Bug Report
• maige123 created T10070: 1212.
Dec 30 2015, 2:12 PM · Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 30 2015, 11:48 AM · Projects (v3)
epriestley merged task T10069: Issue: Phabricator predicts end of the world as December 2015 into T9606: "Calendar" tab on user profiles is pretty junky.
Dec 30 2015, 11:47 AM · Bug Report
epriestley updated subscribers of T9606: "Calendar" tab on user profiles is pretty junky.
Dec 30 2015, 11:47 AM · Calendar
nateguchi2 created T10069: Issue: Phabricator predicts end of the world as December 2015.
Dec 30 2015, 11:44 AM · Bug Report