Page MenuHomePhabricator

Implement global readthrough cache pools
Closed, ResolvedPublic

Description

The 404 page is issuing a minimum of ~15 queries. Some of this is T10077, but some of it isn't.

We can put this stuff in a global cache pool:

  • database config (saves 1 query)
  • spaces (saves 1 query)
  • editengine config (saves 6+ queries today, but only 1 real query, see T10077)

We can put this stuff in a user cache pool:

  • preferences (saves 1 query)
  • unread messages (saves 2 queries, should be 1 query)
  • unread notifications (saves 2 queries, should be 1 query)
  • user profile image (saves 1 query)

That should leave only the new cachekey version query and the session query. We can almost certainly move the session query to cache too, but it's more involved to do so.

Event Timeline

eadler added a project: Restricted Project.Jan 8 2016, 10:37 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 8 2016, 10:40 PM

D16001 likely provides an appropriate general-purpose mechanism for the user cache pool.

epriestley closed this task as Resolved.Mar 14 2018, 5:08 PM

This was largely tackled above.