Page MenuHomePhabricator

BYK (Burak Yiğit Kaya)
JS Foundation @ Facebook

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 28 2011, 1:51 PM (394 w, 2 d)
Availability
Available

Recent Activity

Jan 8 2018

BYK abandoned D15676: Fix root path finding on Windows.
Jan 8 2018, 3:03 PM
BYK abandoned D15693: Remove Windows workarounds from ArcanistGitAPI.
Jan 8 2018, 3:03 PM
BYK abandoned D8084: Add GenericXUnitTestEngine.
Jan 8 2018, 3:03 PM
BYK abandoned D15675: Fix Windows escaping.

Alright! You know where to find me or this patch if interest arises :)

Jan 8 2018, 3:02 PM
BYK added a comment to D15675: Fix Windows escaping.

@epriestley is the best course of action for this diff to abandon it?

Jan 8 2018, 2:49 PM

Feb 14 2017

BYK added a comment to T8298: Fix Windows Escaping.

@chad - How can I be involved with any progress on this front then since now it is planned?

Feb 14 2017, 8:29 AM · Windows

Jan 12 2017

BYK added a comment to T9640: Make Phabricator compatible with PHP7.

I wasn't trying to create a whole new discussion. I respect your priorities and I also understand the engineers vs. money problem. The only major problem I see with the contribution guidelines is this: to be able to contribute more or affect change, you need clout and to get clout you need to contribute and for those contributions to go into the code or even get some feedback we need time from you guys.

Jan 12 2017, 7:51 PM · Prioritized, Restricted Project, Infrastructure
BYK added a comment to T9640: Make Phabricator compatible with PHP7.

@chad - You know how can you get more developers? Being more open to contributions :)

Jan 12 2017, 7:12 PM · Prioritized, Restricted Project, Infrastructure

Jan 9 2017

BYK updated the diff for D15676: Fix root path finding on Windows.

rebase

Jan 9 2017, 9:41 PM
BYK updated the diff for D15693: Remove Windows workarounds from ArcanistGitAPI.

rebase

Jan 9 2017, 9:40 PM
BYK updated the diff for D15675: Fix Windows escaping.

rebase

Jan 9 2017, 9:39 PM

Oct 21 2016

BYK updated the diff for D15675: Fix Windows escaping.

rebase

Oct 21 2016, 7:32 AM
BYK updated the diff for D15693: Remove Windows workarounds from ArcanistGitAPI.

rebase

Oct 21 2016, 7:31 AM
BYK updated the diff for D15676: Fix root path finding on Windows.

rebase

Oct 21 2016, 7:29 AM

Oct 4 2016

BYK updated the diff for D15676: Fix root path finding on Windows.

rebase

Oct 4 2016, 8:26 AM
BYK updated the diff for D15676: Fix root path finding on Windows.

rebase

Oct 4 2016, 8:22 AM
BYK updated the diff for D15693: Remove Windows workarounds from ArcanistGitAPI.

rebase

Oct 4 2016, 8:21 AM
BYK added a comment to D15675: Fix Windows escaping.

I'd love to get this merged or concluded instead of trying to keep up with rebases and push it forward. I have been using this branch for quite a while locally and as far as I can tell, there are no problems.

Oct 4 2016, 8:18 AM
BYK updated the diff for D15675: Fix Windows escaping.

rebase

Oct 4 2016, 8:14 AM

Jul 25 2016

BYK added a comment to T8298: Fix Windows Escaping.

@eadler - oops, sorry about that then :) I'm still behind what I said though ;)

Jul 25 2016, 5:20 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

@eadler - I'd like to remind you that there are 3 patches waiting for review right now. They have been sitting there for a few months. That said we are not paying Phabricator. If the only way to get these patches which are already worked on and in pretty good shape merged in is to pay you or maintain a fork I'm really starting to think about crowdsourcing this on Kickstarter or Indiegogo to collect those few hundred bucks to get already working patches landed or simply create a fork and point people there loudly. I also think I almost qualify for "Rise to prominence" sub-section mentioned in https://secure.phabricator.com/book/phabcontrib/article/contributing_code/#alternatives but of course that also relies on you guys letting me contribute more. Making patches sit for months without any feedback and then making me rebase them multiple times is definitely not a great way to encourage people to "Rise to prominence" if you really value that.

Jul 25 2016, 5:10 PM · Windows

Jun 23 2016

BYK updated the diff for D15675: Fix Windows escaping.
  • Feedback
Jun 23 2016, 11:20 AM
BYK added inline comments to D15675: Fix Windows escaping.
Jun 23 2016, 10:28 AM

Jun 22 2016

BYK added a comment to D15675: Fix Windows escaping.

I've decided to just drop the CMD.exe support since it is crazy and unreliable when it comes to escaping edge cases. Also it needs double escaping anyways (ArgV + Crazy-ass CMD escaping).

Jun 22 2016, 10:24 PM
BYK updated D15675: Fix Windows escaping.
Jun 22 2016, 10:23 PM
BYK updated the diff for D15675: Fix Windows escaping.
  • Remove CMD.exe support and fix edge cases
Jun 22 2016, 10:23 PM

Jun 21 2016

BYK added inline comments to D15675: Fix Windows escaping.
Jun 21 2016, 6:10 AM

Jun 20 2016

BYK added a comment to D15675: Fix Windows escaping.

If there's no way to escape it, we should make it throw, and have a test case to make sure it throws. It's OK if we don't handle it, I just want to have no cases where we silently do the wrong thing.

Jun 20 2016, 6:58 PM
BYK added inline comments to D15675: Fix Windows escaping.
Jun 20 2016, 6:55 PM
BYK added inline comments to D15675: Fix Windows escaping.
Jun 20 2016, 12:54 PM
BYK added a comment to D15676: Fix root path finding on Windows.

@epriestley ping

Jun 20 2016, 10:40 AM
BYK updated the diff for D15676: Fix root path finding on Windows.

rebase

Jun 20 2016, 10:39 AM
BYK added a comment to D15675: Fix Windows escaping.

@epriestley if you are willing to give this another shot I'll try to fix the test error. Otherwise all my hard work seems to be going into a blackhole.

Jun 20 2016, 10:36 AM
BYK updated the diff for D15675: Fix Windows escaping.

rebase

Jun 20 2016, 10:35 AM
BYK updated the diff for D15693: Remove Windows workarounds from ArcanistGitAPI.

rebase

Jun 20 2016, 10:34 AM

May 16 2016

BYK awarded T3975: Add the ability to show Google Docs in Remarkup a Like token.
May 16 2016, 6:19 PM · Remarkup

Apr 29 2016

BYK updated the diff for D15675: Fix Windows escaping.

rebase

Apr 29 2016, 3:58 PM

Apr 22 2016

BYK added a comment to D15675: Fix Windows escaping.

Bump

Apr 22 2016, 7:37 PM
BYK added a comment to D15676: Fix root path finding on Windows.

Bump

Apr 22 2016, 7:37 PM

Apr 15 2016

BYK added a comment to D15675: Fix Windows escaping.

(I'm looking forward to reviewing this but probably won't get to it for at least a few days since I want to test it thoroughly myself.)

Apr 15 2016, 1:10 PM
BYK added a comment to D15675: Fix Windows escaping.

The flag was initially added to minimize the impact of fixing the broken streaming that Windows has by default. Without this flag on, you can't actually stream data from a process's standard output to PHP in realtime; you have to wait for the output to be fully buffered.

Apr 15 2016, 9:58 AM
BYK updated subscribers of D15676: Fix root path finding on Windows.

Anything I can do to move this one forward?

Apr 15 2016, 9:10 AM
BYK added a comment to D15675: Fix Windows escaping.

lgtm (but I haven't tested it)

Apr 15 2016, 9:09 AM
BYK updated the diff for D15675: Fix Windows escaping.
  • Actually add comment about taskkill change
  • Safer PHP invocation for edge case test
Apr 15 2016, 8:56 AM
BYK added a comment to D15675: Fix Windows escaping.

@epriestley, @hach-que - I think this is in a very good state for a review now. The only thing I'm unsure is whether to enable bypass_shell by default since I don't see a reason to use the cmd.exe proxy. Its commands are not universal and it requires another layer of escaping which is confusing and probably prone to errors, especially when things get nested.

Apr 15 2016, 8:53 AM
BYK updated the diff for D15675: Fix Windows escaping.
  • Rebase
  • Add comment about taskkill change
  • Slightly better php invocations in tests
  • Enable one more test for Windows
Apr 15 2016, 8:51 AM

Apr 14 2016

BYK updated the diff for D15676: Fix root path finding on Windows.

rebase/bump

Apr 14 2016, 10:35 PM

Apr 13 2016

BYK retitled D15693: Remove Windows workarounds from ArcanistGitAPI from to Remove Windows workarounds from ArcanistGitAPI.
Apr 13 2016, 6:11 AM
BYK requested review of D15675: Fix Windows escaping.

Okay, the patch was good. It was arc trying to overcompensate for Windows mania so another patch to arc is needed and it is on its way.

Apr 13 2016, 6:09 AM

Apr 12 2016

BYK planned changes to D15675: Fix Windows escaping.

I've noticed an issue with passthru mode. I'll investigate and update the patch accordingly.

Apr 12 2016, 9:01 PM
BYK updated subscribers of D15675: Fix Windows escaping.

I guess the author of the article I referenced is @dancol ?

Apr 12 2016, 2:36 PM
BYK added inline comments to D15675: Fix Windows escaping.
Apr 12 2016, 2:20 PM
BYK added inline comments to D15675: Fix Windows escaping.
Apr 12 2016, 2:18 PM
BYK added inline comments to D15675: Fix Windows escaping.
Apr 12 2016, 2:16 PM
BYK updated D15675: Fix Windows escaping.
Apr 12 2016, 2:11 PM
BYK updated the test plan for D15675: Fix Windows escaping.
Apr 12 2016, 2:10 PM
BYK retitled D15675: Fix Windows escaping from Default to PowerShell escape mode on Windows to Fix Windows escaping.
Apr 12 2016, 2:10 PM
BYK updated the diff for D15675: Fix Windows escaping.
  • Fix broken test case
  • Fix Windows escaping once and for all
  • Fix test failures
  • Add test for edge cases
Apr 12 2016, 2:09 PM

Apr 11 2016

BYK added a comment to D15675: Fix Windows escaping.

@epriestley - great test cases. I've already found a great article on MSDN which explains the escaping rules on Windows, both for CreateProcess and CMD.exe and implemented them. They seem to work well. I'm working fixing somewhat unrelated test failures due to stdin pipe getting clogged. I'll add these strings as test cases. Good news is, based on the information I got from the article, there doesn't seem any unescapable inputs.

Apr 11 2016, 4:32 PM
BYK planned changes to D15675: Fix Windows escaping.
Apr 11 2016, 6:43 AM
BYK added a comment to D15675: Fix Windows escaping.

@hach-que - Okay for the sake of progress I'm gonna leave the specifics of the argument or how these are parsed. I think you basically want me to come up with a "proper CMD escape" (has nothing to do with CreateProcess) instead of reusing PowerShell escape since that is not the correct way and are not asking me to make all instantiations of this class Windows-aware.

Apr 11 2016, 6:43 AM

Apr 10 2016

BYK added a comment to D15675: Fix Windows escaping.

But not everything is running through Powershell? When Arcanist runs (which is using this function), it escapes for the Command Prompt, not Powershell.

Apr 10 2016, 9:51 PM
BYK requested review of D15675: Fix Windows escaping.

@hach-que - I strongly disagree since with that solution every single instance of the class needs to to this exact same thing. It doesn't make any sense to me. There's no point using the built in escaping function on Windows because it is broken beyond repair.

Apr 10 2016, 8:24 PM
BYK updated the diff for D15676: Fix root path finding on Windows.
  • Fix test failures
Apr 10 2016, 5:58 PM
BYK added inline comments to D15676: Fix root path finding on Windows.
Apr 10 2016, 5:55 PM
BYK retitled D15676: Fix root path finding on Windows from to Fix root path finding on Windows.
Apr 10 2016, 4:04 PM
BYK added a revision to T8291: arc version fails on Windows: D15676: Fix root path finding on Windows.
Apr 10 2016, 4:04 PM · Windows, Arcanist
BYK added a task to D15675: Fix Windows escaping: T10468: cannot upload diff using svn.

This should fix T10468.

Apr 10 2016, 3:35 PM
BYK added a revision to T10468: cannot upload diff using svn: D15675: Fix Windows escaping.
Apr 10 2016, 3:35 PM · Differential, Arcanist, Bug Report (Needs Information)
BYK updated the diff for D15675: Fix Windows escaping.
  • Fix broken test case
Apr 10 2016, 3:33 PM
BYK retitled D15675: Fix Windows escaping from to Default to PowerShell escape mode on Windows.
Apr 10 2016, 3:05 PM
BYK added a revision to T8298: Fix Windows Escaping: D15675: Fix Windows escaping.
Apr 10 2016, 3:05 PM · Windows

Mar 11 2016

BYK added inline comments to D15452: Cast old duration values for unit tests to float in DifferentialController.
Mar 11 2016, 8:36 AM

Mar 9 2016

BYK retitled D15452: Cast old duration values for unit tests to float in DifferentialController from to Cast old duration values for unit tests to float in DifferentialController.
Mar 9 2016, 11:04 PM
BYK added a revision to T10549: Getting PhutilTypeCheckException on certaion Differential pages: D15452: Cast old duration values for unit tests to float in DifferentialController.
Mar 9 2016, 11:04 PM · Differential, Bug Report
BYK created T10549: Getting PhutilTypeCheckException on certaion Differential pages.
Mar 9 2016, 10:05 PM · Differential, Bug Report

Dec 31 2015

BYK added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

This is another reason for me to dislike PHP but I really appreciate the time you've taken to explain the issue in addition to a promising fix for this task. Couldn't have asked for a better new year's gift :)

Dec 31 2015, 10:46 PM · Git
BYK abandoned D14916: Possible fix for invalid EOF detection on sockets.

Abandoning per T9724#151731

Dec 31 2015, 10:44 PM
BYK added a comment to D14916: Possible fix for invalid EOF detection on sockets.

Oh wow, sorry. I just thought my system was broken and was hoping CI would
run tests. Will see if I can fix this.

Dec 31 2015, 6:55 PM

Dec 30 2015

BYK retitled D14916: Possible fix for invalid EOF detection on sockets from to Possible fix for invalid EOF detection on sockets.
Dec 30 2015, 9:59 PM

Dec 27 2015

BYK added a comment to T8603: repository.query is not returning required parameter `order`.

If so, I'd generally claim this is an issue with the client you're using: I think clients generally should not do parameter validation themselves. They will always be less able to do validation than the server is, even though server validation is not especially sophisticated right now. If/when we have a formal Python API client, it is very unlikely to perform client validation. Does client validation provide any advantage?

Dec 27 2015, 5:47 PM · Disqus, Conduit

Oct 8 2015

BYK added a comment to T8298: Fix Windows Escaping.

I'm fairly certain since it seems to be using the CreateProcess API as others do. I'm also using xonsh (the project using that Python code) for quite some time now and it works without any issues.

Oct 8 2015, 9:49 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

@epriestley - okay, may be the name mislead me. Anyways, I'm basically proposing making bypass_shell on by default in execx and implementing a mechanism that automatically finds the full path of the executable on Windows by implementing that Python function I referred to. Does this make sense?

Oct 8 2015, 9:33 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

How does that obsolete PhutilExecPassthru?

Oct 8 2015, 8:37 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

Okay, proposal: how about we implement the equivalent of this: https://github.com/scopatz/xonsh/blob/fa356d728b2852274f8aa0260dc7da3b7b0f08ab/xonsh/built_ins.py#L268

Oct 8 2015, 8:15 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

Oh god, and I thought Python's subprocess module was pretty bad.

Oct 8 2015, 7:49 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

bypass_shell (windows only): bypass cmd.exe shell when set to TRUE
5.2.1 Added the bypass_shell option to the other_options parameter.

Oct 8 2015, 7:35 PM · Windows
BYK abandoned D14246: Do not escape binary paths in external linters.

Oh, thanks a lot for the pointers. I'll see how I can help with those.

Oct 8 2015, 7:30 PM
BYK updated the diff for D14246: Do not escape binary paths in external linters.
  • Fix some tests
Oct 8 2015, 7:25 PM
BYK added a comment to D14246: Do not escape binary paths in external linters.

This is a "does this really work?" sort of diff. Will make it proper after some feedback. Thanks! :)

Oct 8 2015, 6:16 PM
BYK retitled D14246: Do not escape binary paths in external linters from to Do not escape binary paths in external linters.
Oct 8 2015, 6:14 PM

Sep 15 2015

joshuaspence awarded D14034: Prevent caching of workflows a Like token.
Sep 15 2015, 8:28 PM
BYK added a comment to D14034: Prevent caching of workflows.

Thank you guys for the pointer and quick turn around!

Sep 15 2015, 12:25 PM
BYK retitled D14034: Prevent caching of workflows from Only set `$workflow-conduit` if it's missing to Prevent caching of workflows.
Sep 15 2015, 12:01 PM
BYK updated the diff for D14034: Prevent caching of workflows.
  • Do not cache workflow
Sep 15 2015, 10:17 AM

Sep 11 2015

BYK added a comment to D14034: Prevent caching of workflows.

@epriestley - so are you saying I should simply revert rARC0e0957872083daa38309204ad9774568c9fcdd5c? I mean that looks like a nice patch and given all the context you and @avivey shared (thanks a ton btw for that), I may be able to prevent caching "properly".

Sep 11 2015, 7:32 AM

Sep 10 2015

BYK added a comment to D14034: Prevent caching of workflows.

@avivey - When arc patch runs itself recursively. The thing I realized is arc patch first tries to get the patch without using credentials (but it still requires a conduit), and then when it realizes the request is rejected due to missing credentials, it manually adds them by calling authenticateConduit. After that it calls run, which in turn calls buildChildWorkflow. Since the parent buildChildWorkflow doesn't know about the already established conduit which has its credentials already set ($workflow->conduit being set) it simply tries to reset it causing $workflow->setConduitCredentials($this->conduitCredentials); call to throw the You may not set new credentials after authenticating conduit. error since credentials were already set manually by arc patch.

Sep 10 2015, 9:18 AM

Sep 4 2015

BYK added a comment to D14034: Prevent caching of workflows.

Ping?

Sep 4 2015, 9:06 AM

Sep 1 2015

BYK updated the diff for D14034: Prevent caching of workflows.
  • don't skip lint and unit
Sep 1 2015, 8:34 PM
BYK added a revision to T9159: You may not set new credentials after authenticating conduit: D14034: Prevent caching of workflows.
Sep 1 2015, 8:06 PM · Arcanist