Page MenuHomePhabricator

BYK (Burak Yiğit Kaya)
JS Foundation @ Facebook

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 28 2011, 1:51 PM (774 w, 5 d)
Availability
Available

Recent Activity

Feb 14 2017

BYK added a comment to T8298: Fix Windows Escaping.

@chad - How can I be involved with any progress on this front then since now it is planned?

Feb 14 2017, 8:29 AM · Windows

Jan 12 2017

BYK added a comment to T9640: Make Phabricator compatible with PHP7.

I wasn't trying to create a whole new discussion. I respect your priorities and I also understand the engineers vs. money problem. The only major problem I see with the contribution guidelines is this: to be able to contribute more or affect change, you need clout and to get clout you need to contribute and for those contributions to go into the code or even get some feedback we need time from you guys.

Jan 12 2017, 7:51 PM · Prioritized, Restricted Project, Infrastructure
BYK added a comment to T9640: Make Phabricator compatible with PHP7.

@chad - You know how can you get more developers? Being more open to contributions :)

Jan 12 2017, 7:12 PM · Prioritized, Restricted Project, Infrastructure

Jul 25 2016

BYK added a comment to T8298: Fix Windows Escaping.

@eadler - oops, sorry about that then :) I'm still behind what I said though ;)

Jul 25 2016, 5:20 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

@eadler - I'd like to remind you that there are 3 patches waiting for review right now. They have been sitting there for a few months. That said we are not paying Phabricator. If the only way to get these patches which are already worked on and in pretty good shape merged in is to pay you or maintain a fork I'm really starting to think about crowdsourcing this on Kickstarter or Indiegogo to collect those few hundred bucks to get already working patches landed or simply create a fork and point people there loudly. I also think I almost qualify for "Rise to prominence" sub-section mentioned in https://secure.phabricator.com/book/phabcontrib/article/contributing_code/#alternatives but of course that also relies on you guys letting me contribute more. Making patches sit for months without any feedback and then making me rebase them multiple times is definitely not a great way to encourage people to "Rise to prominence" if you really value that.

Jul 25 2016, 5:10 PM · Windows

May 16 2016

BYK awarded T3975: Add the ability to show Google Docs in Remarkup a Like token.
May 16 2016, 6:19 PM · Remarkup

Apr 10 2016

BYK added a revision to T8291: arc version fails on Windows: Unknown Object (Differential Revision).
Apr 10 2016, 4:04 PM · Windows, Arcanist
BYK added a revision to T10468: cannot upload diff using svn: Unknown Object (Differential Revision).
Apr 10 2016, 3:35 PM · Differential, Arcanist, Bug Report (Needs Information)
BYK added a revision to T8298: Fix Windows Escaping: Unknown Object (Differential Revision).
Apr 10 2016, 3:05 PM · Windows

Mar 9 2016

BYK added a revision to T10549: Getting PhutilTypeCheckException on certaion Differential pages: Unknown Object (Differential Revision).
Mar 9 2016, 11:04 PM · Differential, Bug Report
BYK created T10549: Getting PhutilTypeCheckException on certaion Differential pages.
Mar 9 2016, 10:05 PM · Differential, Bug Report

Dec 31 2015

BYK added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

This is another reason for me to dislike PHP but I really appreciate the time you've taken to explain the issue in addition to a promising fix for this task. Couldn't have asked for a better new year's gift :)

Dec 31 2015, 10:46 PM · Git

Dec 27 2015

BYK added a comment to T8603: repository.query is not returning required parameter `order`.

If so, I'd generally claim this is an issue with the client you're using: I think clients generally should not do parameter validation themselves. They will always be less able to do validation than the server is, even though server validation is not especially sophisticated right now. If/when we have a formal Python API client, it is very unlikely to perform client validation. Does client validation provide any advantage?

Dec 27 2015, 5:47 PM · Disqus, Conduit

Oct 8 2015

BYK added a comment to T8298: Fix Windows Escaping.

I'm fairly certain since it seems to be using the CreateProcess API as others do. I'm also using xonsh (the project using that Python code) for quite some time now and it works without any issues.

Oct 8 2015, 9:49 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

@epriestley - okay, may be the name mislead me. Anyways, I'm basically proposing making bypass_shell on by default in execx and implementing a mechanism that automatically finds the full path of the executable on Windows by implementing that Python function I referred to. Does this make sense?

Oct 8 2015, 9:33 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

How does that obsolete PhutilExecPassthru?

Oct 8 2015, 8:37 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

Okay, proposal: how about we implement the equivalent of this: https://github.com/scopatz/xonsh/blob/fa356d728b2852274f8aa0260dc7da3b7b0f08ab/xonsh/built_ins.py#L268

Oct 8 2015, 8:15 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

Oh god, and I thought Python's subprocess module was pretty bad.

Oct 8 2015, 7:49 PM · Windows
BYK added a comment to T8298: Fix Windows Escaping.

bypass_shell (windows only): bypass cmd.exe shell when set to TRUE
5.2.1 Added the bypass_shell option to the other_options parameter.

Oct 8 2015, 7:35 PM · Windows

Sep 1 2015

BYK added a revision to T9159: You may not set new credentials after authenticating conduit: Unknown Object (Differential Revision).
Sep 1 2015, 8:06 PM · Arcanist

Aug 28 2015

BYK added a comment to T9159: You may not set new credentials after authenticating conduit.

Seems like this happens when you have multiple layers of dependent diffs.

Aug 28 2015, 6:45 PM · Arcanist

May 14 2015

BYK added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

Since many engines support common output formats (I think?) like XUnit (I think?) separating parsing might be valuable here, while it's not very useful for lint.

May 14 2015, 1:49 PM · Unit, Arcanist

Mar 30 2015

BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

It looks like this is probably not a bug then, and D12211 is a fairly reasonable fix.

Mar 30 2015, 10:01 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

I think this is the reason: http://stackoverflow.com/a/9014547/90297

Mar 30 2015, 9:53 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

@epriestley - I was able to narrow it down to this:

Mar 30 2015, 9:20 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

This looks like a bug in Firefox to me, but I imagine reducing it to a test case is quite involved.

Mar 30 2015, 6:43 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

We don't provide support alpha/beta browsers. All bug reports should be against stable browsers and HEAD.

Mar 30 2015, 6:37 PM · Firefox, Differential
BYK added a comment to T7690: Unnecessary scroll bars for changesets in Firefox.

Windows 8.1 EN with Firefox Aurora 38. That said I've had this issue for the last 2-3 versions so it should happen on latest stable Firefox too. I can verify if you want.

Mar 30 2015, 6:20 PM · Firefox, Differential
BYK reopened T7690: Unnecessary scroll bars for changesets in Firefox as "Open".

Here: https://secure.phabricator.com/D12210#1753cdf4

Mar 30 2015, 4:52 PM · Firefox, Differential
BYK created T7690: Unnecessary scroll bars for changesets in Firefox.
Mar 30 2015, 8:19 AM · Firefox, Differential
BYK added a comment to T7109: Mousewheel scrolling is sluggish in Firefox/Win.

This has been driving me and one of my colleagues crazy for a while now and he came with the following Stylish rule to get rid of it:

Mar 30 2015, 8:13 AM · Firefox, Windows, PHUI

Mar 24 2015

BYK added a comment to T5064: Make `arc land` run unit tests and lint.

For our case, we use both arc lint and arc unit. We have a somewhat "smart" unit test engine that tries to run only affected tests up to a degree so test times are not a huge concern to us. Also the team I work with is ~10 people so there's no way we can go as high as 30 commits/hour, at least in the near future. We have a smooth CI system that is running tests both for each diff revision and every commit on master.

Mar 24 2015, 10:14 AM · Restricted Project, Arcanist

Nov 19 2014

sascha-egerer awarded T5064: Make `arc land` run unit tests and lint a The World Burns token.
Nov 19 2014, 8:36 AM · Restricted Project, Arcanist

May 15 2014

BYK added a comment to T5064: Make `arc land` run unit tests and lint.

The UI shows skipped. Instead, it should just be omitted or show tailored messages that this is an update from the VCS. This is easy and just a display issue.

May 15 2014, 1:45 PM · Restricted Project, Arcanist
BYK created T5064: Make `arc land` run unit tests and lint.
May 15 2014, 9:26 AM · Restricted Project, Arcanist