Page MenuHomePhabricator

Krenair (Alex Monk)
Wikimedia volunteer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 16 2014, 10:20 PM (279 w, 2 d)
Availability
Available

Recent Activity

Apr 15 2019

Krenair updated Krenair.
Apr 15 2019, 1:22 AM

Aug 10 2016

Krenair awarded T11428: Upcoming: Personal Herald Rules No Longer Semi-Private a Like token.
Aug 10 2016, 12:58 AM · Policy, Installing & Upgrading, Herald

Mar 27 2016

Krenair created T10683: New Conpherence participant makes the conversation unread but does not update subtitle.
Mar 27 2016, 7:32 PM · Conpherence (v4), Bug Report

Mar 18 2016

Krenair added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Yep, that worked. Thanks.

Mar 18 2016, 11:30 PM · Phurl, Bug Report
Krenair added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

So this actually in Phurl (not clear from the link) and not valid itself because Phurl is a prototype?

Mar 18 2016, 10:43 PM · Phurl, Bug Report
Krenair created T10625: Links like "((prototype))" are not expanded properly in email.
Mar 18 2016, 10:40 PM · Phurl, Bug Report

Mar 16 2016

Krenair awarded T6703: Allow multiple copies of the same auth provider type a Love token.
Mar 16 2016, 2:19 AM · Auth

Mar 13 2016

Krenair added a comment to T10579: Consistency of status search fields across applications.

Sure, so it's not the idea of consistency here that's the issue, it's which existing implementation to actually go with, and you're not convinced Maniphest's one is the way forward?

Mar 13 2016, 10:45 PM · Audit, Differential, Feature Request
Krenair added a comment to T10579: Consistency of status search fields across applications.

We generally don't want to be in the business of spending time debating design opinions

Mar 13 2016, 10:22 PM · Audit, Differential, Feature Request
Krenair created T10580: People Invites 'Advanced Search' is not very advanced..
Mar 13 2016, 10:02 PM · People, Bug Report
Krenair created T10579: Consistency of status search fields across applications.
Mar 13 2016, 9:59 PM · Audit, Differential, Feature Request

Mar 9 2016

Krenair added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

This is particularly problematic in the UI when you need to revert the first change to a task since creation - there doesn't appear to be any way to find the initial assignee of https://phabricator.wikimedia.org/T129128#2105237 for example

Mar 9 2016, 11:50 PM · Wikimedia, Notifications, Projects (v3), Bug Report

Mar 8 2016

Krenair created T10540: project.query API does not give information about parent projects.
Mar 8 2016, 1:27 AM · Projects, Bug Report
Krenair added a comment to T6848: It should be possible to view a repository's policies without necessarily being able to edit it.

Also, view the edit history: https://phabricator.wikimedia.org/T128679

Mar 8 2016, 12:23 AM · Diffusion (v3)

Mar 7 2016

benjumanji awarded T6848: It should be possible to view a repository's policies without necessarily being able to edit it a Like token.
Mar 7 2016, 5:30 PM · Diffusion (v3)

Mar 2 2016

Krenair added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

It's mainly the projects that I want to see as well. Although there has been talk of priorities etc. as well

Mar 2 2016, 6:54 PM · Wikimedia, Notifications, Projects (v3), Bug Report
Krenair added a project to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications): Wikimedia.
Mar 2 2016, 8:15 AM · Wikimedia, Notifications, Projects (v3), Bug Report

Feb 29 2016

Krenair added a comment to T7979: Add ability to search by policy.

I suppose that'll work for maniphest/paste/projects/etc., but the most recent case I had in mind involved dashboard panel edit policies... :/

Feb 29 2016, 1:42 AM · Policy, Search

Feb 28 2016

Krenair added a comment to T10473: Dashboard panel tab transactions are illegible.

The link is to "RobH changed Tabs from codfw206eqiad207 to codfw206eqiad207esams208ulsfo209." specifically

Feb 28 2016, 9:58 PM · Dashboards (v2), Bug Report
Krenair awarded T7979: Add ability to search by policy a Like token.
Feb 28 2016, 9:57 PM · Policy, Search
Krenair created T10474: Dashboard panel changes seem to think every edit creates whole text all over again.
Feb 28 2016, 9:54 PM · Dashboards (v2), Bug Report
Krenair added a comment to T10473: Dashboard panel tab transactions are illegible.

"RobH set Tabs to ." is also a bit weird

Feb 28 2016, 9:52 PM · Dashboards (v2), Bug Report
Krenair created T10473: Dashboard panel tab transactions are illegible.
Feb 28 2016, 9:51 PM · Dashboards (v2), Bug Report
Krenair edited projects for T10472: Ability to search for objects with policies referencing a specified project/user?, added: Feature Request; removed Bug Report.
Feb 28 2016, 9:16 PM · Feature Request, Policy
Krenair created T10472: Ability to search for objects with policies referencing a specified project/user?.
Feb 28 2016, 9:16 PM · Feature Request, Policy

Feb 25 2016

Krenair added a parent task for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: T7944: Add Conduit support to Calendar.
Feb 25 2016, 6:17 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
Krenair removed a subtask for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: T7944: Add Conduit support to Calendar.
Feb 25 2016, 6:17 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
Krenair added a subtask for T7944: Add Conduit support to Calendar: T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Feb 25 2016, 6:17 PM · Conduit, Calendar
Krenair removed a parent task for T7944: Add Conduit support to Calendar: T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Feb 25 2016, 6:17 PM · Conduit, Calendar
Krenair added a subtask for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: T7944: Add Conduit support to Calendar.
Feb 25 2016, 6:17 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
Krenair added a parent task for T7944: Add Conduit support to Calendar: T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Feb 25 2016, 6:17 PM · Conduit, Calendar
Krenair updated subscribers of T9275: Move Calendar to EditEngine.

There's also mode=recurring... all these seem to do is change different default options on the form. Should I try to implement form edit engine support for this @epriestley? Would you be prepared to review it?

Feb 25 2016, 6:02 PM · ApplicationEditor, Policy, Calendar
Krenair added a comment to T9275: Move Calendar to EditEngine.

I did some digging through the source code and found PhabricatorCalendarEvent::initializeNewCalendarEvent which does this:

if ($mode == 'public') {
  $view_policy = PhabricatorPolicies::getMostOpenPolicy();
}
Feb 25 2016, 5:57 PM · ApplicationEditor, Policy, Calendar

Feb 24 2016

Krenair added a watcher for Policy: Krenair.
Feb 24 2016, 11:37 AM
Krenair added a member for Policy: Krenair.
Feb 24 2016, 11:37 AM

Feb 18 2016

Krenair retitled D15307: Return 404 instead of undefined variable error when trying to edit a non-existent form from to Return 404 instead of undefined variable error when trying to edit a non-existent form.
Feb 18 2016, 5:53 PM

Feb 6 2016

Krenair awarded T6502: Policy to define who can move cards in a workboard a Dislike token.
Feb 6 2016, 7:44 PM · Projects, Wikimedia, Policy, Workboards

Dec 31 2015

Krenair added a comment to T8434: Accommodate the "Security" workflow.

I think one of the issues was people making a public task, and then deciding they should change it to security, but not having the permissions to do so?

Dec 31 2015, 1:25 AM · Wikimedia, Policy, Prioritized

Dec 10 2015

Krenair added a comment to T9949: Custom policy error is unhelpful.

User (or project) based policies produce useful error messages if you can't view an object:

Dec 10 2015, 5:31 PM · Policy, Bug Report
Krenair created T9949: Custom policy error is unhelpful.
Dec 10 2015, 3:44 PM · Policy, Bug Report

Nov 30 2015

Krenair added a comment to T9869: Certain transactions not viewable while logged out?.

I can't examine any of those either, but I can reproduce the bug on what I think is a relatively up-to-date production installation.
If it helps, this URL was linked from https://phabricator.wikimedia.org/project/profile/1090/#17189 (edit policy entry)

Nov 30 2015, 2:39 PM · Policy, Transactions
Krenair renamed T9869: Certain transactions not viewable while logged out? from Transactions not viewable while logged out? to Certain transactions not viewable while logged out?.
Nov 30 2015, 2:34 PM · Policy, Transactions
Krenair added a comment to T9869: Certain transactions not viewable while logged out?.
In T9869#146119, @chad wrote:

Please file bugs with more information, specifically steps to reproduce. See Contributing Bug Reports.

Nov 30 2015, 2:33 PM · Policy, Transactions

Nov 29 2015

Krenair created T9869: Certain transactions not viewable while logged out?.
Nov 29 2015, 12:41 AM · Policy, Transactions

Aug 12 2015

Krenair added a comment to T6802: "Custom policy" for editing/viewing does not link to details.

this may be covered by the spaces system?

Aug 12 2015, 6:34 PM · Design, Policy

Jun 17 2015

Krenair added a comment to T8434: Accommodate the "Security" workflow.

Regarding editing policy on a task: I'm not sure how to do it but I think what might be desirable is that the task author has some sort of limited ability to comment on a 'security' task but not really edit it in any significant way after submission.

Jun 17 2015, 6:27 PM · Wikimedia, Policy, Prioritized

Jun 13 2015

Krenair added a comment to T8376: Develop Spaces (v1).

I think that there should be a separate visibility policy for the description page of a space.

Can you walk me through this a little more? I'm hesitant to add complexity, and it seems like having "Can See Space" and "Can See Objects in Space" as separate policies may be confusing. Why is it important/desirable that users be able to see, e.g., a "Procurement" space if they don't have access to it?

Jun 13 2015, 10:01 PM · Prioritized, Policy, Wikimedia, Spaces
Krenair added a project to T6113: Unclear difference between "Watch Project" and "Subscribe": Wikimedia.
Jun 13 2015, 4:44 PM · Wikimedia, Guides, Projects
Krenair added a project to T8524: Email preferences doesn't contain an entry for Project Subscriber updates: Wikimedia.
Jun 13 2015, 4:39 PM · FreeBSD, Wikimedia, Notifications

Jun 12 2015

Krenair added a comment to T8376: Develop Spaces (v1).

I think that there should be a separate visibility policy for the description page of a space. I think that the text shown for visibility policies at the tops of objects should be clarified when in spaces. I can't think of any other tweaks right now other than the things discussed in T8434, which are more major. I think here's already some consideration about how objects in spaces should look style-wise somewhere?

Jun 12 2015, 9:04 PM · Prioritized, Policy, Wikimedia, Spaces

Jun 11 2015

Krenair added a comment to T8376: Develop Spaces (v1).

Noticed that S2 did not get linked in the email for @epriestley's above comment, is that a bug?

Jun 11 2015, 6:26 PM · Prioritized, Policy, Wikimedia, Spaces

Jun 10 2015

Krenair added a comment to T8493: Integrate Spaces into more applications.

Edit: Ignore this. Your quote formatted strangely in my email client and I thought you were saying that Spaces do allow that. Never mind.

Jun 10 2015, 2:30 PM · Spaces, Wikimedia, Policy, Prioritized
Krenair added a comment to T8493: Integrate Spaces into more applications.
In T8493#119801, @qgil wrote:

the intention is that Spaces will allow us to deprecate our own local remedies, one step at a time.

Jun 10 2015, 1:16 PM · Spaces, Wikimedia, Policy, Prioritized
Krenair added a comment to T8493: Integrate Spaces into more applications.

I think the difference with the Wikimedia Procurement use case is that tasks with files are created via email (i.e. a provider sends an offer to an email address).

I hadn't thought about this yet, but I think we'll probably just let you assign a Space to each application email address, so everything to procurement-bugs@ would default into the procurement space and everything to normal-bugs@ would go into the default space.
(We can implement a !space mail command, too, if there are automated or more complex cases here where the same address might receive mail destined for multiple spaces.)

Jun 10 2015, 12:54 PM · Spaces, Wikimedia, Policy, Prioritized

Jun 8 2015

Krenair added a comment to T6802: "Custom policy" for editing/viewing does not link to details.

And the ability to actually see custom policy details such as the one for our "Can Edit Task Projects" Maniphest application policy please.

Jun 8 2015, 4:53 PM · Design, Policy
Krenair updated the task description for T6802: "Custom policy" for editing/viewing does not link to details.
Jun 8 2015, 4:51 PM · Design, Policy

Jun 5 2015

Krenair added a member for Space Test Users: Krenair.
Jun 5 2015, 6:30 PM
Krenair added a comment to T8434: Accommodate the "Security" workflow.
  • The original reporter can not see the task or any work done on the task, only the separate discussion on their original report. This allows security response to be separated from communication with the reporter.

That does not sound desirable to me in our context

It can be desirable. Being able to exclude reporters/ commenters on certain tasks from certain updates is very useful for handling procurement requests (such an RT feature was used at least by Wikimedia's Operations team).

Jun 5 2015, 1:58 PM · Wikimedia, Policy, Prioritized
Krenair added a comment to T8434: Accommodate the "Security" workflow.

How would you like the flow where you give permission to new users to work? In T4411, @chasemp expressed some concerns about using CC/Subscribers for this (particularly, that users can add other users to CC). Do you share those concerns, or is adding users to CC to give them rights satisfactory for you?

Fine with me personally, that was the system in BZ. I do wonder what Chris thinks about this now though.

Jun 5 2015, 1:57 PM · Wikimedia, Policy, Prioritized
Krenair added a comment to T8434: Accommodate the "Security" workflow.
In T8434#118721, @qgil wrote:

In general I also like the concept of "hard spaces", simpler to understand
and to protect.
There is this "misuse" case that hard spaces would about: Security team
member leaves the team for some reason while staying as a regular
contributor.... but keeps access to old tasks that he authored. It is
simpler if you are either in our out.

Jun 5 2015, 1:22 PM · Wikimedia, Policy, Prioritized
Krenair updated subscribers of T8434: Accommodate the "Security" workflow.
  • The original reporter can not see the task or any work done on the task, only the separate discussion on their original report. This allows security response to be separated from communication with the reporter.

That does not sound desirable to me in our context (unless the Nuance entry was basically just a special task, where we could have to option to continue as normal while including the reporter), what do you think @csteipp?

Jun 5 2015, 12:28 PM · Wikimedia, Policy, Prioritized

May 28 2015

Krenair added a comment to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects.

Objects which support spaces get a new "Space:" control on their edit forms.

May 28 2015, 5:14 PM · Spaces, Policy, Wikimedia

May 19 2015

Krenair placed T6897: Diffusion commit email notification does not specify branch up for grabs.
May 19 2015, 7:25 PM · Diffusion
Krenair abandoned D12891: Specify branch in Diffusion commit email.

I don't think I know enough about Git and Phabricator's internals to do this.

May 19 2015, 7:25 PM
Krenair added a comment to D12891: Specify branch in Diffusion commit email.

I checked the email quickly, but clearly not well enough.

May 19 2015, 6:57 PM
Krenair merged T8056: Set workboard default filter into T6641: Support changing default sort of a workboard.
May 19 2015, 2:35 PM · Projects, Workboards
Krenair merged task T8056: Set workboard default filter into T6641: Support changing default sort of a workboard.
May 19 2015, 2:35 PM · Projects

May 17 2015

Krenair claimed T6897: Diffusion commit email notification does not specify branch.
May 17 2015, 10:43 PM · Diffusion
Krenair added a task to D12891: Specify branch in Diffusion commit email: T6897: Diffusion commit email notification does not specify branch.
May 17 2015, 10:42 PM
Krenair added a revision to T6897: Diffusion commit email notification does not specify branch: D12891: Specify branch in Diffusion commit email.
May 17 2015, 10:42 PM · Diffusion
Krenair changed the visibility for T1895: Disable live previews .
May 17 2015, 2:53 PM · User Preferences

May 14 2015

Krenair created T8200: Upload File explanation dialog displays behind fullscreen editor.
May 14 2015, 7:29 PM · Restricted Project, Remarkup, Files

May 10 2015

Krenair updated the diff for D12788: Don't claim logged out users are automatically subscribed to un-owned objects.

Just fix the caller in PhabricatorSubscriptionsUIEventListener.

May 10 2015, 4:08 PM
Krenair retitled D12788: Don't claim logged out users are automatically subscribed to un-owned objects from to Don't claim logged out users are automatically subscribed to un-owned objects.
May 10 2015, 3:47 PM

Feb 19 2015

Krenair added a comment to T6183: Allow any user to watch projects.

Creating restricted-join projects (or perhaps duplicate projects so one can be used for ACL, and the other for grouping objects) on Wikimedia will have to get a lot harder unless this can be fixed.

Feb 19 2015, 5:48 PM · Wikimedia, Projects

Feb 18 2015

Krenair updated the task description for T7319: '1 watcher(s)' as well as 'a member' in project edit logs.
Feb 18 2015, 10:20 PM · Projects
Krenair created T7319: '1 watcher(s)' as well as 'a member' in project edit logs.
Feb 18 2015, 10:20 PM · Projects
Krenair created T7317: Can't view other subscribers while logged out.
Feb 18 2015, 5:43 PM · Policy, Maniphest

Feb 9 2015

Krenair awarded T1205: Allow grey users in some form or other a Like token.
Feb 9 2015, 2:26 AM · Restricted Project, People, Auth, Wikimedia

Feb 8 2015

Krenair added a comment to T7209: Scollbar with Trackpad inconsistent with Desktop/Mouse.

Google Chrome, Ubuntu, trackpad.

Feb 8 2015, 4:25 PM · PHUI
Krenair created T7209: Scollbar with Trackpad inconsistent with Desktop/Mouse.
Feb 8 2015, 2:19 AM · PHUI

Jan 31 2015

Krenair added a comment to T6802: "Custom policy" for editing/viewing does not link to details.

Also if you press 'Custom Policy' for visibility below the title of things like Pastes, it doesn't provide a very useful message.

Jan 31 2015, 12:16 AM · Design, Policy

Jan 27 2015

Krenair created T7051: Moving back to a task does not re-create correct Status/CC/Project field despite remembered 'Action' value.
Jan 27 2015, 6:39 AM · Maniphest

Jan 14 2015

Krenair awarded T1191: Comments are truncated at first non-base-plane character a Mountain of Wealth token.
Jan 14 2015, 4:22 AM · Wikimedia, Support Impact, High Support Impact, Differential

Jan 9 2015

Krenair added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).

Yeah I wasn't sure whether to generalise this or open a new task. In BZ we'd have to open new bugs, but here we can just add extra projects... :)

Jan 9 2015, 9:44 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
Krenair added a project to T4768: Phabricator silently overwrites concurrent changes (no conflict detection): Wikimedia.

We ( Wikimedia ) see this problem (lack of conflict detection) often in Maniphest, but it probably applies to more than just these two projects... See https://phabricator.wikimedia.org/T78236

Jan 9 2015, 9:11 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
Krenair added a comment to T6895: Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns.

Yep, that's what I meant. Thanks @epriestley

Jan 9 2015, 7:34 PM · Transactions

Jan 8 2015

Krenair added a comment to T6895: Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns.

Nope, that's right. I can reproduce the issue here.

Jan 8 2015, 7:57 PM · Transactions
Krenair closed T6898: Email notifications for comments are missing files as Invalid.

Ah, it was edited in after the initial comment. Sorry about that.

Jan 8 2015, 4:25 PM · Mail
Krenair added a comment to T6898: Email notifications for comments are missing files.

Those show up fine in my gmail actually. I saw this on https://phabricator.wikimedia.org/T86160#962778

Jan 8 2015, 4:24 PM · Mail
Krenair created T6898: Email notifications for comments are missing files.
Jan 8 2015, 3:49 PM · Mail
Krenair created T6897: Diffusion commit email notification does not specify branch.
Jan 8 2015, 3:44 PM · Diffusion
Krenair created T6895: Inside "View Edit History" dialog, comments are rendered with nonfunctional dropdowns.
Jan 8 2015, 2:27 PM · Transactions

Jan 7 2015

Krenair updated the task description for T6869: Mailing list "Public (No Login Required)" application use policy seems uneffective.
Jan 7 2015, 10:56 AM · Mailing Lists

Jan 5 2015

Krenair created T6869: Mailing list "Public (No Login Required)" application use policy seems uneffective.
Jan 5 2015, 6:30 PM · Mailing Lists

Jan 4 2015

Krenair resigned from auditing rP7cab903943f5: Migrate Differential revision edges to use modern `EdgeType` subclasses.

This got fixed in rP2dea110 it seems.

Jan 4 2015, 5:09 PM · Blessed Reviewers
Krenair added a comment to T4968: Change phrasing of "task subscriber added" message.
  • Change the prototypes on PhabricatorEdgeType for getTransactionAddString(), getTransactionRemoveString(), getTransactionEditString(), getFeedAddString(), getFeedRemoveString(), and getFeedEditString() to take $object as the first parameter. Change callsites in PhabricatorApplicationTransaction to pass $this->getObject().
Jan 4 2015, 12:51 AM · Maniphest

Jan 3 2015

Krenair added a comment to T4968: Change phrasing of "task subscriber added" message.
  • Convert PhabricatorEdgeConfig::TYPE_OBJECT_HAS_SUBSCRIBER and PhabricatorEdgeConfig::TYPE_SUBSCRIBED_TO_OBJECT to Phabricator...EdgeType classes. D9839 has an example of how to apply this modernization.

Looks like this was done in rP7c2a7

Jan 3 2015, 8:59 PM · Maniphest
Krenair raised a concern with rP7cab903943f5: Migrate Differential revision edges to use modern `EdgeType` subclasses.

Shouldn't DiffusionCommitHasRevisionEdgeType and DifferentialReviewerForRevisionEdgeType have get*String functions? Is this what is causing the Herald entries on https://secure.phabricator.com/project/edit/1308/ ?

Jan 3 2015, 8:09 PM · Blessed Reviewers
Krenair updated subscribers of rP7cab903943f5: Migrate Differential revision edges to use modern `EdgeType` subclasses.
Jan 3 2015, 8:09 PM · Blessed Reviewers