Maniphest T8940

Annotate badges with awarder, date
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	chad
	Jul 23 2015, 8:05 PM

Tags

Referenced Files

	F1202370: pasted_file
	Apr 3 2016, 1:59 AM

Subscribers

View All 9 Subscribers

Description

The back of the badge card should state who awarded it and when.

Revisions and Commits

rP Phabricator
		D15590	rP88d15ce79910 Adding awarder info to recipient list on badge view
	Concern Raised	D15570	rP219357aa9fa3 Adding awarder info to badge cards displayed on user profile pages

Related Objects
Search...

		Status	Assigned	Task
		Resolved	lpriestley	T8940 Annotate badges with awarder, date
		Resolved	lpriestley	T8996 Move Badge awards to be an actual object, not an edge

Event Timeline

chad created this task.Jul 23 2015, 8:05 PM

chad claimed this task.

chad raised the priority of this task from to Needs Triage.

chad updated the task description. (Show Details)

chad added a project: Badges.

chad moved this task to Backlog on the Badges board.

chad added subscribers: chad, epriestley.

Herald added a subscriber: eadler. · View Herald TranscriptJul 23 2015, 8:05 PM

"Awarded due to herald rule H102" ;)

chad moved this task from Backlog to v1 on the Badges board.Jul 26 2015, 12:18 AM

chad added a subtask: T8996: Move Badge awards to be an actual object, not an edge.Jul 28 2015, 10:52 PM

chad moved this task from v1 to Backlog on the Badges board.

chad moved this task from Backlog to v1 on the Badges board.

It'd be nice to also have a note as to why the badge was awarded (and not just who awarded it + date)

joshuaspence added a subscriber: joshuaspence.Jul 29 2015, 9:11 AM

devurandom added a subscriber: devurandom.Aug 13 2015, 6:55 AM

chad triaged this task as Low priority.Dec 10 2015, 9:24 PM

epriestley moved this task from v1 to v0 on the Badges board.Jan 2 2016, 12:23 AM

Do T8996 first.
Add an awarderPHID or similar to the new table and start storing who awarded the badge.
Render it in the UI somewhere.
That's good for unbeta, we can add commemorative notes and stuff later. I want to rework the award flow a bit sooner or later anyway.

chad moved this task from v0 to v0 on the Badges board.Feb 6 2016, 5:55 AM

chad edited projects, added Badges (v0); removed Badges.

lpriestley closed subtask T8996: Move Badge awards to be an actual object, not an edge as Resolved.Mar 28 2016, 6:02 PM

chad removed chad as the assignee of this task.Mar 28 2016, 7:35 PM

epriestley assigned this task to lpriestley.Mar 28 2016, 7:36 PM

We currently track awarderPHID in the badges_award table. Do we still need an awarderPHID in badges_badge table?

No, badges themselves don't have an awarder.

We'd only show the awarder on user profiles, e.g. @dog gave @cat this badge on Apr 1, 2016.

lpriestley added a revision: D15570: Adding awarder info to badge cards displayed on user profile pages.Apr 2 2016, 12:54 AM

lpriestley added a commit: rP219357aa9fa3: Adding awarder info to badge cards displayed on user profile pages.Apr 3 2016, 1:23 AM

What's left is adding Awarded by ... to recipient list on badge view:

pasted_file (1×1 px, 174 KB)

lpriestley added a revision: D15590: Adding awarder info to recipient list on badge view.Apr 3 2016, 2:19 AM

lpriestley closed this task as Resolved by committing rP88d15ce79910: Adding awarder info to recipient list on badge view.Apr 3 2016, 3:20 PM

lpriestley added a commit: rP88d15ce79910: Adding awarder info to recipient list on badge view.

urzds added a subscriber: urzds.Jul 12 2017, 11:14 AM