Page MenuHomePhabricator

ApplicationEditor Errata
Closed, ResolvedPublic

Description

Followup to T9908. Known issues:

  • No way to remove stacked actions on mobile.
  • Focusing action selector on Linux / Windows and using the keyboard selects every option.
  • Change "Actions" button text to "Configure" or similar. (D14808)
  • Reduce roughness of EditEngineConfiguration UIs. (D14808) Form edit views could be better, eventually.
  • "Quick Create" items should be indented.
  • Redirect URI handling for logged-out users could be improved. (D14804, D14805, D14806)
  • "Space" control can be set to a problematic visibility value (T9999).
  • Custom field default issues are way more obvious/problematic now (T5158).
  • Useless transactions on object creation are much more prevalent/annoying now than they were before (T7661 / T9527).
  • Some controls have nonexistent or misleading disabled states (T9871).
  • Some of the HTTP parameter stuff, particularly in Maniphest, got out of sync a little after Conduit/Comment changes.
  • Adding new TYPE_CREATE transactions sooner rather than later is probably desirable.
  • Create forms with custom fields lose values after submit on error.
  • Permissions for reordering aren't handled properly. (T10012)
  • Incorrect message text when creating a subtask. (T10021)
  • Spaces control does not allow editing of form defaults.

Future possible stuff:

  • Global Haunt Mode
  • Switch edit forms mode: switch to a different edit form, so your default can be simple even if you have access to a complex one. Not clear this is interesting/useful.
  • Allow this form to create objects the viewer can not edit mode: not sure if there's a need for this, but this would be an ultra-strict, write-once, read-only mode. Probably obsoleted by Nuance.
  • Refine the workboard/form interaction: currently, "New Task" on workboards always picks the default edit form as a create form.

Related Objects

Mentioned In
T12434: Editing Maniphest's EditEngine form shows "Change Default Values" twice
T10493: Task creation no longer lists projects added (neither the UI nor mail notifications)
T10162: Custom form support for Projects workboards
T10116: ctrl+enter in comment field in maniphest issues with new editor
T10083: Test
Blog Post: Development Notes (2015 Week 52)
T10025: Can't set a default space for tasks created through EditEngine
T10021: Creating new subtask shows incorrect message in parent task
T10013: Create Subtask redirect to maniphest/task/edit/form/6, even if user is not part of community
Blog Post: Development Notes (2015 Week 51)
T9905: Upgrading: ApplicationEditor changes in Maniphest
Mentioned Here
T10116: ctrl+enter in comment field in maniphest issues with new editor
T10083: Test
T10021: Creating new subtask shows incorrect message in parent task
T10012: Reorder forms possible for everyone
D14808: Improve UX for customizing EditEngine forms a little bit
D14805: Remove all setObjectURI() from ActionListViews
D14806: Improve handling of multiple edit forms when logged out
D14804: When logged-out users hit a "Login Required" dialog, try to choose a better "next" URI
T9871: Some PHUI form controls do not have identifiable "disabled" states
T9999: EditEngine "Space" field is configurable as visible/locked/hidden, but should always have the same value as "View Policy"
T5158: Maniphest custom field refuses to use non-empty default value
T7661: Object creation is often accompanied by transaction records which aren't of much use
T9527: Confusing "... shifted this object from the S1 Public space to..."
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
epriestley updated the task description. (Show Details)
epriestley updated the task description. (Show Details)
epriestley renamed this task from ApplicationEditor Errata to ApplicationEditor Errata.Dec 17 2015, 7:03 PM
epriestley updated the task description. (Show Details)

Change Priority only appears in Maniphest if the Status is OPEN. I ran into a case where I wanted to re-open a task and assign it a priority.

Locking the icon field in projects doesn't actually work, it's still possible to edit the icon when that field is locked.

Ah, thanks. I think it's just missing a disabled state -- I wouldn't expect the edit to actually go through when you save (or are you seeing the edit work, too?).

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

This issue still occurs for me.

I can't reproduce that. Here's what I did:

I selected "Change Status: ...", picked a different status (here, "Wontfix"), and added a comment:

I submitted the form and saw the task status change and the comment show up in the transaction log:

Yeah, I can't reproduce it anymore either. I definitely saw it earlier today on a different install (which is up-to-date within a couple of hours) but I don't know what was special then.

Yeah, I can't reproduce it anymore either. I definitely saw it earlier today on a different install (which is up-to-date within a couple of hours) but I don't know what was special then.

Okay, I can reproduce it reliably.l with the following steps.

  1. Create a global Herald rule with condition [projects] [include any of] [#some_project] and action [add project] [#some_other_project].
  2. Create a task tagged with #some_project.
  3. Attempt to change ticket status AND comment on task at the same time.

Actually, I am seeing still seeing this issue on our install on tasks which aren't affected by any Herald rule (that I know of).

OK, I managed to reproduce it on this install, see T10083. Specifically see T10083#151963 in which I attempted to close the task as resolved.

OK, I managed to reproduce it on this install, see T10083. Specifically see T10083#151963 in which I attempted to close the task as resolved.

I think that it occurs if I hit submit before the Remarkup preview has finished rendering.

I think T10116 may have fixed the "actions ignored" issue -- does it still reproduce for you after that?

I'd be interested in the Refine the workboard/form interaction idea.

Could this be done by adding a parameter to editing of a project. Under the user rights like the "Joinable by" there could be parameters for the "create form" and "edit form" which would be visible if the user has access + if they are changed it reverts to the global default forms