Page MenuHomePhabricator
Create Task
Maniphest T9010

Allow badges to have any Font Awesome icon
Closed, ResolvedPublic
Actions

Assigned To
chad
Authored By
hach-que
Jul 29 2015, 11:55 PM
Tags
Referenced Files
F676370: pasted_file
Jul 30 2015, 12:00 AM
Subscribers
cburroughs
chad
eadler
hach-que
jason.koopmans
johnny-bit
joshuaspence
yelirekim
Tokens
"Doubloon" token, awarded by lavahot."Piece of Eight" token, awarded by joshuaspence.

Description

When you have lots of badges, 16 icons is pretty limiting, especially when there are some Font Awesome icons that really suit certain situations. For example, when we give out a badge for installing the experimental version of Windows on your development machine, we can use , which is far more suitable than having most badges with because nothing else fits.

I realise there's the usual "we should only have 16 icons so they're unique in the system", as is the case for project icons, but in this case I think it's warranted because badges are ~pretty special~.

Revisions and Commits

rP Phabricator
D17456rP1460f2b85ca8 Add more icon choices to Badges

Related Objects
Search...

StatusAssignedTask
 ResolvedNoneT11971 Build an Icon Typeahead
 ResolvedchadT9010 Allow badges to have any Font Awesome icon

Event Timeline

hach-que created this task.Jul 29 2015, 11:55 PM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Badges.
hach-que added subscribers: hach-que, chad.
Herald added a subscriber: eadler. · View Herald TranscriptJul 29 2015, 11:55 PM
hach-que added a comment.Jul 30 2015, 12:00 AM

I mean, just look at how pretty these are with their icons (I set these via SQL updates):

pasted_file (289×373 px, 30 KB)

hach-que added a comment.Jul 30 2015, 12:02 AM

is even better for the fire fighting badge :3

jason.koopmans added a subscriber: jason.koopmans.Jul 30 2015, 1:35 AM

joshuaspence awarded a token.Jul 30 2015, 1:14 PM
joshuaspence added a subscriber: joshuaspence.
johnny-bit added a subscriber: johnny-bit.Jul 30 2015, 2:36 PM

- fought with IE bravely? (icon internet-explorer ws added in FA 4.4.0).

This IS kinda reasonable, but imagine browsing icons for match when creating badges... not only are there ~6 levels of badge awesomnes, there would be hundreds of icons to choose from...

hach-que added a comment.Jul 31 2015, 3:17 AM

I would imagine either a type ahead or a text box to enter the name of an icon that isn't one of the standard 16.

cburroughs added a subscriber: cburroughs.Jul 31 2015, 1:41 PM
chad added a comment.Aug 9 2015, 4:00 AM

Very unlikely to pursue this because:

  1. Philosophically Opposed
  2. Time Constrained

But I could increase the icons by another 9 if you have generic requests.

epriestley triaged this task as Wishlist priority.Jan 2 2016, 12:21 AM
epriestley moved this task from Backlog to Far Future on the Badges board.
• lavahot awarded a token.Feb 5 2016, 6:44 AM
yelirekim added a subscriber: yelirekim.Feb 5 2016, 8:28 AM

Can I get clarification on philosophical opposition to this? Is it leaking abstraction of the "icon" interface to the end user?

Would it be better if you could, for example, subclass something on the backend and get the same result, then you wouldn't be philosophically opposed to this?

chad moved this task from Far Future to Backlog on the Badges board.Feb 6 2016, 5:55 AM
chad added a comment.Feb 6 2016, 6:35 AM

There's a lot of junk in "any icon", maybe 10% of the Font Awesome set is useful. We also don't have a chooser for "any icon", so we'd need to build something as such. I could be wrong but I think since Badges is on EditEngine you could set any icon over Conduit. I don't know if I read Evan's diffs right or not.

chad added a parent task: T11971: Build an Icon Typeahead.Dec 8 2016, 8:53 PM
chad added a comment.Feb 2 2017, 7:08 PM

itshappening

epriestley mentioned this in D17360: Funbeta Badges.Feb 15 2017, 8:17 PM
chad mentioned this in T12270: Unbeta Badges.Feb 15 2017, 8:23 PM
epriestley mentioned this in D17422: Add a lipsum generator for Badges.Feb 27 2017, 1:18 PM
epriestley mentioned this in rP5cb4c76bef6b: Add a lipsum generator for Badges.Feb 27 2017, 5:10 PM
epriestley mentioned this in D17456: Add more icon choices to Badges.Mar 3 2017, 9:37 PM
chad added a revision: D17456: Add more icon choices to Badges.Mar 3 2017, 9:45 PM
chad added a commit: rP1460f2b85ca8: Add more icon choices to Badges.Mar 3 2017, 9:45 PM
chad added a comment.Mar 3 2017, 9:46 PM

I'm going to close this as resolved, added 9 more icons. I'm going to open a new task to allow any IconSet be extended, which seems a better path for any similar product.

chad closed this task as Resolved.Mar 3 2017, 9:47 PM
chad claimed this task.
Phabricator · Built by Phacility