Page MenuHomePhabricator
Feed All Stories

Tue, Jul 2

epriestley closed D20632: Move workboard "filter" workflow to a separate controller.
Tue, Jul 2, 9:39 PM
amckinley accepted D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Tue, Jul 2, 9:37 PM
epriestley committed rP9e096cd274b0: Give the workboard "default" workflows more modern state handling (authored by epriestley).
Give the workboard "default" workflows more modern state handling
Tue, Jul 2, 9:36 PM
epriestley closed D20629: Give the workboard "default" workflows more modern state handling.
Tue, Jul 2, 9:36 PM
epriestley committed rP9c190d68ed37: Separate workboard view state (ordering, filtering, hidden columns) from the… (authored by epriestley).
Separate workboard view state (ordering, filtering, hidden columns) from the…
Tue, Jul 2, 9:34 PM
epriestley closed D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Tue, Jul 2, 9:34 PM
epriestley updated the diff for D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
  • Use "%p" in urisprintf().
Tue, Jul 2, 9:32 PM
epriestley added inline comments to D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Tue, Jul 2, 9:30 PM
epriestley committed rPHU5fc88a5c73f1: When parsing HTML in remarkup, always start a new tag when encountering "<" (authored by epriestley).
When parsing HTML in remarkup, always start a new tag when encountering "<"
Tue, Jul 2, 9:19 PM
epriestley closed D20631: When parsing HTML in remarkup, always start a new tag when encountering "<".
Tue, Jul 2, 9:19 PM
epriestley committed rPHUeff4eb29ff48: Fix some remarkup issues with selective construction of child nodes after HTML… (authored by epriestley).
Fix some remarkup issues with selective construction of child nodes after HTML…
Tue, Jul 2, 9:13 PM
epriestley closed D20630: Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing.
Tue, Jul 2, 9:13 PM
epriestley requested review of D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Tue, Jul 2, 8:59 PM
epriestley added a revision to T4900: Workboards updating in real time: D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Tue, Jul 2, 8:58 PM · Workboards (v3), User Delight, Wikimedia
amckinley accepted D20633: Move workboard "View as Query" workflow to a separate controller.
Tue, Jul 2, 8:37 PM
amckinley accepted D20632: Move workboard "filter" workflow to a separate controller.
Tue, Jul 2, 8:35 PM
amckinley accepted D20630: Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing.
Tue, Jul 2, 7:25 PM
amckinley accepted D20629: Give the workboard "default" workflows more modern state handling.
Tue, Jul 2, 7:13 PM
epriestley added inline comments to D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Tue, Jul 2, 7:02 PM
amckinley accepted D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Tue, Jul 2, 6:26 PM
amckinley updated the test plan for D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Tue, Jul 2, 5:50 PM
epriestley updated the diff for D20638: Remove obsolete "options" from workboard "updateCard()" call.
  • For better or worse, there actually is an external caller in WorkboardController that slipped past me.
Tue, Jul 2, 5:33 PM
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

It's turtles all the way down. Computers don't work and all conventions and toolsets are fundamentally broken:

Tue, Jul 2, 5:31 PM
amckinley accepted D20631: When parsing HTML in remarkup, always start a new tag when encountering "<".
Tue, Jul 2, 5:25 PM
epriestley requested review of D20638: Remove obsolete "options" from workboard "updateCard()" call.
Tue, Jul 2, 5:21 PM
epriestley added a revision to T4900: Workboards updating in real time: D20638: Remove obsolete "options" from workboard "updateCard()" call.
Tue, Jul 2, 5:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

Here's roughly where I'm headed next. I'm planning to:

Tue, Jul 2, 5:18 PM · Workboards (v3), User Delight, Wikimedia
epriestley added inline comments to D20637: Remove remnants of clumsy old URI state handling from workboards.
Tue, Jul 2, 4:33 PM
epriestley added a comment to T4900: Workboards updating in real time.

The "default" controller currently needs to "force" the URI parameters...
The "filter" controller currently needs to "force" the URI parameters...
The "apply" flow, where a new custom filter is applied...

Tue, Jul 2, 4:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20637: Remove remnants of clumsy old URI state handling from workboards.
Tue, Jul 2, 4:31 PM
epriestley added a revision to T4900: Workboards updating in real time: D20637: Remove remnants of clumsy old URI state handling from workboards.
Tue, Jul 2, 4:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Tue, Jul 2, 3:34 PM
epriestley added a revision to T4900: Workboards updating in real time: D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Tue, Jul 2, 3:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Tue, Jul 2, 3:32 PM · Workboards
epriestley requested review of D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Tue, Jul 2, 2:45 PM
epriestley added a revision to T4900: Workboards updating in real time: D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Tue, Jul 2, 2:43 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Tue, Jul 2, 2:43 PM · Workboards
epriestley added a comment to D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.

In D12475, the "bulk edit" (then, "batch edit") stuff was added originally. This included a "Batch Edit Visible Tasks..." action that brought you into an edit workflow for every visible task on the board.

Tue, Jul 2, 1:25 PM
epriestley requested review of D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Tue, Jul 2, 1:18 PM
epriestley added a revision to T4900: Workboards updating in real time: D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Tue, Jul 2, 1:16 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20633: Move workboard "View as Query" workflow to a separate controller.
Tue, Jul 2, 12:52 PM
epriestley added a revision to T4900: Workboards updating in real time: D20633: Move workboard "View as Query" workflow to a separate controller.
Tue, Jul 2, 12:50 PM · Workboards (v3), User Delight, Wikimedia
epriestley added inline comments to D20632: Move workboard "filter" workflow to a separate controller.
Tue, Jul 2, 12:35 PM
epriestley requested review of D20632: Move workboard "filter" workflow to a separate controller.
Tue, Jul 2, 12:32 PM
epriestley added a revision to T4900: Workboards updating in real time: D20632: Move workboard "filter" workflow to a separate controller.
Tue, Jul 2, 12:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley committed rP0ae9e2c75d1f: Remove property "id" from Workboard View controller (authored by epriestley).
Remove property "id" from Workboard View controller
Tue, Jul 2, 12:17 PM
epriestley closed D20627: Remove property "id" from Workboard View controller.
Tue, Jul 2, 12:17 PM
epriestley committed rPdf29b82ad601: Remove unused property "slug" from Workboard View controller (authored by epriestley).
Remove unused property "slug" from Workboard View controller
Tue, Jul 2, 12:16 PM
epriestley closed D20626: Remove unused property "slug" from Workboard View controller.
Tue, Jul 2, 12:16 PM
epriestley committed rPd22f6d219b0b: Lightly modernize OAuth server application view pages (authored by epriestley).
Lightly modernize OAuth server application view pages
Tue, Jul 2, 12:15 PM
epriestley closed T13330: OAuth Application object view pages have some out-of-date UI elements as Resolved by committing rPd22f6d219b0b: Lightly modernize OAuth server application view pages.
Tue, Jul 2, 12:15 PM · OAuthServer
epriestley closed D20625: Lightly modernize OAuth server application view pages.
Tue, Jul 2, 12:15 PM
epriestley committed rP0e2cb6e7c437: Fix missing URI for "OAuthServerClient" object handles, causing dialog with no… (authored by epriestley).
Fix missing URI for "OAuthServerClient" object handles, causing dialog with no…
Tue, Jul 2, 12:14 PM
epriestley closed D20624: Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button.
Tue, Jul 2, 12:14 PM
epriestley requested review of D20631: When parsing HTML in remarkup, always start a new tag when encountering "<".
Tue, Jul 2, 12:11 AM
epriestley requested review of D20630: Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing.
Tue, Jul 2, 12:05 AM

Sat, Jun 29

epriestley requested review of D20629: Give the workboard "default" workflows more modern state handling.
Sat, Jun 29, 10:36 PM
epriestley added a revision to T4900: Workboards updating in real time: D20629: Give the workboard "default" workflows more modern state handling.
Sat, Jun 29, 10:35 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

A couple of weird cases on state management:

Sat, Jun 29, 10:14 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Sat, Jun 29, 10:13 PM
epriestley added a revision to T4900: Workboards updating in real time: D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Sat, Jun 29, 10:12 PM · Workboards (v3), User Delight, Wikimedia
amckinley accepted D20627: Remove property "id" from Workboard View controller.
Sat, Jun 29, 9:26 PM
amckinley accepted D20626: Remove unused property "slug" from Workboard View controller.
Sat, Jun 29, 9:25 PM
amckinley accepted D20625: Lightly modernize OAuth server application view pages.
Sat, Jun 29, 9:25 PM
amckinley accepted D20624: Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button.
Sat, Jun 29, 9:24 PM
epriestley requested review of D20627: Remove property "id" from Workboard View controller.
Sat, Jun 29, 9:22 PM
epriestley added a revision to T4900: Workboards updating in real time: D20627: Remove property "id" from Workboard View controller.
Sat, Jun 29, 9:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T13233: Consider supporting GPG/PGP.

This is sort of generically concerning to me:

Sat, Jun 29, 8:47 PM · Diffusion, Mail
epriestley requested review of D20626: Remove unused property "slug" from Workboard View controller.
Sat, Jun 29, 8:08 PM
epriestley added a revision to T4900: Workboards updating in real time: D20626: Remove unused property "slug" from Workboard View controller.
Sat, Jun 29, 8:07 PM · Workboards (v3), User Delight, Wikimedia
epriestley moved T13301: Browser "Find..." feature isn't very useful in Safari on Workboards from Backlog to Far Future on the Workboards board.
Sat, Jun 29, 7:54 PM · Workboards
epriestley closed T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts as Resolved.

This is deployed everywhere now, and kicking secure004 over seemed to work correctly, at least.

Sat, Jun 29, 6:57 PM · Phacility
epriestley closed T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date as Resolved.

This stuff is all deployed, now.

Sat, Jun 29, 6:56 PM · Daemons, Phacility
epriestley closed T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date, a subtask of T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts, as Resolved.
Sat, Jun 29, 6:56 PM · Phacility
epriestley requested review of D20625: Lightly modernize OAuth server application view pages.
Sat, Jun 29, 3:37 PM
epriestley added a revision to T13330: OAuth Application object view pages have some out-of-date UI elements: D20625: Lightly modernize OAuth server application view pages.
Sat, Jun 29, 3:36 PM · OAuthServer
epriestley requested review of D20624: Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button.
Sat, Jun 29, 3:29 PM
epriestley added a revision to T13330: OAuth Application object view pages have some out-of-date UI elements: D20624: Fix missing URI for "OAuthServerClient" object handles, causing dialog with no button.
Sat, Jun 29, 3:28 PM · OAuthServer
epriestley triaged T13330: OAuth Application object view pages have some out-of-date UI elements as Low priority.
Sat, Jun 29, 3:24 PM · OAuthServer
krisbuist awarded D20623: Fix the "x" link in tokenizer tokens incorrectly closing dialogs a Like token.
Sat, Jun 29, 2:54 PM
epriestley edited the content of Changelog.
Sat, Jun 29, 12:45 AM
Harbormaster failed to build B23072: rP4c242256e490: (stable) Promote 2019 Week 26 for rP4c242256e490: (stable) Promote 2019 Week 26!
Sat, Jun 29, 12:44 AM
epriestley committed rPHUa4feaf52f4c0: (stable) Promote 2019 Week 26 (authored by epriestley).
(stable) Promote 2019 Week 26
Sat, Jun 29, 12:39 AM
epriestley created an object: 2019 Week 26 (Very Late June).
Sat, Jun 29, 12:39 AM
Herald added 1 auditor(s) for rP4c242256e490: (stable) Promote 2019 Week 26: Cowboy Commits.
(stable) Promote 2019 Week 26
Sat, Jun 29, 12:39 AM

Fri, Jun 28

jbrownEP added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Any update on when this is going to reach stable? We're ~16 weeks past the earlier estimate...

Fri, Jun 28, 11:13 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley committed rPd6dc5d8e68bf: Fix the "x" link in tokenizer tokens incorrectly closing dialogs (authored by epriestley).
Fix the "x" link in tokenizer tokens incorrectly closing dialogs
Fri, Jun 28, 7:39 PM
epriestley closed D20623: Fix the "x" link in tokenizer tokens incorrectly closing dialogs.
Fri, Jun 28, 7:38 PM
D20623: Fix the "x" link in tokenizer tokens incorrectly closing dialogs is now accepted and ready to land.

ayyyyy

Fri, Jun 28, 7:37 PM
epriestley requested review of D20623: Fix the "x" link in tokenizer tokens incorrectly closing dialogs.
Fri, Jun 28, 3:44 PM

Thu, Jun 27

epriestley created T13329: In Phacility, inviting an email address that belongs to a bot/mailing list account hits new "import" language in a confusing way.
Thu, Jun 27, 6:05 PM · Phacility
Herald updated subscribers of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.
Thu, Jun 27, 1:58 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Wed, Jun 26

epriestley committed rP159fd4420319: Correct transaction strengths after inconsitent scaling by 100 vs 1000 (authored by epriestley).
Correct transaction strengths after inconsitent scaling by 100 vs 1000
Wed, Jun 26, 2:19 PM
epriestley closed D20622: Correct transaction strengths after inconsitent scaling by 100 vs 1000.
Wed, Jun 26, 2:19 PM
D20622: Correct transaction strengths after inconsitent scaling by 100 vs 1000 is now accepted and ready to land.
Wed, Jun 26, 2:17 PM
epriestley requested review of D20622: Correct transaction strengths after inconsitent scaling by 100 vs 1000.
Wed, Jun 26, 2:00 PM
epriestley added inline comments to D20540: Stabilize sorting of feed stories with similar strength.
Wed, Jun 26, 1:59 PM
richardvanvelzen added inline comments to D20540: Stabilize sorting of feed stories with similar strength.
Wed, Jun 26, 6:59 AM
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

cd provides "at least once" delivery guarantees.

Wed, Jun 26, 1:44 AM · Daemons, Phacility
epriestley committed rPHU340e00f6622d: When matching process titles, don't attempt a match if we're out of "argv" parts (authored by epriestley).
When matching process titles, don't attempt a match if we're out of "argv" parts
Wed, Jun 26, 1:27 AM