HomePhabricator

Fix the "x" link in tokenizer tokens incorrectly closing dialogs

Description

Fix the "x" link in tokenizer tokens incorrectly closing dialogs

Summary:
See https://discourse.phabricator-community.org/t/removing-tags-or-subscribers-from-a-maniphest-modal-causes-the-modal-to-close/2874.

My Javascript is rusty: '' + null == 'null'. Same for undefined. Use an explicit typecheck instead.

Test Plan: Clicked the "x" in a tokenizer token in a dialog, saw the token removed instead of the dialog closed.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20623

Details

Provenance
epriestleyAuthored on Jun 28 2019, 3:40 PM
epriestleyPushed on Jun 28 2019, 7:38 PM
Reviewer
amckinley
Differential Revision
D20623: Fix the "x" link in tokenizer tokens incorrectly closing dialogs
Parents
rP159fd4420319: Correct transaction strengths after inconsitent scaling by 100 vs 1000
Branches
Unknown
Tags
Unknown
Build Status
Buildable 23071
Build 31670: Run Core Tests