Page MenuHomePhabricator

When matching process titles, don't attempt a match if we're out of "argv" parts
ClosedPublic

Authored by epriestley on Jun 25 2019, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 11:34 PM
Unknown Object (File)
Oct 1 2024, 4:20 AM
Unknown Object (File)
Sep 25 2024, 2:06 AM
Unknown Object (File)
Sep 12 2024, 11:59 PM
Unknown Object (File)
Sep 6 2024, 6:31 AM
Unknown Object (File)
Sep 6 2024, 6:31 AM
Unknown Object (File)
Sep 6 2024, 6:31 AM
Unknown Object (File)
Sep 5 2024, 8:52 PM
Subscribers
None

Details

Summary

Ref T13321. In general, if we try to match against "array('x', 'y')" and there's an "array('x')" process, we may run out of arguments before matching the whole pattern.

On Ubuntu, there are a bunch of system processes which look like [khugepaged] in ps. These have no /proc/123/cmdline, so we end up with an empty "argv", which is causing us to hit the bug. Just let this be for now, we don't currently care about these processes.

Test Plan

Ran bin/phd status on Ubuntu.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable