Page MenuHomePhabricator

When matching process titles, don't attempt a match if we're out of "argv" parts
ClosedPublic

Authored by epriestley on Jun 25 2019, 10:21 PM.
Tags
None
Referenced Files
F15448817: D20620.id.diff
Fri, Mar 28, 7:03 AM
F15438648: D20620.id49193.diff
Wed, Mar 26, 2:19 AM
F15437003: D20620.id.diff
Tue, Mar 25, 4:59 PM
F15430261: D20620.diff
Mar 24 2025, 6:48 AM
F15428697: D20620.diff
Mar 23 2025, 9:46 PM
F15428136: D20620.id.diff
Mar 23 2025, 6:39 PM
F15406819: D20620.diff
Mar 18 2025, 2:02 PM
F15377679: D20620.id49194.diff
Mar 13 2025, 10:10 AM
Subscribers
None

Details

Summary

Ref T13321. In general, if we try to match against "array('x', 'y')" and there's an "array('x')" process, we may run out of arguments before matching the whole pattern.

On Ubuntu, there are a bunch of system processes which look like [khugepaged] in ps. These have no /proc/123/cmdline, so we end up with an empty "argv", which is causing us to hit the bug. Just let this be for now, we don't currently care about these processes.

Test Plan

Ran bin/phd status on Ubuntu.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable